ActiveRecordModel::findAll() - Code Metrics - Inspection of "intermediate for 1.1" - canax/database - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( ba1fe5...03a684 )

by Mikael

created 2017-08-30 06:05 UTC

ActiveRecordModel::findAll() A

↳ Parent: ActiveRecordModel

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php

namespace Anax\Database;

use \Anax\Database\DatabaseQueryBuilder;

/**
 * An implementation of the Active Record pattern to be used as
 * base class for database driven models.
 */
class ActiveRecordModel
{
    /**
     * @var string TABLE_NAME name of the database table.
     */
    protected $tableName = null;



    /**
     * Constructor.
     *
     * @param DatabaseQueryBuilder $db as database access object.
     */
    public function __construct(DatabaseQueryBuilder $db)
    {
        $this->db = $db;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }



    /**
     * Get essential object properties.
     *
     * @return array with object properties.
     */
    private function getProperties()
    {
        $properties = get_object_vars($this);
        unset($properties['tableName']);
        unset($properties['db']);
        unset($properties['di']);
        return $properties;
    }



    /**
     * Set object properties.
     *
     * @param array $properties with properties to set.
     *
     * @return void
     */
    // private function setProperties($properties)
    // {
    //     if (!empty($properties)) {
    //         foreach ($properties as $key => $val) {
    //             $this->$key = $val;
    //         }
    //     }
    // }



    /**
     * Find and return first object found by search criteria and use
     * its data to populate this instance.
     *
     * @param string $column to use in where statement.
     * @param mixed  $value  to use in where statement.
     *
     * @return this
     */
    public function find($column, $value)
    {
        return $this->db->connect()
                        ->select()
                        ->from($this->tableName)
                        ->where("$column = ?")
                        ->execute([$value])
                        ->fetchInto($this);
    }



    /**
     * Find and return all.
     *
     * @return array
     */
    public function findAll()
    {
        $db = $this->db;
        return $db->connect()
                  ->select()
                  ->from($this->tableName)
                  ->execute()
                  ->fetchAllClass(__CLASS__);
    }



    /**
     * Save current object/row, insert if id is missing and do an
     * update if the id exists.
     *
     * @return void
     */
    public function save()
    {
        if (isset($this->id)) {
            return $this->update();

        }

        return $this->create();
    }



    /**
     * Create new row.
     *
     * @return void
     */
    private function create()

    {
        $db = $this->db;
        $properties = $this->getProperties();
        unset($properties['id']);
        $columns = array_keys($properties);
        $values  = array_values($properties);

        $db->connect()
           ->insert($this->tableName, $columns)
           ->execute($values);

        $this->id = $this->db->lastInsertId();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }



    /**
     * Update row.
     *
     * @param array $values key/values to save.
     *
     * @return void
     */
    private function update($values)

    {
        $db = $this->db;
        $properties = $this->getProperties();
        unset($properties['id']);
        $columns = array_keys($properties);
        $values  = array_values($properties);
        $values[] = $this->id;

        $db->connect()
           ->update($this->tableName, $columns)
           ->where("id = ?")
           ->execute($values);
    }



    /**
     * Delete row.
     *
     * @param integer $id to delete or use $this->id as default.
     *
     * @return void
     */
    public function delete($id = null)
    {
        $db = $this->db;
        $id = $id ?: $this->id;

        $db->connect()
           ->deleteFrom(self::CLASS_NAME)
           ->where("id = ?")
           ->execute([$id]);

        $this->id = null;
    }
}


1		<?php
2
3		namespace Anax\Database;
4
5		use \Anax\Database\DatabaseQueryBuilder;
6
7		/**
8		* An implementation of the Active Record pattern to be used as
9		* base class for database driven models.
10		*/
11		class ActiveRecordModel
12		{
13		/**
14		* @var string TABLE_NAME name of the database table.
15		*/
16		protected $tableName = null;
17
18
19
20		/**
21		* Constructor.
22		*
23		* @param DatabaseQueryBuilder $db as database access object.
24		*/
25		public function __construct(DatabaseQueryBuilder $db)
26		{
27		$this->db = $db;
		0 ignored issues – show Bug introduced 2017-08-30 06:06 UTC by Report Bug Copy Issue Report The property `db` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28		}
29
30
31
32		/**
33		* Get essential object properties.
34		*
35		* @return array with object properties.
36		*/
37		private function getProperties()
38		{
39		$properties = get_object_vars($this);
40		unset($properties['tableName']);
41		unset($properties['db']);
42		unset($properties['di']);
43		return $properties;
44		}
45
46
47
48		/**
49		* Set object properties.
50		*
51		* @param array $properties with properties to set.
52		*
53		* @return void
54		*/
55		// private function setProperties($properties)
56		// {
57		// if (!empty($properties)) {
58		// foreach ($properties as $key => $val) {
59		// $this->$key = $val;
60		// }
61		// }
62		// }
63
64
65
66		/**
67		* Find and return first object found by search criteria and use
68		* its data to populate this instance.
69		*
70		* @param string $column to use in where statement.
71		* @param mixed $value to use in where statement.
72		*
73		* @return this
74		*/
75		public function find($column, $value)
76		{
77		return $this->db->connect()
78		->select()
79		->from($this->tableName)
80		->where("$column = ?")
81		->execute([$value])
82		->fetchInto($this);
83		}
84
85
86
87		/**
88		* Find and return all.
89		*
90		* @return array
91		*/
92		public function findAll()
93		{
94		$db = $this->db;
95		return $db->connect()
96		->select()
97		->from($this->tableName)
98		->execute()
99		->fetchAllClass(__CLASS__);
100		}
101
102
103
104		/**
105		* Save current object/row, insert if id is missing and do an
106		* update if the id exists.
107		*
108		* @return void
109		*/
110		public function save()
111		{
112		if (isset($this->id)) {
113		return $this->update();
		0 ignored issues – show Bug introduced 2017-08-30 06:06 UTC by Report Bug Copy Issue Report The call to `update()` misses a required argument `$values`. This check looks for function calls that miss required arguments. Loading history...
114		}
115
116		return $this->create();
117		}
118
119
120
121		/**
122		* Create new row.
123		*
124		* @return void
125		*/
126	View Code Duplication	private function create()
		0 ignored issues – show Duplication introduced 2017-08-30 06:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		{
128		$db = $this->db;
129		$properties = $this->getProperties();
130		unset($properties['id']);
131		$columns = array_keys($properties);
132		$values = array_values($properties);
133
134		$db->connect()
135		->insert($this->tableName, $columns)
136		->execute($values);
137
138		$this->id = $this->db->lastInsertId();
		0 ignored issues – show Bug introduced 2017-08-30 06:06 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
139		}
140
141
142
143		/**
144		* Update row.
145		*
146		* @param array $values key/values to save.
147		*
148		* @return void
149		*/
150	View Code Duplication	private function update($values)
		0 ignored issues – show Unused Code introduced 2017-08-30 06:06 UTC by Report Bug Copy Issue Report The parameter `$values` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-08-30 06:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		$db = $this->db;
153		$properties = $this->getProperties();
154		unset($properties['id']);
155		$columns = array_keys($properties);
156		$values = array_values($properties);
157		$values[] = $this->id;
158
159		$db->connect()
160		->update($this->tableName, $columns)
161		->where("id = ?")
162		->execute($values);
163		}
164
165
166
167		/**
168		* Delete row.
169		*
170		* @param integer $id to delete or use $this->id as default.
171		*
172		* @return void
173		*/
174		public function delete($id = null)
175		{
176		$db = $this->db;
177		$id = $id ?: $this->id;
178
179		$db->connect()
180		->deleteFrom(self::CLASS_NAME)
181		->where("id = ?")
182		->execute([$id]);
183
184		$this->id = null;
185		}
186		}
187

canax / database

Push — master ( ba1fe5...03a684 )

ActiveRecordModel::findAll() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like