Complex classes like PdoAdapter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PdoAdapter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
40 | abstract class PdoAdapter extends AbstractAdapter |
||
41 | { |
||
42 | /** |
||
43 | * @var \PDO|null |
||
44 | */ |
||
45 | protected $connection; |
||
46 | |||
47 | /** |
||
48 | * {@inheritdoc} |
||
49 | */ |
||
50 | public function setOptions(array $options) |
||
51 | 287 | { |
|
52 | parent::setOptions($options); |
||
53 | 287 | ||
54 | if (isset($options['connection'])) { |
||
55 | 287 | $this->setConnection($options['connection']); |
|
56 | 3 | } |
|
57 | 3 | ||
58 | return $this; |
||
59 | 287 | } |
|
60 | |||
61 | /** |
||
62 | * Sets the database connection. |
||
63 | * |
||
64 | * @param \PDO $connection Connection |
||
65 | * @return \Phinx\Db\Adapter\AdapterInterface |
||
66 | */ |
||
67 | public function setConnection(\PDO $connection) |
||
68 | 193 | { |
|
69 | $this->connection = $connection; |
||
70 | 193 | ||
71 | // Create the schema table if it doesn't already exist |
||
72 | if (!$this->hasSchemaTable()) { |
||
73 | 193 | $this->createSchemaTable(); |
|
74 | 191 | } else { |
|
75 | 191 | $table = new Table($this->getSchemaTableName(), [], $this); |
|
76 | 74 | if (!$table->hasColumn('migration_name')) { |
|
77 | 74 | $table |
|
78 | ->addColumn( |
||
79 | 'migration_name', |
||
80 | 'string', |
||
81 | ['limit' => 100, 'after' => 'version', 'default' => null, 'null' => true] |
||
82 | ) |
||
83 | ->save(); |
||
84 | } |
||
85 | if (!$table->hasColumn('breakpoint')) { |
||
86 | 74 | $table |
|
87 | ->addColumn('breakpoint', 'boolean', ['default' => false]) |
||
88 | ->save(); |
||
89 | } |
||
90 | } |
||
91 | |||
92 | return $this; |
||
93 | 193 | } |
|
94 | |||
95 | /** |
||
96 | * Gets the database connection |
||
97 | * |
||
98 | * @return \PDO |
||
99 | */ |
||
100 | public function getConnection() |
||
101 | 191 | { |
|
102 | if ($this->connection === null) { |
||
103 | 191 | $this->connect(); |
|
104 | 189 | } |
|
105 | 189 | ||
106 | 191 | return $this->connection; |
|
107 | } |
||
108 | |||
109 | /** |
||
110 | * {@inheritdoc} |
||
111 | */ |
||
112 | 1 | public function connect() |
|
115 | |||
116 | /** |
||
117 | * {@inheritdoc} |
||
118 | */ |
||
119 | public function disconnect() |
||
122 | |||
123 | /** |
||
124 | * {@inheritdoc} |
||
125 | */ |
||
126 | 218 | public function execute($sql) |
|
136 | |||
137 | /** |
||
138 | * Executes a query and returns PDOStatement. |
||
139 | * |
||
140 | * @param string $sql SQL |
||
141 | * @return \PDOStatement |
||
142 | 220 | */ |
|
143 | public function query($sql) |
||
147 | |||
148 | /** |
||
149 | * {@inheritdoc} |
||
150 | 151 | */ |
|
151 | public function fetchRow($sql) |
||
157 | |||
158 | /** |
||
159 | 213 | * {@inheritdoc} |
|
160 | */ |
||
161 | 213 | public function fetchAll($sql) |
|
171 | |||
172 | 1 | /** |
|
173 | * {@inheritdoc} |
||
174 | 1 | */ |
|
175 | 1 | public function insert(Table $table, $row) |
|
193 | 11 | ||
194 | 11 | /** |
|
195 | 11 | * Quotes a database value. |
|
196 | * |
||
197 | 11 | * @param mixed $value The value to quote |
|
198 | 11 | * @return mixed |
|
199 | 11 | */ |
|
200 | private function quoteValue($value) |
||
212 | 11 | ||
213 | 11 | /** |
|
214 | * {@inheritdoc} |
||
215 | 11 | */ |
|
216 | 11 | public function bulkinsert(Table $table, $rows) |
|
250 | 7 | ||
251 | /** |
||
252 | 7 | * {@inheritdoc} |
|
253 | */ |
||
254 | public function getVersions() |
||
260 | 5 | ||
261 | /** |
||
262 | 5 | * {@inheritdoc} |
|
263 | 5 | */ |
|
264 | 5 | public function getVersionLog() |
|
265 | 5 | { |
|
266 | 5 | $result = []; |
|
267 | 5 | ||
268 | 5 | switch ($this->options['version_order']) { |
|
269 | 5 | case \Phinx\Config\Config::VERSION_ORDER_CREATION_TIME: |
|
270 | 5 | $orderBy = 'version ASC'; |
|
271 | 5 | break; |
|
272 | 5 | case \Phinx\Config\Config::VERSION_ORDER_EXECUTION_TIME: |
|
273 | 5 | $orderBy = 'start_time ASC, version ASC'; |
|
274 | 5 | break; |
|
275 | 5 | default: |
|
276 | throw new \RuntimeException('Invalid version_order configuration option'); |
||
277 | 5 | } |
|
278 | 5 | ||
279 | $rows = $this->fetchAll(sprintf('SELECT * FROM %s ORDER BY %s', $this->getSchemaTableName(), $orderBy)); |
||
280 | 3 | foreach ($rows as $version) { |
|
281 | 3 | $result[$version['version']] = $version; |
|
282 | 3 | } |
|
283 | 3 | ||
284 | 3 | return $result; |
|
285 | 3 | } |
|
286 | |||
287 | 3 | /** |
|
288 | * {@inheritdoc} |
||
289 | */ |
||
290 | 5 | public function migrated(MigrationInterface $migration, $direction, $startTime, $endTime) |
|
324 | 1 | ||
325 | 1 | /** |
|
326 | 1 | * @inheritDoc |
|
327 | 1 | */ |
|
328 | public function toggleBreakpoint(MigrationInterface $migration) |
||
329 | { |
||
330 | $this->query( |
||
331 | sprintf( |
||
332 | 'UPDATE %1$s SET %2$s = CASE %2$s WHEN %3$s THEN %4$s ELSE %3$s END, %7$s = %7$s WHERE %5$s = \'%6$s\';', |
||
333 | $this->getSchemaTableName(), |
||
334 | $this->quoteColumnName('breakpoint'), |
||
335 | $this->castToBool(true), |
||
336 | $this->castToBool(false), |
||
337 | $this->quoteColumnName('version'), |
||
338 | $migration->getVersion(), |
||
339 | $this->quoteColumnName('start_time') |
||
340 | ) |
||
341 | ); |
||
342 | |||
343 | return $this; |
||
344 | } |
||
345 | |||
346 | /** |
||
347 | * @inheritDoc |
||
348 | */ |
||
349 | 208 | public function resetAllBreakpoints() |
|
350 | { |
||
351 | return $this->execute( |
||
352 | 208 | sprintf( |
|
353 | 208 | 'UPDATE %1$s SET %2$s = %3$s, %4$s = %4$s WHERE %2$s <> %3$s;', |
|
354 | 208 | $this->getSchemaTableName(), |
|
355 | 208 | $this->quoteColumnName('breakpoint'), |
|
356 | 208 | $this->castToBool(false), |
|
357 | 208 | $this->quoteColumnName('start_time') |
|
358 | 208 | ) |
|
359 | 208 | ); |
|
360 | 208 | } |
|
361 | 208 | ||
362 | 208 | /** |
|
363 | 208 | * {@inheritdoc} |
|
364 | 208 | */ |
|
365 | 208 | public function createSchema($schemaName = 'public') |
|
369 | 208 | ||
370 | 208 | /** |
|
371 | 208 | * {@inheritdoc} |
|
372 | 208 | */ |
|
373 | 208 | public function dropSchema($name) |
|
377 | |||
378 | /** |
||
379 | 121 | * {@inheritdoc} |
|
380 | */ |
||
381 | 121 | public function getColumnTypes() |
|
408 | |||
409 | /** |
||
410 | * {@inheritdoc} |
||
411 | */ |
||
412 | public function castToBool($value) |
||
413 | { |
||
414 | return (bool)$value ? 1 : 0; |
||
415 | } |
||
416 | |||
417 | /** |
||
418 | * Get the defintion for a `DEFAULT` statement. |
||
419 | * |
||
420 | * @param mixed $default Default value |
||
421 | * @return string |
||
422 | */ |
||
423 | protected function getDefaultValueDefinition($default) |
||
433 | } |
||
434 |