DropForeignKey::getForeignKey() - Code Metrics - Inspection of "Internals re-implementation" - cakephp/phinx - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1339)

by José

created 2018-05-06 18:27 UTC

DropForeignKey::getForeignKey() A

↳ Parent: DropForeignKey

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * Phinx
 *
 * (The MIT license)
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated * documentation files (the "Software"), to
 * deal in the Software without restriction, including without limitation the
 * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
 * sell copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 */
namespace Phinx\Db\Action;

use InvalidArgumentException;
use Phinx\Db\Table\ForeignKey;
use Phinx\Db\Table\Table;

class DropForeignKey extends Action

{

    /**
     * The foreing key to remove
     *
     * @var ForeignKey
     */
    protected $foreignKey;

    /**
     * Constructor
     *
     * @param Table $table The table to remove the constraint from
     * @param ForeignKey $foreignKey The foreign key to remove
     */
    public function __construct(Table $table, ForeignKey $foreignKey)
    {
        parent::__construct($table);
        $this->foreignKey = $foreignKey;
    }

    /**
     * Creates a new DropForeignKey object after building the ForeignKey
     * definition out of the passed arguments.
     *
     * @param Table $table The table to dele the foreign key from
     * @param string|string[] $columns The columns participating in the foreign key
     * @param string|null $constraint The constraint name
     * @return DropForeignKey
     */
    public static function build(Table $table, $columns, $constraint = null)
    {
        if (is_string($columns)) {
            $columns = [$columns];
        }

        $foreignKey = new ForeignKey();
        $foreignKey->setColumns($columns);

        if ($constraint) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $foreignKey->setConstraint($constraint);
        }

        return new static($table, $foreignKey);
    }

    /**
     * Returns the  foreign key to remove
     *
     * @return ForeignKey
     */
    public function getForeignKey()
    {
        return $this->foreignKey;
    }
}


1		<?php
2		/**
3		* Phinx
4		*
5		* (The MIT license)
6		*
7		* Permission is hereby granted, free of charge, to any person obtaining a copy
8		* of this software and associated * documentation files (the "Software"), to
9		* deal in the Software without restriction, including without limitation the
10		* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
11		* sell copies of the Software, and to permit persons to whom the Software is
12		* furnished to do so, subject to the following conditions:
13		*
14		* The above copyright notice and this permission notice shall be included in
15		* all copies or substantial portions of the Software.
16		*
17		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
22		* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
23		* IN THE SOFTWARE.
24		*/
25		namespace Phinx\Db\Action;
26
27		use InvalidArgumentException;
28		use Phinx\Db\Table\ForeignKey;
29		use Phinx\Db\Table\Table;
30
31	View Code Duplication	class DropForeignKey extends Action
		0 ignored issues – show Duplication introduced 2018-05-06 12:16 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33
34		/**
35		* The foreing key to remove
36		*
37		* @var ForeignKey
38		*/
39		protected $foreignKey;
40
41		/**
42		* Constructor
43		*
44		* @param Table $table The table to remove the constraint from
45		* @param ForeignKey $foreignKey The foreign key to remove
46		*/
47		public function __construct(Table $table, ForeignKey $foreignKey)
48		{
49		parent::__construct($table);
50		$this->foreignKey = $foreignKey;
51		}
52
53		/**
54		* Creates a new DropForeignKey object after building the ForeignKey
55		* definition out of the passed arguments.
56		*
57		* @param Table $table The table to dele the foreign key from
58		* @param string\|string[] $columns The columns participating in the foreign key
59		* @param string\|null $constraint The constraint name
60		* @return DropForeignKey
61		*/
62		public static function build(Table $table, $columns, $constraint = null)
63		{
64		if (is_string($columns)) {
65		$columns = [$columns];
66		}
67
68		$foreignKey = new ForeignKey();
69		$foreignKey->setColumns($columns);
70
71		if ($constraint) {
		0 ignored issues – show Bug Best Practice introduced 2018-05-06 12:16 UTC by Report Bug Copy Issue Report The expression `$constraint` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
72		$foreignKey->setConstraint($constraint);
73		}
74
75		return new static($table, $foreignKey);
76		}
77
78		/**
79		* Returns the foreign key to remove
80		*
81		* @return ForeignKey
82		*/
83		public function getForeignKey()
84		{
85		return $this->foreignKey;
86		}
87		}
88

cakephp / phinx

Pull Request — master (#1339)

DropForeignKey::getForeignKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like