cakephp /
phinx
| Conditions | 10 |
| Paths | 74 |
| Total Lines | 62 |
| Code Lines | 35 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 30 |
| CRAP Score | 10.4632 |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 55 | protected function execute(InputInterface $input, OutputInterface $output) |
||
| 56 | { |
||
| 57 | $this->bootstrap($input, $output); |
||
| 58 | |||
| 59 | 35 | $seedSet = $input->getOption('seed'); |
|
| 60 | 35 | $environment = $input->getOption('environment'); |
|
| 61 | |||
| 62 | if ($environment === null) { |
||
| 63 | $environment = $this->getConfig()->getDefaultEnvironment(); |
||
| 64 | $output->writeln('<comment>warning</comment> no environment specified, defaulting to: ' . $environment); |
||
| 65 | } else { |
||
| 66 | $output->writeln('<info>using environment</info> ' . $environment); |
||
|
Bug
introduced
by
|
|||
| 67 | } |
||
| 68 | |||
| 69 | 4 | if (!$this->getConfig()->hasEnvironment($environment)) { |
|
| 70 | $output->writeln(sprintf('<error>The environment "%s" does not exist</error>', $environment)); |
||
| 71 | 4 | ||
| 72 | return self::CODE_ERROR; |
||
| 73 | 4 | } |
|
| 74 | 4 | ||
| 75 | $envOptions = $this->getConfig()->getEnvironment($environment); |
||
| 76 | 4 | if (isset($envOptions['adapter'])) { |
|
| 77 | 3 | $output->writeln('<info>using adapter</info> ' . $envOptions['adapter']); |
|
| 78 | 3 | } |
|
| 79 | 3 | ||
| 80 | 1 | if (isset($envOptions['wrapper'])) { |
|
| 81 | $output->writeln('<info>using wrapper</info> ' . $envOptions['wrapper']); |
||
| 82 | } |
||
| 83 | 4 | ||
| 84 | 4 | if (isset($envOptions['name'])) { |
|
| 85 | 3 | $output->writeln('<info>using database</info> ' . $envOptions['name']); |
|
| 86 | 3 | } else { |
|
| 87 | $output->writeln('<error>Could not determine database name! Please specify a database name in your config file.</error>'); |
||
| 88 | 4 | ||
| 89 | return self::CODE_ERROR; |
||
| 90 | } |
||
| 91 | |||
| 92 | 4 | if (isset($envOptions['table_prefix'])) { |
|
| 93 | 3 | $output->writeln('<info>using table prefix</info> ' . $envOptions['table_prefix']); |
|
| 94 | 3 | } |
|
| 95 | 1 | if (isset($envOptions['table_suffix'])) { |
|
| 96 | 1 | $output->writeln('<info>using table suffix</info> ' . $envOptions['table_suffix']); |
|
| 97 | } |
||
| 98 | |||
| 99 | 3 | $start = microtime(true); |
|
| 100 | |||
| 101 | if (empty($seedSet)) { |
||
| 102 | 3 | // run all the seed(ers) |
|
| 103 | $this->getManager()->seed($environment); |
||
| 104 | } else { |
||
| 105 | // run seed(ers) specified in a comma-separated list of classes |
||
| 106 | 3 | foreach ($seedSet as $seed) { |
|
| 107 | $this->getManager()->seed($environment, trim($seed)); |
||
| 108 | 3 | } |
|
| 109 | } |
||
| 110 | 2 | ||
| 111 | 2 | $end = microtime(true); |
|
| 112 | |||
| 113 | 1 | $output->writeln(''); |
|
| 114 | 1 | $output->writeln('<comment>All Done. Took ' . sprintf('%.4fs', $end - $start) . '</comment>'); |
|
| 115 | 1 | ||
| 116 | return self::CODE_SUCCESS; |
||
| 117 | } |
||
| 119 |
Loading history...
