Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Column often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Column, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
37 | class Column |
||
38 | { |
||
39 | /** |
||
40 | * @var string |
||
41 | */ |
||
42 | protected $name; |
||
43 | |||
44 | /** |
||
45 | * @var string|\Phinx\Util\Literal |
||
46 | */ |
||
47 | protected $type; |
||
48 | |||
49 | /** |
||
50 | * @var integer |
||
51 | */ |
||
52 | protected $limit = null; |
||
53 | |||
54 | /** |
||
55 | * @var boolean |
||
56 | */ |
||
57 | protected $null = false; |
||
58 | |||
59 | /** |
||
60 | * @var mixed |
||
61 | */ |
||
62 | protected $default = null; |
||
63 | |||
64 | /** |
||
65 | * @var boolean |
||
66 | */ |
||
67 | protected $identity = false; |
||
68 | |||
69 | /** |
||
70 | * @var integer |
||
71 | */ |
||
72 | protected $scale; |
||
73 | |||
74 | /** |
||
75 | * @var string |
||
76 | */ |
||
77 | protected $after; |
||
78 | |||
79 | /** |
||
80 | * @var string |
||
81 | */ |
||
82 | protected $update; |
||
83 | |||
84 | /** |
||
85 | * @var string |
||
86 | */ |
||
87 | protected $comment; |
||
88 | |||
89 | /** |
||
90 | * @var boolean |
||
91 | */ |
||
92 | protected $signed = true; |
||
93 | |||
94 | /** |
||
95 | * @var boolean |
||
96 | */ |
||
97 | protected $timezone = false; |
||
98 | |||
99 | /** |
||
100 | * @var array |
||
101 | */ |
||
102 | protected $properties = []; |
||
103 | |||
104 | /** |
||
105 | * @var string |
||
106 | */ |
||
107 | protected $collation; |
||
108 | |||
109 | /** |
||
110 | * @var string |
||
111 | */ |
||
112 | protected $encoding; |
||
113 | |||
114 | /** |
||
115 | * @var array |
||
116 | */ |
||
117 | protected $values; |
||
118 | |||
119 | /** |
||
120 | * Sets the column name. |
||
121 | * |
||
122 | * @param string $name |
||
123 | * @return \Phinx\Db\Table\Column |
||
124 | */ |
||
125 | public function setName($name) |
||
131 | |||
132 | 215 | /** |
|
133 | 215 | * Gets the column name. |
|
134 | * |
||
135 | * @return string|null |
||
136 | */ |
||
137 | public function getName() |
||
141 | 212 | ||
142 | /** |
||
143 | 212 | * Sets the column type. |
|
144 | * |
||
145 | * @param string|\Phinx\Util\Literal $type Column type |
||
146 | * @return \Phinx\Db\Table\Column |
||
147 | */ |
||
148 | public function setType($type) |
||
154 | 214 | ||
155 | 214 | /** |
|
156 | * Gets the column type. |
||
157 | * |
||
158 | * @return string|\Phinx\Util\Literal |
||
159 | */ |
||
160 | public function getType() |
||
164 | |||
165 | 212 | /** |
|
166 | * Sets the column limit. |
||
167 | * |
||
168 | * @param int $limit |
||
169 | * @return \Phinx\Db\Table\Column |
||
170 | */ |
||
171 | public function setLimit($limit) |
||
177 | 192 | ||
178 | /** |
||
179 | * Gets the column limit. |
||
180 | * |
||
181 | * @return int |
||
182 | */ |
||
183 | public function getLimit() |
||
187 | 192 | ||
188 | /** |
||
189 | * Sets whether the column allows nulls. |
||
190 | * |
||
191 | * @param bool $null |
||
192 | * @return \Phinx\Db\Table\Column |
||
193 | */ |
||
194 | public function setNull($null) |
||
200 | |||
201 | /** |
||
202 | * Gets whether the column allows nulls. |
||
203 | * |
||
204 | * @return bool |
||
205 | */ |
||
206 | public function getNull() |
||
210 | |||
211 | /** |
||
212 | * Does the column allow nulls? |
||
213 | * |
||
214 | * @return bool |
||
215 | */ |
||
216 | public function isNull() |
||
220 | |||
221 | /** |
||
222 | * Sets the default column value. |
||
223 | * |
||
224 | * @param mixed $default |
||
225 | * @return \Phinx\Db\Table\Column |
||
226 | */ |
||
227 | public function setDefault($default) |
||
233 | |||
234 | /** |
||
235 | * Gets the default column value. |
||
236 | * |
||
237 | * @return mixed |
||
238 | */ |
||
239 | 215 | public function getDefault() |
|
243 | |||
244 | /** |
||
245 | * Sets whether or not the column is an identity column. |
||
246 | * |
||
247 | * @param bool $identity |
||
248 | * @return \Phinx\Db\Table\Column |
||
249 | */ |
||
250 | 158 | public function setIdentity($identity) |
|
256 | |||
257 | /** |
||
258 | * Gets whether or not the column is an identity column. |
||
259 | * |
||
260 | * @return bool |
||
261 | 199 | */ |
|
262 | public function getIdentity() |
||
266 | |||
267 | /** |
||
268 | * Is the column an identity column? |
||
269 | * |
||
270 | * @return bool |
||
271 | 198 | */ |
|
272 | public function isIdentity() |
||
276 | |||
277 | /** |
||
278 | * Sets the name of the column to add this column after. |
||
279 | * |
||
280 | * @param string $after After |
||
281 | * @return \Phinx\Db\Table\Column |
||
282 | 1 | */ |
|
283 | public function setAfter($after) |
||
289 | |||
290 | /** |
||
291 | * Returns the name of the column to add this column after. |
||
292 | * |
||
293 | 20 | * @return string |
|
294 | */ |
||
295 | 20 | public function getAfter() |
|
299 | |||
300 | /** |
||
301 | * Sets the 'ON UPDATE' mysql column function. |
||
302 | * |
||
303 | * @param string $update On Update function |
||
304 | 15 | * @return \Phinx\Db\Table\Column |
|
305 | */ |
||
306 | 15 | public function setUpdate($update) |
|
312 | |||
313 | /** |
||
314 | * Returns the value of the ON UPDATE column function. |
||
315 | 145 | * |
|
316 | * @return string |
||
317 | 145 | */ |
|
318 | public function getUpdate() |
||
322 | |||
323 | /** |
||
324 | * Sets the number precision for decimal or float column. |
||
325 | * |
||
326 | 9 | * For example `DECIMAL(5,2)`, 5 is the precision and 2 is the scale, |
|
327 | * and the column could store value from -999.99 to 999.99. |
||
328 | 9 | * |
|
329 | 9 | * @param int $precision Number precision |
|
330 | * @return \Phinx\Db\Table\Column |
||
331 | */ |
||
332 | public function setPrecision($precision) |
||
338 | |||
339 | 131 | /** |
|
340 | * Gets the number precision for decimal or float column. |
||
341 | * |
||
342 | * For example `DECIMAL(5,2)`, 5 is the precision and 2 is the scale, |
||
343 | * and the column could store value from -999.99 to 999.99. |
||
344 | * |
||
345 | * @return int |
||
346 | */ |
||
347 | public function getPrecision() |
||
351 | 9 | ||
352 | /** |
||
353 | * Gets the column identity seed. |
||
354 | * |
||
355 | * @return int |
||
356 | */ |
||
357 | public function getSeed() |
||
361 | 2 | ||
362 | /** |
||
363 | * Gets the column identity increment. |
||
364 | * |
||
365 | * @return int |
||
366 | */ |
||
367 | public function getIncrement() |
||
371 | |||
372 | 9 | /** |
|
373 | 9 | * Sets the column identity seed. |
|
374 | * |
||
375 | * @param int $seed |
||
376 | * @return \Phinx\Db\Table\Column |
||
377 | */ |
||
378 | public function setSeed($seed) |
||
383 | 198 | ||
384 | /** |
||
385 | * Sets the column identity increment. |
||
386 | * |
||
387 | * @param int $increment |
||
388 | * @return \Phinx\Db\Table\Column |
||
389 | */ |
||
390 | public function setIncrement($increment) |
||
396 | |||
397 | /** |
||
398 | * Sets the number scale for decimal or float column. |
||
399 | * |
||
400 | * For example `DECIMAL(5,2)`, 5 is the precision and 2 is the scale, |
||
401 | * and the column could store value from -999.99 to 999.99. |
||
402 | * |
||
403 | 89 | * @param int $scale Number scale |
|
404 | * @return \Phinx\Db\Table\Column |
||
405 | 89 | */ |
|
406 | public function setScale($scale) |
||
412 | |||
413 | 89 | /** |
|
414 | * Gets the number scale for decimal or float column. |
||
415 | 89 | * |
|
416 | * For example `DECIMAL(5,2)`, 5 is the precision and 2 is the scale, |
||
417 | * and the column could store value from -999.99 to 999.99. |
||
418 | * |
||
419 | * @return int |
||
420 | */ |
||
421 | public function getScale() |
||
425 | 1 | ||
426 | /** |
||
427 | 1 | * Sets the number precision and scale for decimal or float column. |
|
428 | 1 | * |
|
429 | * For example `DECIMAL(5,2)`, 5 is the precision and 2 is the scale, |
||
430 | * and the column could store value from -999.99 to 999.99. |
||
431 | * |
||
432 | * @param int $precision Number precision |
||
433 | * @param int $scale Number scale |
||
434 | * @return \Phinx\Db\Table\Column |
||
435 | */ |
||
436 | 68 | public function setPrecisionAndScale($precision, $scale) |
|
443 | |||
444 | /** |
||
445 | * Sets the column comment. |
||
446 | 68 | * |
|
447 | * @param string $comment |
||
448 | 68 | * @return \Phinx\Db\Table\Column |
|
449 | */ |
||
450 | public function setComment($comment) |
||
456 | |||
457 | /** |
||
458 | * Gets the column comment. |
||
459 | * |
||
460 | * @return string |
||
461 | */ |
||
462 | public function getComment() |
||
466 | |||
467 | /** |
||
468 | * Sets whether field should be signed. |
||
469 | * |
||
470 | * @param bool $signed |
||
471 | * @return \Phinx\Db\Table\Column |
||
472 | */ |
||
473 | public function setSigned($signed) |
||
479 | |||
480 | /** |
||
481 | 9 | * Gets whether field should be signed. |
|
482 | * |
||
483 | 9 | * @return bool |
|
484 | 2 | */ |
|
485 | 2 | public function getSigned() |
|
489 | |||
490 | /** |
||
491 | * Should the column be signed? |
||
492 | * |
||
493 | * @return bool |
||
494 | */ |
||
495 | 131 | public function isSigned() |
|
499 | |||
500 | /** |
||
501 | * Sets whether the field should have a timezone identifier. |
||
502 | * Used for date/time columns only! |
||
503 | * |
||
504 | * @param bool $timezone |
||
505 | * @return \Phinx\Db\Table\Column |
||
506 | */ |
||
507 | public function setTimezone($timezone) |
||
513 | 1 | ||
514 | 1 | /** |
|
515 | 1 | * Gets whether field has a timezone identifier. |
|
516 | * |
||
517 | * @return bool |
||
518 | */ |
||
519 | 1 | public function getTimezone() |
|
523 | |||
524 | /** |
||
525 | * Should the column have a timezone? |
||
526 | * |
||
527 | * @return bool |
||
528 | */ |
||
529 | 89 | public function isTimezone() |
|
533 | |||
534 | /** |
||
535 | * Sets field properties. |
||
536 | * |
||
537 | * @param array $properties |
||
538 | * |
||
539 | * @return \Phinx\Db\Table\Column |
||
540 | */ |
||
541 | public function setProperties($properties) |
||
547 | |||
548 | /** |
||
549 | * Gets field properties |
||
550 | * |
||
551 | * @return array |
||
552 | */ |
||
553 | public function getProperties() |
||
557 | |||
558 | /** |
||
559 | * Sets field values. |
||
560 | * |
||
561 | * @param array|string $values |
||
562 | * |
||
563 | 89 | * @return \Phinx\Db\Table\Column |
|
564 | */ |
||
565 | 89 | public function setValues($values) |
|
574 | |||
575 | /** |
||
576 | 209 | * Gets field values |
|
577 | 209 | * |
|
578 | 209 | * @return array |
|
579 | 209 | */ |
|
580 | 209 | public function getValues() |
|
584 | 209 | ||
585 | 209 | /** |
|
586 | 209 | * Sets the column collation. |
|
587 | 209 | * |
|
588 | 209 | * @param string $collation |
|
589 | 209 | * |
|
590 | 209 | * @throws \UnexpectedValueException If collation not allowed for type |
|
591 | 209 | * @return $this |
|
592 | */ |
||
593 | View Code Duplication | public function setCollation($collation) |
|
594 | { |
||
595 | $allowedTypes = [ |
||
596 | AdapterInterface::PHINX_TYPE_CHAR, |
||
597 | AdapterInterface::PHINX_TYPE_STRING, |
||
598 | AdapterInterface::PHINX_TYPE_TEXT, |
||
599 | 209 | ]; |
|
600 | if (!in_array($this->getType(), $allowedTypes)) { |
||
601 | throw new \UnexpectedValueException('Collation may be set only for types: ' . implode(', ', $allowedTypes)); |
||
602 | 209 | } |
|
603 | 209 | ||
604 | $this->collation = $collation; |
||
605 | |||
606 | return $this; |
||
607 | } |
||
608 | |||
609 | /** |
||
610 | * Gets the column collation. |
||
611 | * |
||
612 | 209 | * @return string |
|
613 | */ |
||
614 | 209 | public function getCollation() |
|
615 | 209 | { |
|
616 | return $this->collation; |
||
617 | 209 | } |
|
618 | 208 | ||
619 | /** |
||
620 | * Sets the column character set. |
||
621 | * |
||
622 | * @param string $encoding |
||
623 | 208 | * |
|
624 | 1 | * @throws \UnexpectedValueException If character set not allowed for type |
|
625 | * @return $this |
||
626 | */ |
||
627 | 207 | View Code Duplication | public function setEncoding($encoding) |
628 | 207 | { |
|
629 | 208 | $allowedTypes = [ |
|
630 | 208 | AdapterInterface::PHINX_TYPE_CHAR, |
|
631 | AdapterInterface::PHINX_TYPE_STRING, |
||
632 | AdapterInterface::PHINX_TYPE_TEXT, |
||
633 | ]; |
||
634 | if (!in_array($this->getType(), $allowedTypes)) { |
||
635 | throw new \UnexpectedValueException('Character set may be set only for types: ' . implode(', ', $allowedTypes)); |
||
636 | } |
||
637 | |||
638 | $this->encoding = $encoding; |
||
639 | |||
640 | return $this; |
||
641 | } |
||
642 | |||
643 | /** |
||
644 | * Gets the column character set. |
||
645 | * |
||
646 | * @return string |
||
647 | */ |
||
648 | public function getEncoding() |
||
649 | { |
||
650 | return $this->encoding; |
||
651 | } |
||
652 | |||
653 | /** |
||
654 | * Gets all allowed options. Each option must have a corresponding `setFoo` method. |
||
655 | * |
||
656 | * @return array |
||
657 | */ |
||
658 | protected function getValidOptions() |
||
680 | |||
681 | /** |
||
682 | * Gets all aliased options. Each alias must reference a valid option. |
||
683 | * |
||
684 | * @return array |
||
685 | */ |
||
686 | protected function getAliasedOptions() |
||
693 | |||
694 | /** |
||
695 | * Utility method that maps an array of column options to this objects methods. |
||
696 | * |
||
697 | * @param array $options Options |
||
698 | * @return \Phinx\Db\Table\Column |
||
699 | */ |
||
700 | public function setOptions($options) |
||
721 | } |
||
722 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: