Phinx\Db\Adapter\RedshiftAdapter

Complexity

Total Complexity

29

Size/Duplication

Total Lines	145
Duplicated Lines	31.03 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
F	createTable()	32	110	25
A	getSchemaName()	13	13	2
A	getGlobalSchemaName()	0	6	2

<?php

namespace Phinx\Db\Adapter;

use Phinx\Db\Table\Table;
use Phinx\Db\Table\Column;

class RedshiftAdapter extends PostgresAdapter
{
	
	public function createTable(Table $table, array $columns = [], array $indexes = [])
	{
		$options = $table->getOptions();
		$parts = $this->getSchemaName( $table->getName() );
		
		// Add the default primary key
		if ( !isset( $options['id'] ) || ( isset( $options['id'] ) && $options['id'] === true ) ) {
			$column = new Column();
			$column->setName( 'id' )
			       ->setType( 'integer' )
			       ->setIdentity( true );
			
			array_unshift( $columns, $column );
			$options['primary_key'] = 'id';
		} elseif ( isset( $options['id'] ) &&
			is_string( $options['id'] ) ) {// Handle id => "field_name" to support AUTO_INCREMENT
			$column = new Column();
			$column->setName( $options['id'] )
			       ->setType( 'integer' )
			       ->setIdentity( true );
			
			array_unshift( $columns, $column );
			$options['primary_key'] = $options['id'];
		}
		
		// TODO - process table options like collation etc
		$sql = 'CREATE TABLE ';
		$sql .= $this->quoteTableName( $table->getName() ) . ' (';
		
		$this->columnsWithComments = [];
		foreach ( $columns as $column ) {

This code seems to be duplicated across your project.

			$sql .= $this->quoteColumnName( $column->getName() ) . ' ' . $this->getColumnSqlDefinition( $column ) .
				', ';
			
			// set column comments, if needed
			if ( $column->getComment() ) {
				$this->columnsWithComments[] = $column;
			}
		}
		
		// set the primary key(s)
		if ( isset( $options['primary_key'] ) ) {

This code seems to be duplicated across your project.

			$sql = rtrim( $sql );
			$sql .= sprintf( ' CONSTRAINT %s PRIMARY KEY (', $this->quoteColumnName( $parts['table'] . '_pkey' ) );
			if ( is_string( $options['primary_key'] ) ) { // handle primary_key => 'id'
				$sql .= $this->quoteColumnName( $options['primary_key'] );
			} elseif ( is_array( $options['primary_key'] ) ) { // handle primary_key => array('tag_id', 'resource_id')

43% of this comment could be valid code. Did you maybe forget this after debugging?

				$sql .= implode( ',', array_map( [ $this, 'quoteColumnName' ], $options['primary_key'] ) );
			}
			$sql .= ')';
		} else {
			$sql = rtrim( $sql, ', ' ); // no primary keys
		}
		$sql .= ') ';
		
		// process redshift sortkeys & distkey
		$sortKeys = isset( $options['sortkeys'] ) ? $options['sortkeys'] : null;
		
		$distKey = isset( $options['distkey'] ) ? $options['distkey'] : null;
		
		$distStyle = isset( $options['diststyle'] ) ? $options['diststyle'] : null;
		
		$interleavedSortKey = isset( $options['interleaved'] ) ? (bool) $options['interleaved'] : false;
		
		if ( !empty( $distKey ) ) {
			$sql .= ' distkey(' . addslashes( $distKey ) . ')';
		}
		
		if ( !empty( $sortKeys ) ) {
			
			$sortKeyStr = is_array( $sortKeys ) ? addslashes( implode( ',', $sortKeys ) ) : addslashes( $sortKeys );
			
			if ( !$interleavedSortKey ) {
				$sql .= sprintf( ' compound sortkey (%s) ', $sortKeyStr );
			} else {
				$sql .= sprintf( ' interleaved sortkey (%s) ', $sortKeyStr );
			}
		}
		
		if ( !empty( $distStyle ) ) {
			$sql .= sprintf( ' diststyle %s', $distStyle );
		}
		
		$sql .= ';';
		
		// process column comments
		if ( !empty( $this->columnsWithComments ) ) {

This code seems to be duplicated across your project.

			foreach ( $this->columnsWithComments as $column ) {
				$sql .= $this->getColumnCommentSqlDefinition( $column, $table->getName() );
			}
		}
		
		// set the indexes
		if ( !empty( $indexes ) ) {
			foreach ( $indexes as $index ) {
				$sql .= $this->getIndexSqlDefinition( $index, $table->getName() );
			}
		}
		
		// execute the sql
		$this->execute( $sql );
		
		// process table comments
		if ( isset( $options['comment'] ) ) {

This code seems to be duplicated across your project.

			$sql = sprintf( 'COMMENT ON TABLE %s IS %s', $this->quoteTableName( $table->getName() ),
				$this->getConnection()
				     ->quote( $options['comment'] ) );
			$this->execute( $sql );
		}
	}
	
	/**
	 * @param string $tableName Table name
	 *
	 * @return array
	 */
	private function getSchemaName($tableName)

Consider using a different method name as you override a private method of the parent class.

This method seems to be duplicated in your project.

	{
		$schema = $this->getGlobalSchemaName();
		$table = $tableName;
		if ( false !== strpos( $tableName, '.' ) ) {
			list( $schema, $table ) = explode( '.', $tableName );
		}
		
		return [
			'schema' => $schema,
			'table'  => $table,
		];
	}
	
	/**
	 * Gets the schema name.
	 *
	 * @return string
	 */
	private function getGlobalSchemaName()

Consider using a different method name as you override a private method of the parent class.

	{
		$options = $this->getOptions();
		
		return empty( $options['schema'] ) ? 'public' : $options['schema'];
	}
}