AbstractCommand - Code Metrics - Inspection of "Fix failing SQLServer tests" - cakephp/phinx - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1390)

unknown

created 2018-06-25 09:29 UTC

AbstractCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	319
Duplicated Lines	10.03 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

53.72%

Importance

Changes

Metric	Value
wmc	36
lcom	1
cbo	8
dl	32
loc	319
ccs	65
cts	121
cp	0.5372
rs	9.52
c	0
b	0
f	0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	5	1
A	bootstrap()	0	29	5
A	setConfig()	0	6	1
A	getConfig()	0	4	1
A	setAdapter()	0	6	1
A	getAdapter()	0	4	1
A	setManager()	0	6	1
A	getManager()	0	4	1
B	locateConfigFile()	0	33	6
B	loadConfig()	0	42	8
A	loadManager()	0	11	2
A	verifyMigrationDirectory()	16	16	3
A	verifySeedDirectory()	16	16	3
A	getMigrationTemplateFilename()	0	4	1
A	getSeedTemplateFilename()	0	4	1

How to fix Duplicated Code

<?php
/**
 * Phinx
 *
 * (The MIT license)
 * Copyright (c) 2015 Rob Morgan
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated * documentation files (the "Software"), to
 * deal in the Software without restriction, including without limitation the
 * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
 * sell copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * @package    Phinx
 * @subpackage Phinx\Console
 */
namespace Phinx\Console\Command;

use Phinx\Config\Config;
use Phinx\Config\ConfigInterface;
use Phinx\Db\Adapter\AdapterInterface;
use Phinx\Migration\Manager;
use Phinx\Util\Util;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Abstract command, contains bootstrapping info
 *
 * @author Rob Morgan <[email protected]>
 */
abstract class AbstractCommand extends Command
{
    /**
     * The location of the default migration template.
     */
    const DEFAULT_MIGRATION_TEMPLATE = '/../../Migration/Migration.template.php.dist';

    /**
     * The location of the default seed template.
     */
    const DEFAULT_SEED_TEMPLATE = '/../../Seed/Seed.template.php.dist';

    /**
     * @var \Phinx\Config\ConfigInterface
     */
    protected $config;

    /**
     * @var \Phinx\Db\Adapter\AdapterInterface
     */
    protected $adapter;

    /**
     * @var \Phinx\Migration\Manager
     */
    protected $manager;

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this->addOption('--configuration', '-c', InputOption::VALUE_REQUIRED, 'The configuration file to load');
        $this->addOption('--parser', '-p', InputOption::VALUE_REQUIRED, 'Parser used to read the config file. Defaults to YAML');
    }

    /**
     * Bootstrap Phinx.
     *
     * @param \Symfony\Component\Console\Input\InputInterface $input
     * @param \Symfony\Component\Console\Output\OutputInterface $output
     * @return void
     */
    public function bootstrap(InputInterface $input, OutputInterface $output)
    {
        if (!$this->getConfig()) {
            $this->loadConfig($input, $output);
        }

        $this->loadManager($input, $output);

        // report the paths
        $paths = $this->getConfig()->getMigrationPaths();

        $output->writeln('<info>using migration paths</info> ');

        foreach (Util::globAll($paths) as $path) {
            $output->writeln('<info> - ' . realpath($path) . '</info>');
        }

        try {
            $paths = $this->getConfig()->getSeedPaths();

            $output->writeln('<info>using seed paths</info> ');

            foreach (Util::globAll($paths) as $path) {
                $output->writeln('<info> - ' . realpath($path) . '</info>');
            }
        } catch (\UnexpectedValueException $e) {
            // do nothing as seeds are optional
        }
    }

    /**
     * Sets the config.
     *
     * @param  \Phinx\Config\ConfigInterface $config
     * @return \Phinx\Console\Command\AbstractCommand
     */
    public function setConfig(ConfigInterface $config)
    {
        $this->config = $config;

        return $this;
    }

    /**
     * Gets the config.
     *
     * @return \Phinx\Config\ConfigInterface
     */
    public function getConfig()
    {
        return $this->config;
    }

    /**
     * Sets the database adapter.
     *
     * @param \Phinx\Db\Adapter\AdapterInterface $adapter
     * @return \Phinx\Console\Command\AbstractCommand
     */
    public function setAdapter(AdapterInterface $adapter)
    {
        $this->adapter = $adapter;

        return $this;
    }

    /**
     * Gets the database adapter.
     *
     * @return \Phinx\Db\Adapter\AdapterInterface
     */
    public function getAdapter()
    {
        return $this->adapter;
    }

    /**
     * Sets the migration manager.
     *
     * @param \Phinx\Migration\Manager $manager
     * @return \Phinx\Console\Command\AbstractCommand
     */
    public function setManager(Manager $manager)
    {
        $this->manager = $manager;

        return $this;
    }

    /**
     * Gets the migration manager.
     *
     * @return \Phinx\Migration\Manager|null
     */
    public function getManager()
    {
        return $this->manager;
    }

    /**
     * Returns config file path
     *
     * @param \Symfony\Component\Console\Input\InputInterface $input
     * @return string
     */
    protected function locateConfigFile(InputInterface $input)
    {
        $configFile = $input->getOption('configuration');

        $useDefault = false;

        if ($configFile === null || $configFile === false) {
            $useDefault = true;
        }

        $cwd = getcwd();

        // locate the phinx config file (default: phinx.yml)
        // TODO - In future walk the tree in reverse (max 10 levels)
        $locator = new FileLocator([
            $cwd . DIRECTORY_SEPARATOR
        ]);

        if (!$useDefault) {
            // Locate() throws an exception if the file does not exist
            return $locator->locate($configFile, $cwd, $first = true);
        }

        $possibleConfigFiles = ['phinx.php', 'phinx.json', 'phinx.yml'];
        foreach ($possibleConfigFiles as $configFile) {
            try {
                return $locator->locate($configFile, $cwd, $first = true);
            } catch (\InvalidArgumentException $exception) {
                $lastException = $exception;
            }
        }
        throw $lastException;
    }

    /**
     * Parse the config file and load it into the config object
     *
     * @param \Symfony\Component\Console\Input\InputInterface $input
     * @param \Symfony\Component\Console\Output\OutputInterface $output
     * @throws \InvalidArgumentException
     * @return void
     */
    protected function loadConfig(InputInterface $input, OutputInterface $output)
    {
        $configFilePath = $this->locateConfigFile($input);
        $output->writeln('<info>using config file</info> .' . str_replace(getcwd(), '', realpath($configFilePath)));

        $parser = $input->getOption('parser');

        // If no parser is specified try to determine the correct one from the file extension.  Defaults to YAML
        if ($parser === null) {
            $extension = pathinfo($configFilePath, PATHINFO_EXTENSION);

            switch (strtolower($extension)) {
                case 'json':
                    $parser = 'json';
                    break;
                case 'php':
                    $parser = 'php';
                    break;
                case 'yml':
                default:
                    $parser = 'yaml';
            }
        }

        switch (strtolower($parser)) {
            case 'json':
                $config = Config::fromJson($configFilePath);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                break;
            case 'php':
                $config = Config::fromPhp($configFilePath);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                break;
            case 'yaml':
                $config = Config::fromYaml($configFilePath);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                break;
            default:
                throw new \InvalidArgumentException(sprintf('\'%s\' is not a valid parser.', $parser));
        }

        $output->writeln('<info>using config parser</info> ' . $parser);

        $this->setConfig($config);
    }

    /**
     * Load the migrations manager and inject the config
     *
     * @param \Symfony\Component\Console\Input\InputInterface $input
     * @param \Symfony\Component\Console\Output\OutputInterface $output
     */
    protected function loadManager(InputInterface $input, OutputInterface $output)
    {
        if ($this->getManager() === null) {
            $manager = new Manager($this->getConfig(), $input, $output);
            $this->setManager($manager);
        } else {
            $manager = $this->getManager();
            $manager->setInput($input);
            $manager->setOutput($output);
        }
    }

    /**
     * Verify that the migration directory exists and is writable.
     *
     * @param string $path
     * @throws \InvalidArgumentException
     * @return void
     */
    protected function verifyMigrationDirectory($path)

    {
        if (!is_dir($path)) {
            throw new \InvalidArgumentException(sprintf(
                'Migration directory "%s" does not exist',
                $path
            ));
        }

        if (!is_writable($path)) {
            throw new \InvalidArgumentException(sprintf(
                'Migration directory "%s" is not writable',
                $path
            ));
        }
    }

    /**
     * Verify that the seed directory exists and is writable.
     *
     * @param string $path
     * @throws \InvalidArgumentException
     * @return void
     */
    protected function verifySeedDirectory($path)

    {
        if (!is_dir($path)) {
            throw new \InvalidArgumentException(sprintf(
                'Seed directory "%s" does not exist',
                $path
            ));
        }

        if (!is_writable($path)) {
            throw new \InvalidArgumentException(sprintf(
                'Seed directory "%s" is not writable',
                $path
            ));
        }
    }

    /**
     * Returns the migration template filename.
     *
     * @return string
     */
    protected function getMigrationTemplateFilename()
    {
        return __DIR__ . self::DEFAULT_MIGRATION_TEMPLATE;
    }

    /**
     * Returns the seed template filename.
     *
     * @return string
     */
    protected function getSeedTemplateFilename()
    {
        return __DIR__ . self::DEFAULT_SEED_TEMPLATE;
    }
}


1			<?php
2			/**
3			* Phinx
4			*
5			* (The MIT license)
6			* Copyright (c) 2015 Rob Morgan
7			*
8			* Permission is hereby granted, free of charge, to any person obtaining a copy
9			* of this software and associated * documentation files (the "Software"), to
10			* deal in the Software without restriction, including without limitation the
11			* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
12			* sell copies of the Software, and to permit persons to whom the Software is
13			* furnished to do so, subject to the following conditions:
14			*
15			* The above copyright notice and this permission notice shall be included in
16			* all copies or substantial portions of the Software.
17			*
18			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
21			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
22			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
23			* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
24			* IN THE SOFTWARE.
25			*
26			* @package Phinx
27			* @subpackage Phinx\Console
28			*/
29			namespace Phinx\Console\Command;
30
31			use Phinx\Config\Config;
32			use Phinx\Config\ConfigInterface;
33			use Phinx\Db\Adapter\AdapterInterface;
34			use Phinx\Migration\Manager;
35			use Phinx\Util\Util;
36			use Symfony\Component\Config\FileLocator;
37			use Symfony\Component\Console\Command\Command;
38			use Symfony\Component\Console\Input\InputInterface;
39			use Symfony\Component\Console\Input\InputOption;
40			use Symfony\Component\Console\Output\OutputInterface;
41
42			/**
43			* Abstract command, contains bootstrapping info
44			*
45			* @author Rob Morgan <[email protected]>
46			*/
47			abstract class AbstractCommand extends Command
48			{
49			/**
50			* The location of the default migration template.
51			*/
52			const DEFAULT_MIGRATION_TEMPLATE = '/../../Migration/Migration.template.php.dist';
53
54			/**
55			* The location of the default seed template.
56			*/
57			const DEFAULT_SEED_TEMPLATE = '/../../Seed/Seed.template.php.dist';
58
59			/**
60			* @var \Phinx\Config\ConfigInterface
61			*/
62			protected $config;
63
64			/**
65			* @var \Phinx\Db\Adapter\AdapterInterface
66			*/
67			protected $adapter;
68
69			/**
70			* @var \Phinx\Migration\Manager
71			*/
72			protected $manager;
73
74			/**
75			* {@inheritdoc}
76			*/
77	54		protected function configure()
78			{
79	54		$this->addOption('--configuration', '-c', InputOption::VALUE_REQUIRED, 'The configuration file to load');
80	54		$this->addOption('--parser', '-p', InputOption::VALUE_REQUIRED, 'Parser used to read the config file. Defaults to YAML');
81	54		}
82
83			/**
84			* Bootstrap Phinx.
85			*
86			* @param \Symfony\Component\Console\Input\InputInterface $input
87			* @param \Symfony\Component\Console\Output\OutputInterface $output
88			* @return void
89			*/
90	32		public function bootstrap(InputInterface $input, OutputInterface $output)
91			{
92	32		if (!$this->getConfig()) {
93			$this->loadConfig($input, $output);
94			}
95
96	32		$this->loadManager($input, $output);
97
98			// report the paths
99	32		$paths = $this->getConfig()->getMigrationPaths();
100
101	32		$output->writeln('<info>using migration paths</info> ');
102
103	32		foreach (Util::globAll($paths) as $path) {
104	32		$output->writeln('<info> - ' . realpath($path) . '</info>');
105	32		}
106
107			try {
108	32		$paths = $this->getConfig()->getSeedPaths();
109
110	6		$output->writeln('<info>using seed paths</info> ');
111
112	6		foreach (Util::globAll($paths) as $path) {
113	6		$output->writeln('<info> - ' . realpath($path) . '</info>');
114	6		}
115	32		} catch (\UnexpectedValueException $e) {
116			// do nothing as seeds are optional
117			}
118	32		}
119
120			/**
121			* Sets the config.
122			*
123			* @param \Phinx\Config\ConfigInterface $config
124			* @return \Phinx\Console\Command\AbstractCommand
125			*/
126	32		public function setConfig(ConfigInterface $config)
127			{
128	32		$this->config = $config;
129	32
130			return $this;
131			}
132
133			/**
134			* Gets the config.
135			*
136			* @return \Phinx\Config\ConfigInterface
137	32		*/
138			public function getConfig()
139	32		{
140			return $this->config;
141			}
142
143			/**
144			* Sets the database adapter.
145			*
146			* @param \Phinx\Db\Adapter\AdapterInterface $adapter
147			* @return \Phinx\Console\Command\AbstractCommand
148			*/
149			public function setAdapter(AdapterInterface $adapter)
150			{
151			$this->adapter = $adapter;
152
153			return $this;
154			}
155
156			/**
157			* Gets the database adapter.
158			*
159			* @return \Phinx\Db\Adapter\AdapterInterface
160			*/
161			public function getAdapter()
162			{
163			return $this->adapter;
164			}
165
166			/**
167			* Sets the migration manager.
168			*
169			* @param \Phinx\Migration\Manager $manager
170	32		* @return \Phinx\Console\Command\AbstractCommand
171			*/
172	32		public function setManager(Manager $manager)
173	32		{
174			$this->manager = $manager;
175
176			return $this;
177			}
178
179			/**
180			* Gets the migration manager.
181	32		*
182			* @return \Phinx\Migration\Manager\|null
183	32		*/
184			public function getManager()
185			{
186			return $this->manager;
187			}
188
189			/**
190			* Returns config file path
191			*
192	10		* @param \Symfony\Component\Console\Input\InputInterface $input
193			* @return string
194	10		*/
195			protected function locateConfigFile(InputInterface $input)
196	10		{
197			$configFile = $input->getOption('configuration');
198	10
199	4		$useDefault = false;
200	4
201			if ($configFile === null \|\| $configFile === false) {
202	10		$useDefault = true;
203			}
204
205			$cwd = getcwd();
206	10
207			// locate the phinx config file (default: phinx.yml)
208	10		// TODO - In future walk the tree in reverse (max 10 levels)
209			$locator = new FileLocator([
210	10		$cwd . DIRECTORY_SEPARATOR
211			]);
212	6
213			if (!$useDefault) {
214			// Locate() throws an exception if the file does not exist
215	4		return $locator->locate($configFile, $cwd, $first = true);
216	4		}
217
218	4		$possibleConfigFiles = ['phinx.php', 'phinx.json', 'phinx.yml'];
219	3		foreach ($possibleConfigFiles as $configFile) {
220	3		try {
221			return $locator->locate($configFile, $cwd, $first = true);
222	3		} catch (\InvalidArgumentException $exception) {
223	1		$lastException = $exception;
224			}
225			}
226			throw $lastException;
227			}
228
229			/**
230			* Parse the config file and load it into the config object
231			*
232			* @param \Symfony\Component\Console\Input\InputInterface $input
233			* @param \Symfony\Component\Console\Output\OutputInterface $output
234			* @throws \InvalidArgumentException
235			* @return void
236			*/
237			protected function loadConfig(InputInterface $input, OutputInterface $output)
238			{
239			$configFilePath = $this->locateConfigFile($input);
240			$output->writeln('<info>using config file</info> .' . str_replace(getcwd(), '', realpath($configFilePath)));
241
242			$parser = $input->getOption('parser');
243
244			// If no parser is specified try to determine the correct one from the file extension. Defaults to YAML
245			if ($parser === null) {
246			$extension = pathinfo($configFilePath, PATHINFO_EXTENSION);
247
248			switch (strtolower($extension)) {
249			case 'json':
250			$parser = 'json';
251			break;
252			case 'php':
253			$parser = 'php';
254			break;
255			case 'yml':
256			default:
257			$parser = 'yaml';
258			}
259			}
260
261			switch (strtolower($parser)) {
262			case 'json':
263			$config = Config::fromJson($configFilePath);
			0 ignored issues – show Bug introduced 2017-09-15 20:49 UTC by Report Bug Copy Issue Report It seems like `$configFilePath` defined by `$this->locateConfigFile($input)` on line `239` can also be of type `array`; however, `Phinx\Config\Config::fromJson()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
264			break;
265			case 'php':
266			$config = Config::fromPhp($configFilePath);
			0 ignored issues – show Bug introduced 2017-09-15 20:49 UTC by Report Bug Copy Issue Report It seems like `$configFilePath` defined by `$this->locateConfigFile($input)` on line `239` can also be of type `array`; however, `Phinx\Config\Config::fromPhp()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
267			break;
268			case 'yaml':
269			$config = Config::fromYaml($configFilePath);
			0 ignored issues – show Bug introduced 2017-09-15 20:49 UTC by Report Bug Copy Issue Report It seems like `$configFilePath` defined by `$this->locateConfigFile($input)` on line `239` can also be of type `array`; however, `Phinx\Config\Config::fromYaml()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
270			break;
271			default:
272			throw new \InvalidArgumentException(sprintf('\'%s\' is not a valid parser.', $parser));
273			}
274
275			$output->writeln('<info>using config parser</info> ' . $parser);
276
277			$this->setConfig($config);
278			}
279
280			/**
281			* Load the migrations manager and inject the config
282			*
283	32		* @param \Symfony\Component\Console\Input\InputInterface $input
284			* @param \Symfony\Component\Console\Output\OutputInterface $output
285	32		*/
286			protected function loadManager(InputInterface $input, OutputInterface $output)
287			{
288			if ($this->getManager() === null) {
289	32		$manager = new Manager($this->getConfig(), $input, $output);
290	32		$this->setManager($manager);
291	32		} else {
292			$manager = $this->getManager();
293	32		$manager->setInput($input);
294			$manager->setOutput($output);
295			}
296			}
297
298			/**
299			* Verify that the migration directory exists and is writable.
300			*
301			* @param string $path
302	13		* @throws \InvalidArgumentException
303			* @return void
304	13		*/
305		View Code Duplication	protected function verifyMigrationDirectory($path)
			0 ignored issues – show Duplication introduced 2017-09-15 20:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
306			{
307			if (!is_dir($path)) {
308			throw new \InvalidArgumentException(sprintf(
309			'Migration directory "%s" does not exist',
310			$path
311	13		));
312			}
313
314			if (!is_writable($path)) {
315			throw new \InvalidArgumentException(sprintf(
316			'Migration directory "%s" is not writable',
317	13		$path
318			));
319			}
320			}
321
322			/**
323			* Verify that the seed directory exists and is writable.
324			*
325			* @param string $path
326	2		* @throws \InvalidArgumentException
327			* @return void
328	2		*/
329		View Code Duplication	protected function verifySeedDirectory($path)
			0 ignored issues – show Duplication introduced 2017-09-15 20:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
330			{
331			if (!is_dir($path)) {
332			throw new \InvalidArgumentException(sprintf(
333			'Seed directory "%s" does not exist',
334			$path
335	2		));
336			}
337
338			if (!is_writable($path)) {
339			throw new \InvalidArgumentException(sprintf(
340			'Seed directory "%s" is not writable',
341	2		$path
342			));
343			}
344			}
345
346			/**
347			* Returns the migration template filename.
348	2		*
349			* @return string
350	2		*/
351			protected function getMigrationTemplateFilename()
352			{
353			return __DIR__ . self::DEFAULT_MIGRATION_TEMPLATE;
354			}
355
356			/**
357			* Returns the seed template filename.
358	1		*
359			* @return string
360	1		*/
361			protected function getSeedTemplateFilename()
362			{
363			return __DIR__ . self::DEFAULT_SEED_TEMPLATE;
364			}
365			}
366

cakephp / phinx

Pull Request — master (#1390)

AbstractCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like