| Conditions | 19 |
| Paths | > 20000 |
| Total Lines | 45 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 103 | public static function murmurhash3_int($key, $seed=0){ |
||
| 104 | $key = (string) $key; |
||
| 105 | $klen = strlen($key); |
||
| 106 | $h1 = $seed; |
||
| 107 | for ($i=0,$bytes=$klen-($remainder=$klen&3) ; $i<$bytes ; ) { |
||
| 108 | $k1 = ((ord($key[$i]) & 0xff)) |
||
| 109 | | ((ord($key[++$i]) & 0xff) << 8) |
||
| 110 | | ((ord($key[++$i]) & 0xff) << 16) |
||
| 111 | | ((ord($key[++$i]) & 0xff) << 24); |
||
| 112 | ++$i; |
||
| 113 | $k1 = (((($k1 & 0xffff) * 0xcc9e2d51) |
||
| 114 | + ((((($k1 >= 0 ? $k1 >> 16 : (($k1 & 0x7fffffff) >> 16) | 0x8000)) * 0xcc9e2d51) & 0xffff) << 16))) |
||
| 115 | & 0xffffffff; |
||
| 116 | $k1 = $k1 << 15 | ($k1 >= 0 ? $k1 >> 17 : (($k1 & 0x7fffffff) >> 17) | 0x4000); |
||
| 117 | $k1 = (((($k1 & 0xffff) * 0x1b873593) + ((((($k1 >= 0 ? $k1 >> 16 : (($k1 & 0x7fffffff) >> 16) | 0x8000)) |
||
| 118 | * 0x1b873593) & 0xffff) << 16))) & 0xffffffff; |
||
| 119 | $h1 ^= $k1; |
||
| 120 | $h1 = $h1 << 13 | ($h1 >= 0 ? $h1 >> 19 : (($h1 & 0x7fffffff) >> 19) | 0x1000); |
||
| 121 | $h1b = (((($h1 & 0xffff) * 5) + ((((($h1 >= 0 ? $h1 >> 16 : (($h1 & 0x7fffffff) >> 16) | 0x8000)) * 5) |
||
| 122 | & 0xffff) << 16))) & 0xffffffff; |
||
| 123 | $h1 = ((($h1b & 0xffff) + 0x6b64) + ((((($h1b >= 0 ? $h1b >> 16 : (($h1b & 0x7fffffff) >> 16) | 0x8000)) |
||
| 124 | + 0xe654) & 0xffff) << 16)); |
||
| 125 | } |
||
| 126 | $k1 = 0; |
||
| 127 | switch ($remainder) { |
||
| 128 | case 3: $k1 ^= (ord($key[$i + 2]) & 0xff) << 16; |
||
| 129 | case 2: $k1 ^= (ord($key[$i + 1]) & 0xff) << 8; |
||
| 130 | case 1: $k1 ^= (ord($key[$i]) & 0xff); |
||
| 131 | $k1 = ((($k1 & 0xffff) * 0xcc9e2d51) + ((((($k1 >= 0 ? $k1 >> 16 : (($k1 & 0x7fffffff) >> 16) | 0x8000)) |
||
| 132 | * 0xcc9e2d51) & 0xffff) << 16)) & 0xffffffff; |
||
| 133 | $k1 = $k1 << 15 | ($k1 >= 0 ? $k1 >> 17 : (($k1 & 0x7fffffff) >> 17) | 0x4000); |
||
| 134 | $k1 = ((($k1 & 0xffff) * 0x1b873593) + ((((($k1 >= 0 ? $k1 >> 16 : (($k1 & 0x7fffffff) >> 16) | 0x8000)) |
||
| 135 | * 0x1b873593) & 0xffff) << 16)) & 0xffffffff; |
||
| 136 | $h1 ^= $k1; |
||
| 137 | } |
||
| 138 | $h1 ^= $klen; |
||
| 139 | $h1 ^= ($h1 >= 0 ? $h1 >> 16 : (($h1 & 0x7fffffff) >> 16) | 0x8000); |
||
| 140 | $h1 = ((($h1 & 0xffff) * 0x85ebca6b) + ((((($h1 >= 0 ? $h1 >> 16 : (($h1 & 0x7fffffff) >> 16) | 0x8000)) |
||
| 141 | * 0x85ebca6b) & 0xffff) << 16)) & 0xffffffff; |
||
| 142 | $h1 ^= ($h1 >= 0 ? $h1 >> 13 : (($h1 & 0x7fffffff) >> 13) | 0x40000); |
||
| 143 | $h1 = (((($h1 & 0xffff) * 0xc2b2ae35) + ((((($h1 >= 0 ? $h1 >> 16 : (($h1 & 0x7fffffff) >> 16) | 0x8000)) |
||
| 144 | * 0xc2b2ae35) & 0xffff) << 16))) & 0xffffffff; |
||
| 145 | $h1 ^= ($h1 >= 0 ? $h1 >> 16 : (($h1 & 0x7fffffff) >> 16) | 0x8000); |
||
| 146 | return $h1; |
||
| 147 | } |
||
| 148 | |||
| 154 |