HTTP::request() - Code Metrics - Inspection of "Fixed typo" - caffeina-core/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 9abbb5...626acb )

by Stefano
created 2016-10-25 16:26 UTC
HTTP::request() C

↳ Parent: HTTP
Complexity

Conditions	12
Paths	32
Size

Total Lines	55
Code Lines	45
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	12
eloc	45
nc	32
nop	7
dl	0
loc	55
rs	6.8009
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

/**
 * HTTP
 *
 * cURL proxy.
 *
 * @package core
 * @author [email protected]
 * @copyright Caffeina srl - 2016 - http://caffeina.com
 */

class HTTP {
  use Module, Events;

  protected static $UA          = "Mozilla/4.0 (compatible; Core::HTTP; Windows NT 6.1)",

                   $json_data   = false,
                   $headers     = [],
                   $last_info   = null,
                   $proxy       = null; // host:port

  protected static function request($method, $url, $data=[], array $headers=[], $data_as_json=false, $username=null, $password = null){
    $http_method = strtoupper($method);
    $ch  = curl_init($url);
    $opt = [
      CURLOPT_CUSTOMREQUEST   => $http_method,
      CURLOPT_SSL_VERIFYHOST  => false,
      CURLOPT_CONNECTTIMEOUT  => 10,
      CURLOPT_RETURNTRANSFER  => true,
      CURLOPT_USERAGENT       => static::$UA,
      CURLOPT_HEADER          => false,
      CURLOPT_MAXREDIRS       => 10,
      CURLOPT_FOLLOWLOCATION  => true,
      CURLOPT_ENCODING        => '',
      CURLOPT_PROXY           => static::$proxy,
    ];

    if($username && $password) {
      $opt[CURLOPT_USERPWD] = "$username:$password";
    }

    $headers = array_merge($headers,static::$headers);

    if($http_method == 'GET'){
        if($data && is_array($data)){
          $tmp                       = [];
          $queried_url               = $url;
          foreach($data as $key=>$val) $tmp[] = $key.'='.$val;
          $queried_url               .= (strpos($queried_url,'?') === false) ? '?' : '&';
          $queried_url               .= implode('&',$tmp);
          $opt[CURLOPT_URL]          = $queried_url;
          $opt[CURLOPT_HTTPGET]      = true;
          unset($opt[CURLOPT_CUSTOMREQUEST]);
        }
    } else {
        $opt[CURLOPT_CUSTOMREQUEST]  = $http_method;
        if($data_as_json or is_object($data)){
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
          $headers['Content-Type']   = 'application/json';
          $opt[CURLOPT_POSTFIELDS]   = json_encode($data);
        } else {
          $opt[CURLOPT_POSTFIELDS]   = http_build_query($data);
        }
    }

    curl_setopt_array($ch,$opt);
    $_harr = [];
    foreach($headers as $key=>$val)  $_harr[] = $key.': '.$val;
    curl_setopt($ch, CURLOPT_HTTPHEADER, $_harr);
    $result = curl_exec($ch);
    $contentType = strtolower(curl_getinfo($ch, CURLINFO_CONTENT_TYPE));
    static::$last_info = curl_getinfo($ch);
    if(false !== strpos($contentType,'json')) $result = json_decode($result);
    curl_close($ch);
    static::trigger("request", $result, static::$last_info);
    return $result;
  }

  public static function useJSON($value=null){
    return $value===null ? static::$json_data : static::$json_data = $value;
  }

  public static function addHeader($name,$value){
    static::$headers[$name] = $value;
  }

  public static function removeHeader($name){
    unset(static::$headers[$name]);
  }

  public static function headers($name=null){
    // null === $name ?? static::$headers ?? static::$headers[$name]
    return null === $name
           ? static::$headers
           : ( isset(static::$headers[$name]) ? static::$headers[$name] : '' );
  }

  public static function userAgent($value=null){
    return $value===null ? static::$UA : static::$UA = $value;
  }

  public static function proxy($proxy=false){

    return $value===false ? static::$proxy : static::$proxy = $value;

  }

  public static function get($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('get',$url,$data,$headers,false,$username,$password);
  }

  public static function post($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('post',$url,$data,$headers,static::$json_data,$username,$password);
  }

  public static function put($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('put',$url,$data,$headers,static::$json_data,$username,$password);
  }

  public static function delete($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('delete',$url,$data,$headers,static::$json_data,$username,$password);
  }

  public static function info($url = null){
    if ($url){
      curl_setopt_array($ch = curl_init($url), [
        CURLOPT_SSL_VERIFYHOST  => false,
        CURLOPT_CONNECTTIMEOUT  => 10,
        CURLOPT_RETURNTRANSFER  => true,
        CURLOPT_USERAGENT       => static::$UA,
        CURLOPT_HEADER          => false,
        CURLOPT_ENCODING        => '',
        CURLOPT_FILETIME        => true,
        CURLOPT_NOBODY          => true,
        CURLOPT_PROXY           => static::$proxy,
      ]);
      curl_exec($ch);
      $info = curl_getinfo($ch);
      curl_close($ch);
      return $info;
    } else {
      return static::$last_info;
    }
  }

}

class HTTP_Request {
  public $method   = 'GET',

         $url      = null,
         $headers  = [],
         $body     = '';

  public function __construct($method, $url, $headers=[], $data=null){

    $this->method   = strtoupper($method);
    $this->url      = new URL($this->url);
    $this->headers  = (array)$headers;
    if ($data) {
      if (isset($this->headers["Content-Type"]) && $this->headers["Content-Type"]=='application/json')
        $this->body = json_encode($data);
      else
        $this->body = http_build_query($data);
    }
  }

  public function __toString(){
    return "$this->method {$this->url->path}{$this->url->query} HTTP/1.1\r\n"
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
          ."Host: {$this->url->host}\r\n"
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
          .($this->headers ? implode("\r\n",$this->headers) . "\r\n" : '')
          ."\r\n{$this->body}";
  }
}


class HTTP_Response {
  public $status   = 200,

         $headers  = [],
         $contents = '';

  public function __construct($contents, $status, $headers){
    $this->status   = $status;
    $this->contents = $contents;
    $this->headers  = (array)$headers;
  }

  public function __toString(){
    return $this->contents;
  }
}


caffeina-core / core

Push — master ( 9abbb5...626acb )

HTTP::request() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like
