HTTP

Complexity

Total Complexity

29

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
C	request()	0	55	12
A	useJSON()	0	3	2
A	addHeader()	0	3	1
A	removeHeader()	0	3	1
A	headers()	0	6	3
A	userAgent()	0	3	2
A	proxy()	0	3	2
A	get()	0	3	1
A	post()	0	3	1
A	put()	0	3	1
A	delete()	0	3	1
A	info()	0	21	2

<?php

/**
 * HTTP
 *
 * cURL proxy.
 *
 * @package core
 * @author stefano.azzolini@caffeina.com
 * @copyright Caffeina srl - 2016 - http://caffeina.com
 */

class HTTP {
  use Module, Events;

  protected static $UA          = "Mozilla/4.0 (compatible; Core::HTTP; Windows NT 6.1)",

It is generally advisable to only define one property per statement.

                   $json_data   = false,
                   $headers     = [],
                   $last_info   = null,
                   $proxy       = null; // host:port

  protected static function request($method, $url, $data=[], array $headers=[], $data_as_json=false, $username=null, $password = null){
    $http_method = strtoupper($method);
    $ch  = curl_init($url);
    $opt = [
      CURLOPT_CUSTOMREQUEST   => $http_method,
      CURLOPT_SSL_VERIFYHOST  => false,
      CURLOPT_CONNECTTIMEOUT  => 10,
      CURLOPT_RETURNTRANSFER  => true,
      CURLOPT_USERAGENT       => static::$UA,
      CURLOPT_HEADER          => false,
      CURLOPT_MAXREDIRS       => 10,
      CURLOPT_FOLLOWLOCATION  => true,
      CURLOPT_ENCODING        => '',
      CURLOPT_PROXY           => static::$proxy,
    ];

    if($username && $password) {
      $opt[CURLOPT_USERPWD] = "$username:$password";
    }

    $headers = array_merge($headers,static::$headers);

    if($http_method == 'GET'){
        if($data && is_array($data)){
          $tmp                       = [];
          $queried_url               = $url;
          foreach($data as $key=>$val) $tmp[] = $key.'='.$val;
          $queried_url               .= (strpos($queried_url,'?') === false) ? '?' : '&';
          $queried_url               .= implode('&',$tmp);
          $opt[CURLOPT_URL]          = $queried_url;
          $opt[CURLOPT_HTTPGET]      = true;
          unset($opt[CURLOPT_CUSTOMREQUEST]);
        }
    } else {
        $opt[CURLOPT_CUSTOMREQUEST]  = $http_method;
        if($data_as_json or is_object($data)){

Using logical operators such as or instead of || is generally not recommended.

          $headers['Content-Type']   = 'application/json';
          $opt[CURLOPT_POSTFIELDS]   = json_encode($data);
        } else {
          $opt[CURLOPT_POSTFIELDS]   = http_build_query($data);
        }
    }

    curl_setopt_array($ch,$opt);
    $_harr = [];
    foreach($headers as $key=>$val)  $_harr[] = $key.': '.$val;
    curl_setopt($ch, CURLOPT_HTTPHEADER, $_harr);
    $result = curl_exec($ch);
    $contentType = strtolower(curl_getinfo($ch, CURLINFO_CONTENT_TYPE));
    static::$last_info = curl_getinfo($ch);
    if(false !== strpos($contentType,'json')) $result = json_decode($result);
    curl_close($ch);
    static::trigger("request", $result, static::$last_info);
    return $result;
  }

  public static function useJSON($value=null){
    return $value===null ? static::$json_data : static::$json_data = $value;
  }

  public static function addHeader($name,$value){
    static::$headers[$name] = $value;
  }

  public static function removeHeader($name){
    unset(static::$headers[$name]);
  }

  public static function headers($name=null){
    // null === $name ?? static::$headers ?? static::$headers[$name]
    return null === $name
           ? static::$headers
           : ( isset(static::$headers[$name]) ? static::$headers[$name] : '' );
  }

  public static function userAgent($value=null){
    return $value===null ? static::$UA : static::$UA = $value;
  }

  public static function proxy($proxy=false){

The parameter $proxy is not used and could be removed.

    return $value===false ? static::$proxy : static::$proxy = $value;

The variable $value does not exist. Did you forget to declare it?

  }

  public static function get($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('get',$url,$data,$headers,false,$username,$password);
  }

  public static function post($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('post',$url,$data,$headers,static::$json_data,$username,$password);
  }

  public static function put($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('put',$url,$data,$headers,static::$json_data,$username,$password);
  }

  public static function delete($url, $data=null, array $headers=[], $username = null, $password = null){
    return static::request('delete',$url,$data,$headers,static::$json_data,$username,$password);
  }

  public static function info($url = null){
    if ($url){
      curl_setopt_array($ch = curl_init($url), [
        CURLOPT_SSL_VERIFYHOST  => false,
        CURLOPT_CONNECTTIMEOUT  => 10,
        CURLOPT_RETURNTRANSFER  => true,
        CURLOPT_USERAGENT       => static::$UA,
        CURLOPT_HEADER          => false,
        CURLOPT_ENCODING        => '',
        CURLOPT_FILETIME        => true,
        CURLOPT_NOBODY          => true,
        CURLOPT_PROXY           => static::$proxy,
      ]);
      curl_exec($ch);
      $info = curl_getinfo($ch);
      curl_close($ch);
      return $info;
    } else {
      return static::$last_info;
    }
  }

}

class HTTP_Request {
  public $method   = 'GET',

It is generally advisable to only define one property per statement.

         $url      = null,
         $headers  = [],
         $body     = '';

  public function __construct($method, $url, $headers=[], $data=null){

The parameter $url is not used and could be removed.

    $this->method   = strtoupper($method);
    $this->url      = new URL($this->url);
    $this->headers  = (array)$headers;
    if ($data) {
      if (isset($this->headers["Content-Type"]) && $this->headers["Content-Type"]=='application/json')
        $this->body = json_encode($data);
      else
        $this->body = http_build_query($data);
    }
  }

  public function __toString(){
    return "$this->method {$this->url->path}{$this->url->query} HTTP/1.1\r\n"

The property $path is declared private in URL. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

The property $query is declared private in URL. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

          ."Host: {$this->url->host}\r\n"

The property $host is declared private in URL. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

          .($this->headers ? implode("\r\n",$this->headers) . "\r\n" : '')
          ."\r\n{$this->body}";
  }
}


class HTTP_Response {
  public $status   = 200,

It is generally advisable to only define one property per statement.

         $headers  = [],
         $contents = '';

  public function __construct($contents, $status, $headers){
    $this->status   = $status;
    $this->contents = $contents;
    $this->headers  = (array)$headers;
  }

  public function __toString(){
    return $this->contents;
  }
}