Request - Code Metrics - Inspection of "DEM status" - caffeina-core/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 78dfa0...3cbabb )

by Stefano

created 2016-07-04 13:10 UTC

Request A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	71
rs	10
wmc	15
lcom	1
cbo	1

7 Methods

Rating	Name	Size	Complexity
A	authorization()	4	1
A	data()	7	3
A	method()	4	1
A	addHeader()	4	1
A	__construct()	7	2
B	build()	21	6
A	__toString()	3	1

<?php

/**
 * HTTP\Request
 *
 * Core\HTTP Interfaces.
 *
 * @package core
 * @author [email protected]
 * @copyright Caffeina srl - 2015-2016 - http://caffeina.com
 */

namespace HTTP;

class Request {

  const FORM = 0,
        JSON = 1;

  public $method  = 'GET',

         $encoding = self::FORM,
         $url      = '',
         $headers  = [],
         $body     = '',
         $UA       = "Mozilla/4.0 (compatible; Core::HTTP; Windows NT 6.1)",
         $auth     = null;

  public function authorization(Auth\Method $auth){
    $this->auth = $auth;
    return $this;
  }

  public function data($data){
    switch($this->encoding){
      case self::JSON: $this->body = json_encode($data); break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
      default: case self::FORM: $this->body = http_build_query($data); break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    };
    return $this;
  }

  public function method($verb){

    $this->method = strtoupper($method);

    return $this;
  }

  public function addHeader($key, $value){
    $this->headers[$key] = $value;
    return $this;
  }

  public function __construct($method, $url, $headers=[], $data=null){

    $this->method($method);
    $this->url      = new URL($this->url);

    $this->headers  = (array)$headers;
    if ($data) $this->data($data);
    return $this;
  }

  public function build(){
    $body = ["$this->method {$this->url->path}{$this->url->query} HTTP/1.1"];
    $body[] = "Host: {$this->url->host}";

    // Ensure content type
    if (empty($this->headers["Content-Type"])) switch($this->encoding){
      case self::JSON: $this->headers["Content-Type"] = "application/json"; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
      default: case self::FORM: $this->headers["Content-Type"] = "application/x-www-form-urlencoded"; break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    };

    // Apply Authentication
    if ($this->auth) $this->auth->applyTo($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    foreach ($this->headers as $key => $value) {
      $body[] = "$key: $value";
    }

    $body[] = "";
    $body[] = $this->body;
    return implode("\r\n", $body);
  }

  public function __toString(){
    return $this->build();
  }

}

1			<?php
2
3			/**
4			* HTTP\Request
5			*
6			* Core\HTTP Interfaces.
7			*
8			* @package core
9			* @author [email protected]
10			* @copyright Caffeina srl - 2015-2016 - http://caffeina.com
11			*/
12
13			namespace HTTP;
14
15			class Request {
16
17			const FORM = 0,
18			JSON = 1;
19
20			public $method = 'GET',
			0 ignored issues – show Coding Style introduced 2016-07-04 09:54 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history...
21			$encoding = self::FORM,
22			$url = '',
23			$headers = [],
24			$body = '',
25			$UA = "Mozilla/4.0 (compatible; Core::HTTP; Windows NT 6.1)",
26			$auth = null;
27
28			public function authorization(Auth\Method $auth){
29			$this->auth = $auth;
30			return $this;
31			}
32
33			public function data($data){
34			switch($this->encoding){
35			case self::JSON: $this->body = json_encode($data); break;
			0 ignored issues – show Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
36			default: case self::FORM: $this->body = http_build_query($data); break;
			0 ignored issues – show Unused Code introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report `case self::FORM: $th...uery($data); break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
37			};
38			return $this;
39			}
40
41			public function method($verb){
			0 ignored issues – show Unused Code introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The parameter `$verb` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42			$this->method = strtoupper($method);
			0 ignored issues – show Bug introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The variable `$method` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
43			return $this;
44			}
45
46			public function addHeader($key, $value){
47			$this->headers[$key] = $value;
48			return $this;
49			}
50
51			public function __construct($method, $url, $headers=[], $data=null){
			0 ignored issues – show Unused Code introduced 2016-07-04 09:54 UTC by Report Bug Copy Issue Report The parameter `$url` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
52			$this->method($method);
53			$this->url = new URL($this->url);
			0 ignored issues – show Documentation Bug introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report It seems like `new \HTTP\URL($this->url)` of type `object<HTTP\URL>` is incompatible with the declared type `string` of property `$url`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
54			$this->headers = (array)$headers;
55			if ($data) $this->data($data);
56			return $this;
57			}
58
59			public function build(){
60			$body = ["$this->method {$this->url->path}{$this->url->query} HTTP/1.1"];
61			$body[] = "Host: {$this->url->host}";
62
63			// Ensure content type
64			if (empty($this->headers["Content-Type"])) switch($this->encoding){
65			case self::JSON: $this->headers["Content-Type"] = "application/json"; break;
			0 ignored issues – show Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
66			default: case self::FORM: $this->headers["Content-Type"] = "application/x-www-form-urlencoded"; break;
			0 ignored issues – show Unused Code introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report `case self::FORM: $th...urlencoded'; break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
67			};
68
69			// Apply Authentication
70			if ($this->auth) $this->auth->applyTo($this);
			0 ignored issues – show Documentation introduced 2016-07-04 13:14 UTC by Report Bug Copy Issue Report `$this` is of type `this<HTTP\Request>`, but the function expects a `object<HTTP\Auth\HTTP\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71
72			foreach ($this->headers as $key => $value) {
73			$body[] = "$key: $value";
74			}
75
76			$body[] = "";
77			$body[] = $this->body;
78			return implode("\r\n", $body);
79			}
80
81			public function __toString(){
82			return $this->build();
83			}
84
85			}

caffeina-core / core

Push — master ( 78dfa0...3cbabb )

Request A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like