Options

Complexity

Total Complexity

15

Size/Duplication

Total Lines	88
Duplicated Lines	18.18 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	loadPHP()	9	9	2
A	loadINI()	7	7	2
A	loadJSON()	0	8	3
A	loadArray()	0	9	2
B	loadENV()	0	20	6

<?php

/**
 * Options
 *
 * A dictionary to handle application-wide options.
 *
 * @package core
 * @author stefano.azzolini@caffeinalab.com
 * @copyright Caffeina srl - 2015 - http://caffeina.it
 */

class Options extends Dictionary {
  protected static $fields = null;

  /**
	 * Load a PHP configuration file (script must return array)
	 * @param  string $filepath The path of the PHP config file
	 * @param  string $prefix_path You can insert/update the loaded array to a specific key path, if omitted it will be merged with the whole dictionary
	 */
  public static function loadPHP($filepath,$prefix_path=null){

This method seems to be duplicated in your project.

    ob_start();
    $results = include($filepath);
    ob_end_clean();
    if($results) {
      $results = static::filterWith(["load.php", "load"], $results);
      static::loadArray($results,$prefix_path);
    }
  }

  /**
	 * Load an INI configuration file
	 * @param  string $filepath The path of the INI config file
	 * @param  string $prefix_path You can insert/update the loaded array to a specific key path, if omitted it will be merged with the whole dictionary
	 */
  public static function loadINI($filepath,$prefix_path=null){

This method seems to be duplicated in your project.

    $results = parse_ini_file($filepath,true);
    if($results) {

The expression $results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

      $results = static::filterWith(["load.ini", "load"], $results);
      static::loadArray($results,$prefix_path);
    }
  }

  /**
   * Load a JSON configuration file
   * @param  string $filepath The path of the JSON config file
   * @param  string $prefix_path You can insert/update the loaded array to a specific key path, if omitted it will be merged with the whole dictionary
   */
  public static function loadJSON($filepath,$prefix_path=null){
    $data = file_get_contents($filepath);
    $results = $data?json_decode($data,true):[];
    if($results) {
      $results = static::filterWith(["load.json", "load"], $results);
      static::loadArray($results,$prefix_path);
    }
  }

  /**
	 * Load an array to the configuration
	 * @param  array $array The array to load
	 * @param  string $prefix_path You can insert/update the loaded array to a specific key path, if omitted it will be merged with the whole dictionary
	 */
  public static function loadArray(array $array,$prefix_path=null){
    $array = static::filterWith(["load.array", "load"], $array);
    if ($prefix_path){

The expression $prefix_path of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

      static::set($prefix_path,$array);
    } else {
      static::merge($array);
    }
    self::trigger('loaded');
  }

  /**
   * Load an ENV file
   * @param  string $dir The directory of the ENV file
   * @param  string $envname The filename for the ENV file (Default to `.env`)
   * @param  string $prefix_path You can insert/update the loaded array to a specific key path, if omitted it will be merged with the whole dictionary
   */
  public static function loadENV($dir,$envname='.env',$prefix_path=null){
    $dir = rtrim($dir,'/');
    $results = [];
    foreach(file("$dir/$envname", FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES) as $line){
      $line = trim($line);
      if ($line[0]=='#' || strpos($line,'=')===false) continue;
      list($key,$value) = explode('=',$line,2);
      $key   = trim(str_replace(['export ', "'", '"'], '', $key));
      $value = stripslashes(trim($value,'"\''));
      $results[$key] = preg_replace_callback('/\${([a-zA-Z0-9_]+)}/',function($m) use (&$results){
        return isset($results[$m[1]]) ? $results[$m[1]] : '';
      },$value);
      putenv("$key={$results[$key]}");
      $_ENV[$key] = $results[$key];
    }
    if($results) {

The expression $results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

      $results = static::filterWith(["load.env", "load"], $results);
      static::loadArray($results,$prefix_path);
    }
  }

}