Passed
Pull Request — master (#16)
by Anton
03:45
created
www/engine/System/Classes/Modules/Entitizer/Dataset/User.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,14 +12,14 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->addWorker('gravatar', function (array $data) {
15
+			$this->addWorker('gravatar', function(array $data) {
16 16
 
17 17
 				return md5(strtolower($data['email']));
18 18
 			});
19 19
 
20
-			$this->addWorker('full_name', function (array $data) {
20
+			$this->addWorker('full_name', function(array $data) {
21 21
 
22
-				return trim($data['first_name'] . ' ' . $data['last_name']);
22
+				return trim($data['first_name'].' '.$data['last_name']);
23 23
 			});
24 24
 		}
25 25
 	}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Dataset/Page.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -12,23 +12,23 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->addWorker('active', function (array $data) {
15
+			$this->addWorker('active', function(array $data) {
16 16
 
17 17
 				return (($data['visibility'] === VISIBILITY_PUBLISHED) && !$data['locked']);
18 18
 			});
19 19
 
20
-			$this->addWorker('link', function (array $data) {
20
+			$this->addWorker('link', function(array $data) {
21 21
 
22 22
 				if ('' === $data['slug']) return '';
23 23
 
24
-				return (INSTALL_PATH . '/' . $data['slug']);
24
+				return (INSTALL_PATH.'/'.$data['slug']);
25 25
 			});
26 26
 
27
-			$this->addWorker('canonical', function (array $data) {
27
+			$this->addWorker('canonical', function(array $data) {
28 28
 
29 29
 				if ('' === $data['slug']) return '';
30 30
 
31
-				return (Settings::get('system_url') . (($data['id'] !== 1) ? ('/' . $data['slug']) : ''));
31
+				return (Settings::get('system_url').(($data['id'] !== 1) ? ('/'.$data['slug']) : ''));
32 32
 			});
33 33
 		}
34 34
 	}
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,14 +19,18 @@
 block discarded – undo
19 19
 
20 20
 			$this->addWorker('link', function (array $data) {
21 21
 
22
-				if ('' === $data['slug']) return '';
22
+				if ('' === $data['slug']) {
23
+					return '';
24
+				}
23 25
 
24 26
 				return (INSTALL_PATH . '/' . $data['slug']);
25 27
 			});
26 28
 
27 29
 			$this->addWorker('canonical', function (array $data) {
28 30
 
29
-				if ('' === $data['slug']) return '';
31
+				if ('' === $data['slug']) {
32
+					return '';
33
+				}
30 34
 
31 35
 				return (Settings::get('system_url') . (($data['id'] !== 1) ? ('/' . $data['slug']) : ''));
32 36
 			});
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Dataset/Menuitem.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,13 +12,13 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->addWorker('link', function (array $data) {
15
+			$this->addWorker('link', function(array $data) {
16 16
 
17 17
 				if ('' === $data['slug']) return '';
18 18
 
19 19
 				if (false !== Validate::url($data['slug'])) return $data['slug'];
20 20
 
21
-				return (INSTALL_PATH . '/' . $data['slug']);
21
+				return (INSTALL_PATH.'/'.$data['slug']);
22 22
 			});
23 23
 		}
24 24
 	}
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,9 +14,13 @@
 block discarded – undo
14 14
 
15 15
 			$this->addWorker('link', function (array $data) {
16 16
 
17
-				if ('' === $data['slug']) return '';
17
+				if ('' === $data['slug']) {
18
+					return '';
19
+				}
18 20
 
19
-				if (false !== Validate::url($data['slug'])) return $data['slug'];
21
+				if (false !== Validate::url($data['slug'])) {
22
+					return $data['slug'];
23
+				}
20 24
 
21 25
 				return (INSTALL_PATH . '/' . $data['slug']);
22 26
 			});
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Utils/Entity/Modify.php 3 patches
Braces   +66 added lines, -22 removed lines patch added patch discarded remove patch
@@ -35,7 +35,9 @@  discard block
 block discarded – undo
35 35
 
36 36
 			         ("WHERE rlb.ancestor = " . $this->id . " AND rlx.ancestor IS NULL");
37 37
 
38
-			if (!(DB::send($query) && DB::getLast()->status)) return false;
38
+			if (!(DB::send($query) && DB::getLast()->status)) {
39
+				return false;
40
+			}
39 41
 
40 42
 			# Set path
41 43
 
@@ -60,7 +62,9 @@  discard block
 block discarded – undo
60 62
 
61 63
 			         ("WHERE sub.ancestor = " . $this->id . " AND sup.descendant = " . $parent_id);
62 64
 
63
-			if (!(DB::send($query) && (DB::getLast()->rows > 0))) return false;
65
+			if (!(DB::send($query) && (DB::getLast()->rows > 0))) {
66
+				return false;
67
+			}
64 68
 
65 69
 			# Set path
66 70
 
@@ -75,27 +79,37 @@  discard block
 block discarded – undo
75 79
 
76 80
 		public function create(array $data) {
77 81
 
78
-			if (0 !== $this->id) return false;
82
+			if (0 !== $this->id) {
83
+				return false;
84
+			}
79 85
 
80 86
 			$data = $this->dataset->cast($data);
81 87
 
82
-			if (static::$auto_increment && isset($data['id'])) $data['id'] = 0;
88
+			if (static::$auto_increment && isset($data['id'])) {
89
+				$data['id'] = 0;
90
+			}
83 91
 
84 92
 			# Insert entity
85 93
 
86 94
 			DB::insert(static::$table, $data);
87 95
 
88
-			if (!(DB::getLast() && DB::getLast()->status)) return false;
96
+			if (!(DB::getLast() && DB::getLast()->status)) {
97
+				return false;
98
+			}
89 99
 
90 100
 			# Update data
91 101
 
92
-			if (static::$auto_increment) $data['id'] = DB::getLast()->id;
102
+			if (static::$auto_increment) {
103
+				$data['id'] = DB::getLast()->id;
104
+			}
93 105
 
94 106
 			$this->dataset->update($data);
95 107
 
96 108
 			# Init subtreee
97 109
 
98
-			if (static::$nesting) $this->initSubtree();
110
+			if (static::$nesting) {
111
+				$this->initSubtree();
112
+			}
99 113
 
100 114
 			# Cache entity
101 115
 
@@ -110,17 +124,23 @@  discard block
 block discarded – undo
110 124
 
111 125
 		public function edit(array $data) {
112 126
 
113
-			if (0 === $this->id) return false;
127
+			if (0 === $this->id) {
128
+				return false;
129
+			}
114 130
 
115 131
 			$data = $this->dataset->cast($data);
116 132
 
117
-			if (isset($data['id'])) unset($data['id']);
133
+			if (isset($data['id'])) {
134
+				unset($data['id']);
135
+			}
118 136
 
119 137
 			# Update entity
120 138
 
121 139
 			DB::update(static::$table, $data, ['id' => $this->id]);
122 140
 
123
-			if (!(DB::getLast() && DB::getLast()->status)) return false;
141
+			if (!(DB::getLast() && DB::getLast()->status)) {
142
+				return false;
143
+			}
124 144
 
125 145
 			# Update data
126 146
 
@@ -128,7 +148,9 @@  discard block
 block discarded – undo
128 148
 
129 149
 			# Init subtreee
130 150
 
131
-			if (static::$nesting) $this->initSubtree();
151
+			if (static::$nesting) {
152
+				$this->initSubtree();
153
+			}
132 154
 
133 155
 			# ------------------------
134 156
 
@@ -139,30 +161,44 @@  discard block
 block discarded – undo
139 161
 
140 162
 		public function move(int $parent_id) {
141 163
 
142
-			if (0 === $this->id) return false;
164
+			if (0 === $this->id) {
165
+				return false;
166
+			}
143 167
 
144 168
 			# Re-connect entity if not in tree
145 169
 
146
-			if (!$this->initSubtree()) return false;
170
+			if (!$this->initSubtree()) {
171
+				return false;
172
+			}
147 173
 
148 174
 			# Create parent entity
149 175
 
150 176
 			if (0 !== ($parent = Entitizer::get(static::$table, $parent_id))->id) {
151 177
 
152
-				if (false === ($path = $parent->path())) return false;
178
+				if (false === ($path = $parent->path())) {
179
+					return false;
180
+				}
153 181
 
154
-				if (false === ($depth = $this->subtreeDepth())) return false;
182
+				if (false === ($depth = $this->subtreeDepth())) {
183
+					return false;
184
+				}
155 185
 
156
-				if ((count($path) + $depth + 1) > CONFIG_ENTITIZER_MAX_DEPTH) return false;
186
+				if ((count($path) + $depth + 1) > CONFIG_ENTITIZER_MAX_DEPTH) {
187
+					return false;
188
+				}
157 189
 			}
158 190
 
159 191
 			# Disconnect subtree from current position
160 192
 
161
-			if (!$this->disconnectSubtree()) return false;
193
+			if (!$this->disconnectSubtree()) {
194
+				return false;
195
+			}
162 196
 
163 197
 			# Connect subtree under new position
164 198
 
165
-		 	if (0 !== $parent->id) $this->connectSubtree($parent->id);
199
+		 	if (0 !== $parent->id) {
200
+		 		$this->connectSubtree($parent->id);
201
+		 	}
166 202
 
167 203
 			# ------------------------
168 204
 
@@ -173,19 +209,27 @@  discard block
 block discarded – undo
173 209
 
174 210
 		public function remove() {
175 211
 
176
-			if (0 === $this->id) return false;
212
+			if (0 === $this->id) {
213
+				return false;
214
+			}
177 215
 
178 216
 			# Check if entity is removable
179 217
 
180
-			if (static::$super && ($this->id === 1)) return false;
218
+			if (static::$super && ($this->id === 1)) {
219
+				return false;
220
+			}
181 221
 
182
-			if (static::$nesting && (0 !== $this->subtreeCount())) return false;
222
+			if (static::$nesting && (0 !== $this->subtreeCount())) {
223
+				return false;
224
+			}
183 225
 
184 226
 			# Remove entity
185 227
 
186 228
 			DB::delete(static::$table, ['id' => $this->id]);
187 229
 
188
-			if (!(DB::getLast() && DB::getLast()->status)) return false;
230
+			if (!(DB::getLast() && DB::getLast()->status)) {
231
+				return false;
232
+			}
189 233
 
190 234
 			# Uncache entity
191 235
 
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -27,13 +27,13 @@  discard block
 block discarded – undo
27 27
 
28 28
 			$query = ("DELETE rla FROM " . static::$table_relations . " rla ") .
29 29
 
30
-			         ("JOIN "  . static::$table_relations . " rlb ON rlb.descendant = rla.descendant ") .
30
+					 ("JOIN "  . static::$table_relations . " rlb ON rlb.descendant = rla.descendant ") .
31 31
 
32
-			         ("LEFT JOIN " . static::$table_relations . " rlx ") .
32
+					 ("LEFT JOIN " . static::$table_relations . " rlx ") .
33 33
 
34
-			         ("ON rlx.ancestor = rlb.ancestor AND rlx.descendant = rla.ancestor ") .
34
+					 ("ON rlx.ancestor = rlb.ancestor AND rlx.descendant = rla.ancestor ") .
35 35
 
36
-			         ("WHERE rlb.ancestor = " . $this->id . " AND rlx.ancestor IS NULL");
36
+					 ("WHERE rlb.ancestor = " . $this->id . " AND rlx.ancestor IS NULL");
37 37
 
38 38
 			if (!(DB::send($query) && DB::getLast()->status)) return false;
39 39
 
@@ -52,13 +52,13 @@  discard block
 block discarded – undo
52 52
 
53 53
 			$query = ("INSERT INTO " . static::$table_relations . " (ancestor, descendant, depth) ") .
54 54
 
55
-			         ("SELECT sup.ancestor, sub.descendant, sup.depth + sub.depth + 1 ") .
55
+					 ("SELECT sup.ancestor, sub.descendant, sup.depth + sub.depth + 1 ") .
56 56
 
57
-			         ("FROM " . static::$table_relations . " sup ") .
57
+					 ("FROM " . static::$table_relations . " sup ") .
58 58
 
59
-			         ("JOIN " . static::$table_relations . " sub ") .
59
+					 ("JOIN " . static::$table_relations . " sub ") .
60 60
 
61
-			         ("WHERE sub.ancestor = " . $this->id . " AND sup.descendant = " . $parent_id);
61
+					 ("WHERE sub.ancestor = " . $this->id . " AND sup.descendant = " . $parent_id);
62 62
 
63 63
 			if (!(DB::send($query) && (DB::getLast()->rows > 0))) return false;
64 64
 
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -25,15 +25,15 @@  discard block
 block discarded – undo
25 25
 
26 26
 		private function disconnectSubtree() {
27 27
 
28
-			$query = ("DELETE rla FROM " . static::$table_relations . " rla ") .
28
+			$query = ("DELETE rla FROM ".static::$table_relations." rla ").
29 29
 
30
-			         ("JOIN "  . static::$table_relations . " rlb ON rlb.descendant = rla.descendant ") .
30
+			         ("JOIN ".static::$table_relations." rlb ON rlb.descendant = rla.descendant ").
31 31
 
32
-			         ("LEFT JOIN " . static::$table_relations . " rlx ") .
32
+			         ("LEFT JOIN ".static::$table_relations." rlx ").
33 33
 
34
-			         ("ON rlx.ancestor = rlb.ancestor AND rlx.descendant = rla.ancestor ") .
34
+			         ("ON rlx.ancestor = rlb.ancestor AND rlx.descendant = rla.ancestor ").
35 35
 
36
-			         ("WHERE rlb.ancestor = " . $this->id . " AND rlx.ancestor IS NULL");
36
+			         ("WHERE rlb.ancestor = ".$this->id." AND rlx.ancestor IS NULL");
37 37
 
38 38
 			if (!(DB::send($query) && DB::getLast()->status)) return false;
39 39
 
@@ -50,15 +50,15 @@  discard block
 block discarded – undo
50 50
 
51 51
 		private function connectSubtree(int $parent_id) {
52 52
 
53
-			$query = ("INSERT INTO " . static::$table_relations . " (ancestor, descendant, depth) ") .
53
+			$query = ("INSERT INTO ".static::$table_relations." (ancestor, descendant, depth) ").
54 54
 
55
-			         ("SELECT sup.ancestor, sub.descendant, sup.depth + sub.depth + 1 ") .
55
+			         ("SELECT sup.ancestor, sub.descendant, sup.depth + sub.depth + 1 ").
56 56
 
57
-			         ("FROM " . static::$table_relations . " sup ") .
57
+			         ("FROM ".static::$table_relations." sup ").
58 58
 
59
-			         ("JOIN " . static::$table_relations . " sub ") .
59
+			         ("JOIN ".static::$table_relations." sub ").
60 60
 
61
-			         ("WHERE sub.ancestor = " . $this->id . " AND sup.descendant = " . $parent_id);
61
+			         ("WHERE sub.ancestor = ".$this->id." AND sup.descendant = ".$parent_id);
62 62
 
63 63
 			if (!(DB::send($query) && (DB::getLast()->rows > 0))) return false;
64 64
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Utils/Dataset.php 1 patch
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,7 +12,9 @@  discard block
 block discarded – undo
12 12
 
13 13
 		protected function addWorker(string $name, callable $worker) {
14 14
 
15
-			if (isset($this->params[$name]) || isset($this->workers[$name])) return;
15
+			if (isset($this->params[$name]) || isset($this->workers[$name])) {
16
+				return;
17
+			}
16 18
 
17 19
 			$this->workers[$name] = $worker;
18 20
 		}
@@ -23,7 +25,9 @@  discard block
 block discarded – undo
23 25
 
24 26
 			$this->params = Entitizer::definition(static::$table)->params();
25 27
 
26
-			if (static::$nesting) $this->params['parent_id'] = $this->params['id'];
28
+			if (static::$nesting) {
29
+				$this->params['parent_id'] = $this->params['id'];
30
+			}
27 31
 
28 32
 			$this->init(); $this->reset();
29 33
 		}
@@ -34,11 +38,15 @@  discard block
 block discarded – undo
34 38
 
35 39
 			# Reset params
36 40
 
37
-			foreach ($this->params as $name => $param) $this->data[$name] = $param->cast(null);
41
+			foreach ($this->params as $name => $param) {
42
+				$this->data[$name] = $param->cast(null);
43
+			}
38 44
 
39 45
 			# Reset extras
40 46
 
41
-			foreach ($this->workers as $name => $worker) $this->data[$name] = $worker($this->data);
47
+			foreach ($this->workers as $name => $worker) {
48
+				$this->data[$name] = $worker($this->data);
49
+			}
42 50
 
43 51
 			# ------------------------
44 52
 
@@ -53,12 +61,16 @@  discard block
 block discarded – undo
53 61
 
54 62
 			foreach ($data as $name => $value) {
55 63
 
56
-				if (isset($this->params[$name])) $this->data[$name] = $this->params[$name]->cast($value);
64
+				if (isset($this->params[$name])) {
65
+					$this->data[$name] = $this->params[$name]->cast($value);
66
+				}
57 67
 			}
58 68
 
59 69
 			# Update extras
60 70
 
61
-			foreach ($this->workers as $name => $worker) $this->data[$name] = $worker($this->data);
71
+			foreach ($this->workers as $name => $worker) {
72
+				$this->data[$name] = $worker($this->data);
73
+			}
62 74
 
63 75
 			# ------------------------
64 76
 
@@ -73,7 +85,9 @@  discard block
 block discarded – undo
73 85
 
74 86
 			foreach ($data as $name => $value) {
75 87
 
76
-				if (isset($this->params[$name])) $cast[$name] = $this->params[$name]->cast($value);
88
+				if (isset($this->params[$name])) {
89
+					$cast[$name] = $this->params[$name]->cast($value);
90
+				}
77 91
 			}
78 92
 
79 93
 			# ------------------------
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Lister/Menuitems.php 1 patch
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@
 block discarded – undo
30 30
 
31 31
 		protected function processEntityParent(Template\Block $parent) {
32 32
 
33
-			if (0 !== $this->parent->id) $parent->getBlock('browse')->link = $this->parent->link;
34
-
35
-			else { $parent->getBlock('browse')->disable(); $parent->getBlock('browse_disabled')->enable(); }
33
+			if (0 !== $this->parent->id) {
34
+				$parent->getBlock('browse')->link = $this->parent->link;
35
+			} else { $parent->getBlock('browse')->disable(); $parent->getBlock('browse_disabled')->enable(); }
36 36
 		}
37 37
 
38 38
 		# Add item additional data
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Lister/Pages.php 1 patch
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@
 block discarded – undo
30 30
 
31 31
 		protected function processEntityParent(Template\Block $parent) {
32 32
 
33
-			if ((0 !== $this->parent->id) && $this->parent->active) $parent->getBlock('browse')->link = $this->parent->link;
34
-
35
-			else { $parent->getBlock('browse')->disable(); $parent->getBlock('browse_disabled')->enable(); }
33
+			if ((0 !== $this->parent->id) && $this->parent->active) {
34
+				$parent->getBlock('browse')->link = $this->parent->link;
35
+			} else { $parent->getBlock('browse')->disable(); $parent->getBlock('browse_disabled')->enable(); }
36 36
 		}
37 37
 
38 38
 		# Add item additional data
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Tools/Handler/Captcha.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 
25 25
 			# Customize captcha
26 26
 
27
-			$font = (DIR_SYSTEM_DATA . CONFIG_CAPTCHA_FONT); $size = CONFIG_CAPTCHA_FONT_SIZE;
27
+			$font = (DIR_SYSTEM_DATA.CONFIG_CAPTCHA_FONT); $size = CONFIG_CAPTCHA_FONT_SIZE;
28 28
 
29 29
 			$indent = CONFIG_CAPTCHA_TEXT_INDENT; $step = CONFIG_CAPTCHA_TEXT_STEP;
30 30
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Tools/Handler/Sitemap.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
 			# Load sitemap
46 46
 
47
-			$file_name = (DIR_SYSTEM_DATA . 'Sitemap.xml');
47
+			$file_name = (DIR_SYSTEM_DATA.'Sitemap.xml');
48 48
 
49 49
 			$modified = Explorer::getModified($file_name);
50 50
 
Please login to merge, or discard this patch.
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -12,7 +12,9 @@  discard block
 block discarded – undo
12 12
 
13 13
 			$selection = 'MAX(time_modified) as last_modified';
14 14
 
15
-			if (!(DB::select(TABLE_PAGES, $selection) && (DB::getLast()->rows === 1))) return 0;
15
+			if (!(DB::select(TABLE_PAGES, $selection) && (DB::getLast()->rows === 1))) {
16
+				return 0;
17
+			}
16 18
 
17 19
 			# ------------------------
18 20
 
@@ -27,11 +29,15 @@  discard block
 block discarded – undo
27 29
 
28 30
 			$condition = ['visibility' => VISIBILITY_PUBLISHED, 'access' => ACCESS_PUBLIC, 'locked' => 0];
29 31
 
30
-			if (!(DB::select(TABLE_PAGES, $selection, $condition, 'slug') && DB::getLast()->status)) return;
32
+			if (!(DB::select(TABLE_PAGES, $selection, $condition, 'slug') && DB::getLast()->status)) {
33
+				return;
34
+			}
31 35
 
32 36
 			# ------------------------
33 37
 
34
-			while (null !== ($data = DB::getLast()->getRow())) yield Entitizer::dataset(TABLE_PAGES, $data);
38
+			while (null !== ($data = DB::getLast()->getRow())) {
39
+				yield Entitizer::dataset(TABLE_PAGES, $data);
40
+			}
35 41
 		}
36 42
 
37 43
 		# Handle request
@@ -50,7 +56,9 @@  discard block
 block discarded – undo
50 56
 
51 57
 			if ((false !== $modified) && ($modified > $this->getLastModified())) {
52 58
 
53
-				if (false !== $sitemap->load($file_name)) return $sitemap;
59
+				if (false !== $sitemap->load($file_name)) {
60
+					return $sitemap;
61
+				}
54 62
 			}
55 63
 
56 64
 			# Fill sitemap
Please login to merge, or discard this patch.