cadmium-org /
cadmium-cms
| Conditions | 22 |
| Paths | 18 |
| Total Lines | 75 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 86 | public static function set(string $name, $value) { |
||
| 87 | |||
| 88 | if (!isset(self::$settings[$name])) return false; |
||
| 89 | |||
| 90 | # Validate language |
||
| 91 | |||
| 92 | if (($name === 'admin_language') || ($name === 'site_language')) { |
||
| 93 | |||
| 94 | if (false === ($value = Extend\Languages::validate($value))) return false; |
||
| 95 | } |
||
| 96 | |||
| 97 | # Validate template |
||
| 98 | |||
| 99 | else if (($name === 'admin_template') || ($name === 'site_template')) { |
||
| 100 | |||
| 101 | if (false === ($value = Extend\Templates::validate($value))) return false; |
||
| 102 | } |
||
| 103 | |||
| 104 | # Validate site title |
||
| 105 | |||
| 106 | else if ($name === 'site_title') { |
||
| 107 | |||
| 108 | if ('' === ($value = (function(string $value) { return $value; })($value))) return false; |
||
| 109 | } |
||
| 110 | |||
| 111 | # Validate site status |
||
| 112 | |||
| 113 | else if ($name === 'site_status') { |
||
| 114 | |||
| 115 | if (false === ($value = Lister\Status::validate($value))) return false; |
||
| 116 | } |
||
| 117 | |||
| 118 | # Validate site slogan/description/keywords |
||
| 119 | |||
| 120 | else if (($name === 'site_slogan') || ($name === 'site_description') || ($name === 'site_keywords')) { |
||
| 121 | |||
| 122 | $value = (function(string $value) { return $value; })($value); |
||
| 123 | } |
||
| 124 | |||
| 125 | # Validate system url |
||
| 126 | |||
| 127 | else if ($name === 'system_url') { |
||
| 128 | |||
| 129 | if (false === ($value = Validate::url($value))) return false; |
||
| 130 | } |
||
| 131 | |||
| 132 | # Validate system email |
||
| 133 | |||
| 134 | else if ($name === 'system_email') { |
||
| 135 | |||
| 136 | if (false === ($value = Validate::email($value))) return false; |
||
| 137 | } |
||
| 138 | |||
| 139 | # Validate system timezone |
||
| 140 | |||
| 141 | else if ($name === 'system_timezone') { |
||
| 142 | |||
| 143 | if (false === ($value = Timezone::validate($value))) return false; |
||
| 144 | } |
||
| 145 | |||
| 146 | # Validate users registration |
||
| 147 | |||
| 148 | else if ($name === 'users_registration') { |
||
| 149 | |||
| 150 | $value = (function(bool $value) { return $value; })($value); |
||
| 151 | } |
||
| 152 | |||
| 153 | # Set value |
||
| 154 | |||
| 155 | self::$settings[$name] = $value; |
||
| 156 | |||
| 157 | # ------------------------ |
||
| 158 | |||
| 159 | return true; |
||
| 160 | } |
||
| 161 | |||
| 172 |
