Passed
Pull Request — master (#10)
by Anton
04:10
created
www/engine/System/Classes/Modules/Entitizer/Utils/Dataset.php 1 patch
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,7 +12,9 @@  discard block
 block discarded – undo
12 12
 
13 13
 		protected function addHandler(string $name, callable $handler) {
14 14
 
15
-			if ((false !== $this->definition->param($name)) || isset($this->handlers[$name])) return;
15
+			if ((false !== $this->definition->param($name)) || isset($this->handlers[$name])) {
16
+				return;
17
+			}
16 18
 
17 19
 			$this->handlers[$name] = $handler;
18 20
 		}
@@ -32,15 +34,21 @@  discard block
 block discarded – undo
32 34
 
33 35
 			# Reset params
34 36
 
35
-			foreach ($this->definition->params() as $name => $param) $this->data[$name] = $param->cast(null);
37
+			foreach ($this->definition->params() as $name => $param) {
38
+				$this->data[$name] = $param->cast(null);
39
+			}
36 40
 
37 41
 			# Reset extras
38 42
 
39
-			foreach ($this->handlers as $name => $handler) $this->data[$name] = $handler($this->data);
43
+			foreach ($this->handlers as $name => $handler) {
44
+				$this->data[$name] = $handler($this->data);
45
+			}
40 46
 
41 47
 			# Reset parent id
42 48
 
43
-			if (static::$nesting) $this->data['parent_id'] = 0;
49
+			if (static::$nesting) {
50
+				$this->data['parent_id'] = 0;
51
+			}
44 52
 
45 53
 			# ------------------------
46 54
 
@@ -55,14 +63,18 @@  discard block
 block discarded – undo
55 63
 
56 64
 			foreach ($data as $name => $value) {
57 65
 
58
-				if (false === ($param = $this->definition->param($name))) continue;
66
+				if (false === ($param = $this->definition->param($name))) {
67
+					continue;
68
+				}
59 69
 
60 70
 				$this->data[$name] = $param->cast($value);
61 71
 			}
62 72
 
63 73
 			# Update extras
64 74
 
65
-			foreach ($this->handlers as $name => $handler) $this->data[$name] = $handler($this->data);
75
+			foreach ($this->handlers as $name => $handler) {
76
+				$this->data[$name] = $handler($this->data);
77
+			}
66 78
 
67 79
 			# Update parent id
68 80
 
@@ -84,7 +96,9 @@  discard block
 block discarded – undo
84 96
 
85 97
 			foreach ($data as $name => $value) {
86 98
 
87
-				if (false === ($param = $this->definition->param($name))) continue;
99
+				if (false === ($param = $this->definition->param($name))) {
100
+					continue;
101
+				}
88 102
 
89 103
 				$cast[$name] = $param->cast($value);
90 104
 			}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Utils/Treeview.php 3 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 
13 13
 			return (0 !== $parent_id) ? (("JOIN " . static::$table_relations . " rel ") .
14 14
 
15
-			       ("ON rel.ancestor = " . $parent_id . " AND rel.descendant = ent.id AND rel.depth >= 1")) :
15
+				   ("ON rel.ancestor = " . $parent_id . " AND rel.descendant = ent.id AND rel.depth >= 1")) :
16 16
 
17 17
 				   ("JOIN " . static::$table_relations . " rel ON rel.descendant = ent.id");
18 18
 		}
@@ -23,13 +23,13 @@  discard block
 block discarded – undo
23 23
 
24 24
 			return ("SELECT " . $this->getSelection() . ", COALESCE(par.ancestor, 0) as parent_id ") .
25 25
 
26
-			       ("FROM " . static::$table . " ent " . $this->getQueryJoin($parent_id) . " ") .
26
+				   ("FROM " . static::$table . " ent " . $this->getQueryJoin($parent_id) . " ") .
27 27
 
28
-			       ("LEFT JOIN " . static::$table_relations . " par ON par.descendant = ent.id AND par.depth = 1 ") .
28
+				   ("LEFT JOIN " . static::$table_relations . " par ON par.descendant = ent.id AND par.depth = 1 ") .
29 29
 
30
-			       (('' !== ($condition = $this->getCondition($config))) ? ("WHERE " . $condition . " ") : "") .
30
+				   (('' !== ($condition = $this->getCondition($config))) ? ("WHERE " . $condition . " ") : "") .
31 31
 
32
-			       ("GROUP BY ent.id ORDER BY MAX(rel.depth) ASC, " . $this->getOrderBy($order_by));
32
+				   ("GROUP BY ent.id ORDER BY MAX(rel.depth) ASC, " . $this->getOrderBy($order_by));
33 33
 		}
34 34
 
35 35
 		# Get count query
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 
39 39
 			return ("SELECT COUNT(DISTINCT ent.id) as count FROM " . static::$table . " ent ") .
40 40
 
41
-			       $this->getQueryJoin($parent_id);
41
+				   $this->getQueryJoin($parent_id);
42 42
 		}
43 43
 
44 44
 		# Get depth query
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
 			$query = ("SELECT COUNT(DISTINCT rel.depth) as depth FROM " . static::$table . " ent ") .
49 49
 
50
-			         $this->getQueryJoin($parent_id);
50
+					 $this->getQueryJoin($parent_id);
51 51
 
52 52
 			# ------------------------
53 53
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
 			$query = ("SELECT " . $this->getSelection() . " FROM " . static::$table . " ent ") .
130 130
 
131
-			         ("JOIN " . static::$table_relations . " rel ON rel.ancestor = ent.id ") .
131
+					 ("JOIN " . static::$table_relations . " rel ON rel.ancestor = ent.id ") .
132 132
 
133 133
 					 ("WHERE rel.descendant = " . $parent_id . " ORDER BY rel.depth DESC");
134 134
 
Please login to merge, or discard this patch.
Spacing   +12 added lines, -14 removed lines patch added patch discarded remove patch
@@ -10,33 +10,31 @@  discard block
 block discarded – undo
10 10
 
11 11
 		protected function getQueryJoin(int $parent_id) {
12 12
 
13
-			return (0 !== $parent_id) ? (("JOIN " . static::$table_relations . " rel ") .
13
+			return (0 !== $parent_id) ? (("JOIN ".static::$table_relations." rel ").
14 14
 
15
-			       ("ON rel.ancestor = " . $parent_id . " AND rel.descendant = ent.id AND rel.depth >= 1")) :
16
-
17
-				   ("JOIN " . static::$table_relations . " rel ON rel.descendant = ent.id");
15
+			       ("ON rel.ancestor = ".$parent_id." AND rel.descendant = ent.id AND rel.depth >= 1")) : ("JOIN ".static::$table_relations." rel ON rel.descendant = ent.id");
18 16
 		}
19 17
 
20 18
 		# Get select query
21 19
 
22 20
 		private function getSelectQuery(int $parent_id, array $config, array $order_by) {
23 21
 
24
-			return ("SELECT " . $this->getSelection() . ", COALESCE(par.ancestor, 0) as parent_id ") .
22
+			return ("SELECT ".$this->getSelection().", COALESCE(par.ancestor, 0) as parent_id ").
25 23
 
26
-			       ("FROM " . static::$table . " ent " . $this->getQueryJoin($parent_id) . " ") .
24
+			       ("FROM ".static::$table." ent ".$this->getQueryJoin($parent_id)." ").
27 25
 
28
-			       ("LEFT JOIN " . static::$table_relations . " par ON par.descendant = ent.id AND par.depth = 1 ") .
26
+			       ("LEFT JOIN ".static::$table_relations." par ON par.descendant = ent.id AND par.depth = 1 ").
29 27
 
30
-			       (('' !== ($condition = $this->getCondition($config))) ? ("WHERE " . $condition . " ") : "") .
28
+			       (('' !== ($condition = $this->getCondition($config))) ? ("WHERE ".$condition." ") : "").
31 29
 
32
-			       ("GROUP BY ent.id ORDER BY MAX(rel.depth) ASC, " . $this->getOrderBy($order_by));
30
+			       ("GROUP BY ent.id ORDER BY MAX(rel.depth) ASC, ".$this->getOrderBy($order_by));
33 31
 		}
34 32
 
35 33
 		# Get count query
36 34
 
37 35
 		private function getCountQuery(int $parent_id) {
38 36
 
39
-			return ("SELECT COUNT(DISTINCT ent.id) as count FROM " . static::$table . " ent ") .
37
+			return ("SELECT COUNT(DISTINCT ent.id) as count FROM ".static::$table." ent ").
40 38
 
41 39
 			       $this->getQueryJoin($parent_id);
42 40
 		}
@@ -45,7 +43,7 @@  discard block
 block discarded – undo
45 43
 
46 44
 		private function getDepthQuery(int $parent_id) {
47 45
 
48
-			$query = ("SELECT COUNT(DISTINCT rel.depth) as depth FROM " . static::$table . " ent ") .
46
+			$query = ("SELECT COUNT(DISTINCT rel.depth) as depth FROM ".static::$table." ent ").
49 47
 
50 48
 			         $this->getQueryJoin($parent_id);
51 49
 
@@ -126,11 +124,11 @@  discard block
 block discarded – undo
126 124
 
127 125
 			# Process query
128 126
 
129
-			$query = ("SELECT " . $this->getSelection() . " FROM " . static::$table . " ent ") .
127
+			$query = ("SELECT ".$this->getSelection()." FROM ".static::$table." ent ").
130 128
 
131
-			         ("JOIN " . static::$table_relations . " rel ON rel.ancestor = ent.id ") .
129
+			         ("JOIN ".static::$table_relations." rel ON rel.ancestor = ent.id ").
132 130
 
133
-					 ("WHERE rel.descendant = " . $parent_id . " ORDER BY rel.depth DESC");
131
+					 ("WHERE rel.descendant = ".$parent_id." ORDER BY rel.depth DESC");
134 132
 
135 133
 			# Select path
136 134
 
Please login to merge, or discard this patch.
Braces   +27 added lines, -9 removed lines patch added patch discarded remove patch
@@ -58,13 +58,17 @@  discard block
 block discarded – undo
58 58
 
59 59
 		public function subtree(int $parent_id = 0, array $config = [], array $order_by = []) {
60 60
 
61
-			if (!(static::$nesting && ($parent_id >= 0))) return false;
61
+			if (!(static::$nesting && ($parent_id >= 0))) {
62
+				return false;
63
+			}
62 64
 
63 65
 			# Select entities
64 66
 
65 67
 			$query = $this->getSelectQuery($parent_id, $config, $order_by);
66 68
 
67
-			if (!(DB::send($query) && DB::last()->status)) return false;
69
+			if (!(DB::send($query) && DB::last()->status)) {
70
+				return false;
71
+			}
68 72
 
69 73
 			# Process results
70 74
 
@@ -88,13 +92,17 @@  discard block
 block discarded – undo
88 92
 
89 93
 		public function subtreeCount(int $parent_id = 0) {
90 94
 
91
-			if (!(static::$nesting && ($parent_id >= 0))) return false;
95
+			if (!(static::$nesting && ($parent_id >= 0))) {
96
+				return false;
97
+			}
92 98
 
93 99
 			# Get count
94 100
 
95 101
 			$query = $this->getCountQuery($parent_id);
96 102
 
97
-			if (!(DB::send($query) && DB::last()->status)) return false;
103
+			if (!(DB::send($query) && DB::last()->status)) {
104
+				return false;
105
+			}
98 106
 
99 107
 			# ------------------------
100 108
 
@@ -105,13 +113,17 @@  discard block
 block discarded – undo
105 113
 
106 114
 		public function subtreeDepth(int $parent_id = 0) {
107 115
 
108
-			if (!(static::$nesting && ($parent_id >= 0))) return false;
116
+			if (!(static::$nesting && ($parent_id >= 0))) {
117
+				return false;
118
+			}
109 119
 
110 120
 			# Get depth
111 121
 
112 122
 			$query = $this->getDepthQuery($parent_id);
113 123
 
114
-			if (!(DB::send($query) && DB::last()->status)) return false;
124
+			if (!(DB::send($query) && DB::last()->status)) {
125
+				return false;
126
+			}
115 127
 
116 128
 			# ------------------------
117 129
 
@@ -122,7 +134,9 @@  discard block
 block discarded – undo
122 134
 
123 135
 		public function path(int $parent_id = 0) {
124 136
 
125
-			if (!(static::$nesting && ($parent_id >= 0))) return false;
137
+			if (!(static::$nesting && ($parent_id >= 0))) {
138
+				return false;
139
+			}
126 140
 
127 141
 			# Process query
128 142
 
@@ -134,13 +148,17 @@  discard block
 block discarded – undo
134 148
 
135 149
 			# Select path
136 150
 
137
-			if (!(DB::send($query) && DB::last()->status)) return false;
151
+			if (!(DB::send($query) && DB::last()->status)) {
152
+				return false;
153
+			}
138 154
 
139 155
 			# Process results
140 156
 
141 157
 			$path = [];
142 158
 
143
-			while (null !== ($data = DB::last()->row())) $path[] = Entitizer::dataset(static::$table, $data)->data();
159
+			while (null !== ($data = DB::last()->row())) {
160
+				$path[] = Entitizer::dataset(static::$table, $data)->data();
161
+			}
144 162
 
145 163
 			# ------------------------
146 164
 
Please login to merge, or discard this patch.
engine/System/Classes/Modules/Entitizer/Utils/Definition/Group/Foreigns.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,9 @@
 block discarded – undo
10 10
 
11 11
 		public function add(string $name, string $table, string $field, string $delete = null, string $update = null) {
12 12
 
13
-			if ((false === $this->definition->param($name)) || isset($this->list[$name])) return;
13
+			if ((false === $this->definition->param($name)) || isset($this->list[$name])) {
14
+				return;
15
+			}
14 16
 
15 17
 			$this->list[$name] = new Definition\Item\Foreign($name, $table, $field, $delete, $update);
16 18
 		}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Utils/Factory.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,9 +12,13 @@
 block discarded – undo
12 12
 
13 13
 		public static function get(string $table) {
14 14
 
15
-			if (!isset(static::$classes[$table])) throw new Exception\General(static::$error_message);
15
+			if (!isset(static::$classes[$table])) {
16
+				throw new Exception\General(static::$error_message);
17
+			}
16 18
 
17
-			if (!isset(static::$cache[$table])) static::$cache[$table] = new static::$classes[$table];
19
+			if (!isset(static::$cache[$table])) {
20
+				static::$cache[$table] = new static::$classes[$table];
21
+			}
18 22
 
19 23
 			# ------------------------
20 24
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Collection/Menuitems.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->config->add('active', false, function (bool $active) {
15
+			$this->config->add('active', false, function(bool $active) {
16 16
 
17 17
 				return ($active ? "ent.active = 1" : '');
18 18
 			});
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Collection/Pages.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -12,44 +12,44 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->config->add('active', false, function (bool $active) {
15
+			$this->config->add('active', false, function(bool $active) {
16 16
 
17
-				return ($active ? ("ent.visibility = " . VISIBILITY_PUBLISHED . " AND ent.locked = 0") : '');
17
+				return ($active ? ("ent.visibility = ".VISIBILITY_PUBLISHED." AND ent.locked = 0") : '');
18 18
 			});
19 19
 
20
-			$this->config->add('rank', null, function (int $rank = null) {
20
+			$this->config->add('rank', null, function(int $rank = null) {
21 21
 
22
-				return ((null !== $rank) ? ("ent.access <= " . $rank) : '');
22
+				return ((null !== $rank) ? ("ent.access <= ".$rank) : '');
23 23
 			});
24 24
 
25
-			$this->config->add('slug', '', function (string $slug) {
25
+			$this->config->add('slug', '', function(string $slug) {
26 26
 
27
-				return (('' !== $slug) ? ("ent.slug = '" . addslashes($slug) . "'") : '');
27
+				return (('' !== $slug) ? ("ent.slug = '".addslashes($slug)."'") : '');
28 28
 			});
29 29
 
30
-			$this->config->add('name', '', function (string $name) {
30
+			$this->config->add('name', '', function(string $name) {
31 31
 
32
-				return (('' !== $name) ? ("ent.name = '" . addslashes($name) . "'") : '');
32
+				return (('' !== $name) ? ("ent.name = '".addslashes($name)."'") : '');
33 33
 			});
34 34
 
35
-			$this->config->add('time_created >=', 0, function (int $time) {
35
+			$this->config->add('time_created >=', 0, function(int $time) {
36 36
 
37
-				return ((0 < $time) ? ("ent.time_created >= " . $time) : '');
37
+				return ((0 < $time) ? ("ent.time_created >= ".$time) : '');
38 38
 			});
39 39
 
40
-			$this->config->add('time_created <=', 0, function (int $time) {
40
+			$this->config->add('time_created <=', 0, function(int $time) {
41 41
 
42
-				return ((0 < $time) ? ("ent.time_created <= " . $time) : '');
42
+				return ((0 < $time) ? ("ent.time_created <= ".$time) : '');
43 43
 			});
44 44
 
45
-			$this->config->add('time_modified >=', 0, function (int $time) {
45
+			$this->config->add('time_modified >=', 0, function(int $time) {
46 46
 
47
-				return ((0 < $time) ? ("ent.time_modified >= " . $time) : '');
47
+				return ((0 < $time) ? ("ent.time_modified >= ".$time) : '');
48 48
 			});
49 49
 
50
-			$this->config->add('time_modified <=', 0, function (int $time) {
50
+			$this->config->add('time_modified <=', 0, function(int $time) {
51 51
 
52
-				return ((0 < $time) ? ("ent.time_modified <= " . $time) : '');
52
+				return ((0 < $time) ? ("ent.time_modified <= ".$time) : '');
53 53
 			});
54 54
 		}
55 55
 	}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Collection/Widgets.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->config->add('active', false, function (bool $active) {
15
+			$this->config->add('active', false, function(bool $active) {
16 16
 
17 17
 				return ($active ? "ent.active = 1" : '');
18 18
 			});
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Collection/Users.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -12,29 +12,29 @@
 block discarded – undo
12 12
 
13 13
 		protected function init() {
14 14
 
15
-			$this->config->add('rank', null, function (int $rank = null) {
15
+			$this->config->add('rank', null, function(int $rank = null) {
16 16
 
17
-				return ((null !== $rank) ? ("ent.rank >= " . $rank) : '');
17
+				return ((null !== $rank) ? ("ent.rank >= ".$rank) : '');
18 18
 			});
19 19
 
20
-			$this->config->add('time_registered >=', 0, function (int $time) {
20
+			$this->config->add('time_registered >=', 0, function(int $time) {
21 21
 
22
-				return ((0 < $time) ? ("ent.time_registered >= " . $time) : '');
22
+				return ((0 < $time) ? ("ent.time_registered >= ".$time) : '');
23 23
 			});
24 24
 
25
-			$this->config->add('time_registered <=', 0, function (int $time) {
25
+			$this->config->add('time_registered <=', 0, function(int $time) {
26 26
 
27
-				return ((0 < $time) ? ("ent.time_registered <= " . $time) : '');
27
+				return ((0 < $time) ? ("ent.time_registered <= ".$time) : '');
28 28
 			});
29 29
 
30
-			$this->config->add('time_logged >=', 0, function (int $time) {
30
+			$this->config->add('time_logged >=', 0, function(int $time) {
31 31
 
32
-				return ((0 < $time) ? ("ent.time_logged >= " . $time) : '');
32
+				return ((0 < $time) ? ("ent.time_logged >= ".$time) : '');
33 33
 			});
34 34
 
35
-			$this->config->add('time_logged <=', 0, function (int $time) {
35
+			$this->config->add('time_logged <=', 0, function(int $time) {
36 36
 
37
-				return ((0 < $time) ? ("ent.time_logged <= " . $time) : '');
37
+				return ((0 < $time) ? ("ent.time_logged <= ".$time) : '');
38 38
 			});
39 39
 		}
40 40
 	}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Entitizer.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,9 +25,13 @@
 block discarded – undo
25 25
 
26 26
 		public static function get(string $table, int $id = 0) {
27 27
 
28
-			if (!isset(self::$classes[$table])) throw new Exception\General(self::$error_message);
28
+			if (!isset(self::$classes[$table])) {
29
+				throw new Exception\General(self::$error_message);
30
+			}
29 31
 
30
-			if (isset(self::$cache[$table][$id])) return self::$cache[$table][$id];
32
+			if (isset(self::$cache[$table][$id])) {
33
+				return self::$cache[$table][$id];
34
+			}
31 35
 
32 36
 			$entity = new self::$classes[$table]; $entity->init($id);
33 37
 
Please login to merge, or discard this patch.