@@ -10,7 +10,9 @@ discard block |
||
| 10 | 10 | |
| 11 | 11 | public function __invoke(array $post) { |
| 12 | 12 | |
| 13 | - if (Auth::check()) return true; |
|
| 13 | + if (Auth::check()) { |
|
| 14 | + return true; |
|
| 15 | + } |
|
| 14 | 16 | |
| 15 | 17 | # Declare variables |
| 16 | 18 | |
@@ -22,9 +24,13 @@ discard block |
||
| 22 | 24 | |
| 23 | 25 | # Validate values |
| 24 | 26 | |
| 25 | - if (false === ($name = Validate::userName($name))) return ['name', 'USER_ERROR_NAME_INVALID']; |
|
| 27 | + if (false === ($name = Validate::userName($name))) { |
|
| 28 | + return ['name', 'USER_ERROR_NAME_INVALID']; |
|
| 29 | + } |
|
| 26 | 30 | |
| 27 | - if (false === ($password = Validate::userPassword($password))) return ['password', 'USER_ERROR_PASSWORD_INVALID']; |
|
| 31 | + if (false === ($password = Validate::userPassword($password))) { |
|
| 32 | + return ['password', 'USER_ERROR_PASSWORD_INVALID']; |
|
| 33 | + } |
|
| 28 | 34 | |
| 29 | 35 | # Create user object |
| 30 | 36 | |
@@ -32,19 +38,27 @@ discard block |
||
| 32 | 38 | |
| 33 | 39 | # Init user |
| 34 | 40 | |
| 35 | - if (!$user->init($name, 'name')) return ['name', 'USER_ERROR_NAME_INCORRECT']; |
|
| 41 | + if (!$user->init($name, 'name')) { |
|
| 42 | + return ['name', 'USER_ERROR_NAME_INCORRECT']; |
|
| 43 | + } |
|
| 36 | 44 | |
| 37 | - if (Auth::admin() && ($user->rank < RANK_ADMINISTRATOR)) return ['name', 'USER_ERROR_NAME_INCORRECT']; |
|
| 45 | + if (Auth::admin() && ($user->rank < RANK_ADMINISTRATOR)) { |
|
| 46 | + return ['name', 'USER_ERROR_NAME_INCORRECT']; |
|
| 47 | + } |
|
| 38 | 48 | |
| 39 | 49 | # Check password |
| 40 | 50 | |
| 41 | 51 | $password = Str::encode($user->auth_key, $password); |
| 42 | 52 | |
| 43 | - if (0 !== strcmp($user->password, $password)) return ['password', 'USER_ERROR_PASSWORD_INCORRECT']; |
|
| 53 | + if (0 !== strcmp($user->password, $password)) { |
|
| 54 | + return ['password', 'USER_ERROR_PASSWORD_INCORRECT']; |
|
| 55 | + } |
|
| 44 | 56 | |
| 45 | 57 | # Check access |
| 46 | 58 | |
| 47 | - if (!Auth::admin() && ($user->rank === RANK_GUEST)) return 'USER_ERROR_ACCESS'; |
|
| 59 | + if (!Auth::admin() && ($user->rank === RANK_GUEST)) { |
|
| 60 | + return 'USER_ERROR_ACCESS'; |
|
| 61 | + } |
|
| 48 | 62 | |
| 49 | 63 | # Create session |
| 50 | 64 | |
@@ -54,7 +68,9 @@ discard block |
||
| 54 | 68 | |
| 55 | 69 | $data = ['id' => $user->id, 'code' => $code, 'ip' => $ip, 'time' => $time]; |
| 56 | 70 | |
| 57 | - if (!$session->create($data)) return 'USER_ERROR_AUTH_LOGIN'; |
|
| 71 | + if (!$session->create($data)) { |
|
| 72 | + return 'USER_ERROR_AUTH_LOGIN'; |
|
| 73 | + } |
|
| 58 | 74 | |
| 59 | 75 | # Set session variable |
| 60 | 76 | |
@@ -12,9 +12,13 @@ discard block |
||
| 12 | 12 | |
| 13 | 13 | private static function getAuth(string $code, string $type, int $lifetime) { |
| 14 | 14 | |
| 15 | - if (!($auth = Entitizer::get($type))->init($code, 'code')) return false; |
|
| 15 | + if (!($auth = Entitizer::get($type))->init($code, 'code')) { |
|
| 16 | + return false; |
|
| 17 | + } |
|
| 16 | 18 | |
| 17 | - if (($auth->ip !== REQUEST_CLIENT_IP) || ($auth->time < (REQUEST_TIME - $lifetime))) return false; |
|
| 19 | + if (($auth->ip !== REQUEST_CLIENT_IP) || ($auth->time < (REQUEST_TIME - $lifetime))) { |
|
| 20 | + return false; |
|
| 21 | + } |
|
| 18 | 22 | |
| 19 | 23 | # ------------------------ |
| 20 | 24 | |
@@ -25,9 +29,13 @@ discard block |
||
| 25 | 29 | |
| 26 | 30 | private static function getUser(int $id) { |
| 27 | 31 | |
| 28 | - if (0 === ($user = Entitizer::get(TABLE_USERS, $id))->id) return false; |
|
| 32 | + if (0 === ($user = Entitizer::get(TABLE_USERS, $id))->id) { |
|
| 33 | + return false; |
|
| 34 | + } |
|
| 29 | 35 | |
| 30 | - if ($user->rank < (self::$admin ? RANK_ADMINISTRATOR : RANK_USER)) return false; |
|
| 36 | + if ($user->rank < (self::$admin ? RANK_ADMINISTRATOR : RANK_USER)) { |
|
| 37 | + return false; |
|
| 38 | + } |
|
| 31 | 39 | |
| 32 | 40 | # ------------------------ |
| 33 | 41 | |
@@ -42,17 +50,23 @@ discard block |
||
| 42 | 50 | |
| 43 | 51 | # Check session code |
| 44 | 52 | |
| 45 | - if (false === ($code = Validate::authCode(Session::get('code')))) return false; |
|
| 53 | + if (false === ($code = Validate::authCode(Session::get('code')))) { |
|
| 54 | + return false; |
|
| 55 | + } |
|
| 46 | 56 | |
| 47 | 57 | # Get auth |
| 48 | 58 | |
| 49 | 59 | $type = TABLE_USERS_SESSIONS; $lifetime = CONFIG_USER_SESSION_LIFETIME; |
| 50 | 60 | |
| 51 | - if (false === ($session = self::getAuth($code, $type, $lifetime))) return false; |
|
| 61 | + if (false === ($session = self::getAuth($code, $type, $lifetime))) { |
|
| 62 | + return false; |
|
| 63 | + } |
|
| 52 | 64 | |
| 53 | 65 | # Get user |
| 54 | 66 | |
| 55 | - if (false === ($user = self::getUser($session->id))) return false; |
|
| 67 | + if (false === ($user = self::getUser($session->id))) { |
|
| 68 | + return false; |
|
| 69 | + } |
|
| 56 | 70 | |
| 57 | 71 | # Update session |
| 58 | 72 | |
@@ -71,21 +85,29 @@ discard block |
||
| 71 | 85 | |
| 72 | 86 | public static function secret() { |
| 73 | 87 | |
| 74 | - if ((null === self::$user) || (0 !== self::$user->id)) return false; |
|
| 88 | + if ((null === self::$user) || (0 !== self::$user->id)) { |
|
| 89 | + return false; |
|
| 90 | + } |
|
| 75 | 91 | |
| 76 | 92 | # Check secret code |
| 77 | 93 | |
| 78 | - if (false === ($code = Validate::authCode(Request::get('code')))) return false; |
|
| 94 | + if (false === ($code = Validate::authCode(Request::get('code')))) { |
|
| 95 | + return false; |
|
| 96 | + } |
|
| 79 | 97 | |
| 80 | 98 | # Get auth |
| 81 | 99 | |
| 82 | 100 | $type = TABLE_USERS_SECRETS; $lifetime = CONFIG_USER_SECRET_LIFETIME; |
| 83 | 101 | |
| 84 | - if (false === ($secret = self::getAuth($code, $type, $lifetime))) return false; |
|
| 102 | + if (false === ($secret = self::getAuth($code, $type, $lifetime))) { |
|
| 103 | + return false; |
|
| 104 | + } |
|
| 85 | 105 | |
| 86 | 106 | # Get user |
| 87 | 107 | |
| 88 | - if (false === ($user = self::getUser($secret->id))) return false; |
|
| 108 | + if (false === ($user = self::getUser($secret->id))) { |
|
| 109 | + return false; |
|
| 110 | + } |
|
| 89 | 111 | |
| 90 | 112 | # ------------------------ |
| 91 | 113 | |
@@ -96,7 +118,9 @@ discard block |
||
| 96 | 118 | |
| 97 | 119 | public static function logout() { |
| 98 | 120 | |
| 99 | - if ((null === self::$user) || (0 === self::$user->id)) return false; |
|
| 121 | + if ((null === self::$user) || (0 === self::$user->id)) { |
|
| 122 | + return false; |
|
| 123 | + } |
|
| 100 | 124 | |
| 101 | 125 | # Remove session |
| 102 | 126 | |
@@ -35,11 +35,15 @@ |
||
| 35 | 35 | |
| 36 | 36 | # Check if install file exists |
| 37 | 37 | |
| 38 | - if (Informer::checkInstallFile()) Messages::set('error', Language::get('DASHBOARD_MESSAGE_INSTALL_FILE')); |
|
| 38 | + if (Informer::checkInstallFile()) { |
|
| 39 | + Messages::set('error', Language::get('DASHBOARD_MESSAGE_INSTALL_FILE')); |
|
| 40 | + } |
|
| 39 | 41 | |
| 40 | 42 | # Check if configuration file is loaded |
| 41 | 43 | |
| 42 | - if (!Settings::loaded()) Messages::set('warning', Language::get('DASHBOARD_MESSAGE_CONFIG_FILE')); |
|
| 44 | + if (!Settings::loaded()) { |
|
| 45 | + Messages::set('warning', Language::get('DASHBOARD_MESSAGE_CONFIG_FILE')); |
|
| 46 | + } |
|
| 43 | 47 | |
| 44 | 48 | # ------------------------ |
| 45 | 49 | |
@@ -47,7 +47,9 @@ discard block |
||
| 47 | 47 | |
| 48 | 48 | # Check for demo mode |
| 49 | 49 | |
| 50 | - if (Informer::isDemoMode()) return $ajax->error(Language::get('DEMO_MODE_RESTRICTION')); |
|
| 50 | + if (Informer::isDemoMode()) { |
|
| 51 | + return $ajax->error(Language::get('DEMO_MODE_RESTRICTION')); |
|
| 52 | + } |
|
| 51 | 53 | |
| 52 | 54 | # Init entity |
| 53 | 55 | |
@@ -60,7 +62,9 @@ discard block |
||
| 60 | 62 | |
| 61 | 63 | if (Request::post('action') === 'remove') { |
| 62 | 64 | |
| 63 | - if (!$this->entity->remove()) return $ajax->error(Language::get(static::$message_error_remove)); |
|
| 65 | + if (!$this->entity->remove()) { |
|
| 66 | + return $ajax->error(Language::get(static::$message_error_remove)); |
|
| 67 | + } |
|
| 64 | 68 | } |
| 65 | 69 | |
| 66 | 70 | # ------------------------ |
@@ -82,7 +86,9 @@ discard block |
||
| 82 | 86 | |
| 83 | 87 | # Handle ajax request |
| 84 | 88 | |
| 85 | - if (Request::isAjax()) return $this->handleAjax(); |
|
| 89 | + if (Request::isAjax()) { |
|
| 90 | + return $this->handleAjax(); |
|
| 91 | + } |
|
| 86 | 92 | |
| 87 | 93 | # Init entity |
| 88 | 94 | |
@@ -108,7 +114,9 @@ discard block |
||
| 108 | 114 | |
| 109 | 115 | # Display success message |
| 110 | 116 | |
| 111 | - if (false !== Request::get('submitted')) Popup::set('positive', Language::get(static::$message_success_rename)); |
|
| 117 | + if (false !== Request::get('submitted')) { |
|
| 118 | + Popup::set('positive', Language::get(static::$message_success_rename)); |
|
| 119 | + } |
|
| 112 | 120 | |
| 113 | 121 | # ------------------------ |
| 114 | 122 | |
@@ -39,7 +39,7 @@ |
||
| 39 | 39 | |
| 40 | 40 | if ((0 !== strcasecmp($this->entity->name(), $name)) && |
| 41 | 41 | |
| 42 | - @file_exists($this->entity->parent()->pathFull() . $name)) return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 42 | + @file_exists($this->entity->parent()->pathFull().$name)) return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 43 | 43 | |
| 44 | 44 | # Rename item |
| 45 | 45 | |
@@ -29,23 +29,31 @@ |
||
| 29 | 29 | |
| 30 | 30 | # Check for demo mode |
| 31 | 31 | |
| 32 | - if (Informer::isDemoMode()) return 'DEMO_MODE_RESTRICTION'; |
|
| 32 | + if (Informer::isDemoMode()) { |
|
| 33 | + return 'DEMO_MODE_RESTRICTION'; |
|
| 34 | + } |
|
| 33 | 35 | |
| 34 | 36 | # Validate name |
| 35 | 37 | |
| 36 | - if (false === ($name = Validate::fileName($name))) return ['name', 'FILEMANAGER_ERROR_NAME_INVALID']; |
|
| 38 | + if (false === ($name = Validate::fileName($name))) { |
|
| 39 | + return ['name', 'FILEMANAGER_ERROR_NAME_INVALID']; |
|
| 40 | + } |
|
| 37 | 41 | |
| 38 | 42 | # Check if item exists |
| 39 | 43 | |
| 40 | 44 | if ((0 !== strcasecmp($this->entity->name(), $name)) && |
| 41 | 45 | |
| 42 | - @file_exists($this->entity->parent()->pathFull() . $name)) return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 46 | + @file_exists($this->entity->parent()->pathFull() . $name)) { |
|
| 47 | + return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 48 | + } |
|
| 43 | 49 | |
| 44 | 50 | # Rename item |
| 45 | 51 | |
| 46 | - if (!$this->entity->rename($name)) return (($this->entity->type() === FILEMANAGER_TYPE_DIR) ? |
|
| 52 | + if (!$this->entity->rename($name)) { |
|
| 53 | + return (($this->entity->type() === FILEMANAGER_TYPE_DIR) ? |
|
| 47 | 54 | |
| 48 | 55 | 'FILEMANAGER_ERROR_DIR_RENAME' : 'FILEMANAGER_ERROR_FILE_RENAME'); |
| 56 | + } |
|
| 49 | 57 | |
| 50 | 58 | # ------------------------ |
| 51 | 59 | |
@@ -37,7 +37,7 @@ |
||
| 37 | 37 | |
| 38 | 38 | # Check if item exists |
| 39 | 39 | |
| 40 | - if (@file_exists($this->parent->pathFull() . $name)) return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 40 | + if (@file_exists($this->parent->pathFull().$name)) return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 41 | 41 | |
| 42 | 42 | # Create item |
| 43 | 43 | |
@@ -29,23 +29,31 @@ |
||
| 29 | 29 | |
| 30 | 30 | # Check for demo mode |
| 31 | 31 | |
| 32 | - if (Informer::isDemoMode()) return 'DEMO_MODE_RESTRICTION'; |
|
| 32 | + if (Informer::isDemoMode()) { |
|
| 33 | + return 'DEMO_MODE_RESTRICTION'; |
|
| 34 | + } |
|
| 33 | 35 | |
| 34 | 36 | # Validate name |
| 35 | 37 | |
| 36 | - if (false === ($name = Validate::fileName($name))) return ['name', 'FILEMANAGER_ERROR_NAME_INVALID']; |
|
| 38 | + if (false === ($name = Validate::fileName($name))) { |
|
| 39 | + return ['name', 'FILEMANAGER_ERROR_NAME_INVALID']; |
|
| 40 | + } |
|
| 37 | 41 | |
| 38 | 42 | # Check if item exists |
| 39 | 43 | |
| 40 | - if (@file_exists($this->parent->pathFull() . $name)) return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 44 | + if (@file_exists($this->parent->pathFull() . $name)) { |
|
| 45 | + return ['name', 'FILEMANAGER_ERROR_EXISTS']; |
|
| 46 | + } |
|
| 41 | 47 | |
| 42 | 48 | # Create item |
| 43 | 49 | |
| 44 | 50 | $entity = Filemanager::get($type, $this->parent); |
| 45 | 51 | |
| 46 | - if (!$entity->create($name)) return (($entity->type() === FILEMANAGER_TYPE_DIR) ? |
|
| 52 | + if (!$entity->create($name)) { |
|
| 53 | + return (($entity->type() === FILEMANAGER_TYPE_DIR) ? |
|
| 47 | 54 | |
| 48 | 55 | 'FILEMANAGER_ERROR_DIR_CREATE' : 'FILEMANAGER_ERROR_FILE_CREATE'); |
| 56 | + } |
|
| 49 | 57 | |
| 50 | 58 | # ------------------------ |
| 51 | 59 | |
@@ -19,7 +19,9 @@ |
||
| 19 | 19 | |
| 20 | 20 | public function add(string $name, string $type = null) { |
| 21 | 21 | |
| 22 | - if (!isset($this->definition->params()[$name]) || isset($this->list[$name])) return; |
|
| 22 | + if (!isset($this->definition->params()[$name]) || isset($this->list[$name])) { |
|
| 23 | + return; |
|
| 24 | + } |
|
| 23 | 25 | |
| 24 | 26 | $this->list[$name] = new Definition\Item\Index($name, $type); |
| 25 | 27 | } |
@@ -19,11 +19,15 @@ |
||
| 19 | 19 | |
| 20 | 20 | private function add(string $type, string $name, array $args) { |
| 21 | 21 | |
| 22 | - if (('' === $name) || isset($this->list[$name])) return; |
|
| 22 | + if (('' === $name) || isset($this->list[$name])) { |
|
| 23 | + return; |
|
| 24 | + } |
|
| 23 | 25 | |
| 24 | 26 | $this->list[$name] = new $this->types[$type](...$args); |
| 25 | 27 | |
| 26 | - if (($type !== 'textual') || $this->list[$name]->short) $this->secure[] = $name; |
|
| 28 | + if (($type !== 'textual') || $this->list[$name]->short) { |
|
| 29 | + $this->secure[] = $name; |
|
| 30 | + } |
|
| 27 | 31 | } |
| 28 | 32 | |
| 29 | 33 | # Constructor |
@@ -32,11 +32,11 @@ |
||
| 32 | 32 | |
| 33 | 33 | public function statement() { |
| 34 | 34 | |
| 35 | - return ("FOREIGN KEY (`" . $this->name . "`) REFERENCES `" . $this->table . "` (`" . $this->field . "`)") . |
|
| 35 | + return ("FOREIGN KEY (`".$this->name."`) REFERENCES `".$this->table."` (`".$this->field."`)"). |
|
| 36 | 36 | |
| 37 | - ((null !== $this->delete) ? (" ON DELETE " . $this->delete) : "") . |
|
| 37 | + ((null !== $this->delete) ? (" ON DELETE ".$this->delete) : ""). |
|
| 38 | 38 | |
| 39 | - ((null !== $this->update) ? (" ON UPDATE " . $this->update) : ""); |
|
| 39 | + ((null !== $this->update) ? (" ON UPDATE ".$this->update) : ""); |
|
| 40 | 40 | } |
| 41 | 41 | } |
| 42 | 42 | } |
@@ -23,9 +23,13 @@ |
||
| 23 | 23 | |
| 24 | 24 | $this->name = $name; $this->table = $table; $this->field = $field; |
| 25 | 25 | |
| 26 | - if (null !== $delete) $this->delete = $this->getAction($delete); |
|
| 26 | + if (null !== $delete) { |
|
| 27 | + $this->delete = $this->getAction($delete); |
|
| 28 | + } |
|
| 27 | 29 | |
| 28 | - if (null !== $update) $this->update = $this->getAction($delete); |
|
| 30 | + if (null !== $update) { |
|
| 31 | + $this->update = $this->getAction($delete); |
|
| 32 | + } |
|
| 29 | 33 | } |
| 30 | 34 | |
| 31 | 35 | # Get statement |