Upload::handle() - Code Metrics - Inspection of "Merge branch 0.4.2 (#14)" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c7e98d...e0d6a2 )

by Anton

created 2016-12-08 21:01 UTC

Upload::handle() B

↳ Parent: Upload

Complexity

Conditions	5
Paths	5

Size

Total Lines	31
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	31
rs	8.439
c	0
b	0
f	0
cc	5
eloc	11
nc	5
nop	0

<?php

namespace Modules\Filemanager\Handler {

	use Frames, Utils\Uploader, Ajax, Language, Request;

	class Upload extends Frames\Admin\Area\Authorized {

		# Handle request

		protected function handle() {

			if (!Request::isAjax()) return false;

			# Create response

			$ajax = Ajax::createResponse();

			# Get target directory

			$target_dir = ((Request::get('type') === 'image') ? 'data/images/' : 'data/');

			# Save uploaded file

			if (true === ($upload = (Uploader::save('upload', (DIR_UPLOADS . $target_dir))))) {

				$base_name = Uploader::baseName(); $url = (INSTALL_PATH . '/uploads/' . $target_dir . $base_name);

				$ajax->set('uploaded', 1)->set('fileName', $base_name)->set('url', $url);

			} else {

				$message = Language::get((false !== $upload) ? $upload : 'UPLOADER_ERROR_UNKNOWN');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

				$ajax->set('uploaded', 0)->setError(['message' => $message]);
			}

			# ------------------------

			return $ajax;
		}
	}
}


1			<?php
2
3			namespace Modules\Filemanager\Handler {
4
5			use Frames, Utils\Uploader, Ajax, Language, Request;
6
7			class Upload extends Frames\Admin\Area\Authorized {
8
9			# Handle request
10
11			protected function handle() {
12
13			if (!Request::isAjax()) return false;
14
15			# Create response
16
17			$ajax = Ajax::createResponse();
18
19			# Get target directory
20
21			$target_dir = ((Request::get('type') === 'image') ? 'data/images/' : 'data/');
22
23			# Save uploaded file
24
25			if (true === ($upload = (Uploader::save('upload', (DIR_UPLOADS . $target_dir))))) {
26
27			$base_name = Uploader::baseName(); $url = (INSTALL_PATH . '/uploads/' . $target_dir . $base_name);
28
29			$ajax->set('uploaded', 1)->set('fileName', $base_name)->set('url', $url);
30
31			} else {
32
33			$message = Language::get((false !== $upload) ? $upload : 'UPLOADER_ERROR_UNKNOWN');
			0 ignored issues – show Bug introduced 2016-12-08 21:02 UTC by Report Bug Copy Issue Report It seems like `false !== $upload ? $upl...UPLOADER_ERROR_UNKNOWN'` can also be of type `boolean`; however, `Language::get()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34
35			$ajax->set('uploaded', 0)->setError(['message' => $message]);
36			}
37
38			# ------------------------
39
40			return $ajax;
41			}
42			}
43			}
44

cadmium-org / cadmium-cms

Push — master ( c7e98d...e0d6a2 )

Upload::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like