Entity - Code Metrics - Inspection of "Entitizer module optimizations" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 0.3.0 ( 0d73f1...9a02d7 )

by Anton

created 2016-04-21 22:53 UTC

Entity A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	157
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	23
c	1
b	0
f	0
lcom	1
cbo	5
dl	0
loc	157
rs	10

10 Methods

Rating	Name	Size	Complexity
A	selectDefault()	6	1
A	selectNesting()	22	2
A	setData()	23	2
A	__construct()	10	1
C	init()	22	8
B	check()	22	5
A	definition()	4	1
A	data()	4	1
A	get()	4	1
A	__get()	4	1

<?php

namespace Modules\Entitizer\Utils {

	use Modules\Entitizer, DB;

	abstract class Entity extends Cache {

		use Entity\Collection, Entity\Modify;

		protected $definition = null, $dataset = null;

		# Select default entity from DB

		private function selectDefault(string $name, string $value) {

			$selection = array_keys($this->definition->params());

			return DB::select(static::$table, $selection, [$name => $value], null, 1);
		}

		# Select nesting entity from DB

		private function selectNesting(string $name, string $value) {

			# Process selection

			$selection = array_keys($this->definition->params());

			foreach ($selection as $key => $field) $selection[$key] = ('ent.' . $field);

			# Process query

			$query = ("SELECT " . implode(', ', $selection) .", rel.ancestor as parent_id ") .

			         ("FROM " . static::$table . " ent ") .

			         ("LEFT JOIN " . static::$table_relations . " rel ON rel.descendant = ent.id AND rel.depth = 1 ") .

			         ("WHERE ent." . $name . " = '" . addslashes($value) . "' LIMIT 1");

			# ------------------------

			return DB::send($query);
		}

		# Set selected data

		protected function setData(array $data) {

			$id = $this->definition->param('id')->cast($data['id']);

			# Import data

			if (isset(self::$cache[static::$table][$id])) {

				$this->dataset = self::$cache[static::$table][$id]->dataset;
			}

			# Update data

			$this->dataset->update($data);

			# Cache entity

			self::$cache[static::$table][$this->id] = $this;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			# ------------------------

			return true;
		}

		# Constructor

		public function __construct() {

			# Get definition

			$this->definition = Entitizer::definition(static::$table);

			# Preset data

			$this->dataset = Entitizer::dataset(static::$table);
		}

		# Init entity

		public function init($value, string $name = 'id') {

			if (0 !== $this->id) return false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			# Get initiation index

			if (false === ($index = $this->definition->index($name))) return false;

			if (($index->type !== 'PRIMARY') && ($index->type !== 'UNIQUE')) return false;

			# Process name & value

			$name = $index->name; $value = $this->definition->param($name)->cast($value);

			# Select entity from DB

			if (!static::$nesting) $this->selectDefault($name, $value); else $this->selectNesting($name, $value);

			# ------------------------

			return ((DB::last() && (DB::last()->rows === 1)) ? $this->setData(DB::last()->row()) : false);
		}

		# Check if unique param value exists

		public function check($value, string $name) {

			# Get initiation index

			if (false === ($index = $this->definition->index($name))) return false;

			if ($index->type !== 'UNIQUE') return false;

			# Process name & value

			$name = $index->name; $value = $this->definition->param($name)->cast($value);

			# Select entity from DB

			$condition = ($name . " = '" . addslashes($value) . "' AND id != " . $this->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			DB::select(static::$table, 'id', $condition, null, 1);

			# ------------------------

			return ((DB::last() && DB::last()->status) ? DB::last()->rows : false);
		}

		# Return definition

		public function definition() {

			return $this->definition;
		}

		# Return data

		public function data() {

			return $this->dataset->data();
		}

		# Return param value

		public function get(string $name) {

			return $this->dataset->get($name);
		}

		# Getter

		public function __get(string $name) {

			return $this->dataset->get($name);
		}
	}
}


1			<?php
2
3			namespace Modules\Entitizer\Utils {
4
5			use Modules\Entitizer, DB;
6
7			abstract class Entity extends Cache {
8
9			use Entity\Collection, Entity\Modify;
10
11			protected $definition = null, $dataset = null;
12
13			# Select default entity from DB
14
15			private function selectDefault(string $name, string $value) {
16
17			$selection = array_keys($this->definition->params());
18
19			return DB::select(static::$table, $selection, [$name => $value], null, 1);
20			}
21
22			# Select nesting entity from DB
23
24			private function selectNesting(string $name, string $value) {
25
26			# Process selection
27
28			$selection = array_keys($this->definition->params());
29
30			foreach ($selection as $key => $field) $selection[$key] = ('ent.' . $field);
31
32			# Process query
33
34			$query = ("SELECT " . implode(', ', $selection) .", rel.ancestor as parent_id ") .
35
36			("FROM " . static::$table . " ent ") .
37
38			("LEFT JOIN " . static::$table_relations . " rel ON rel.descendant = ent.id AND rel.depth = 1 ") .
39
40			("WHERE ent." . $name . " = '" . addslashes($value) . "' LIMIT 1");
41
42			# ------------------------
43
44			return DB::send($query);
45			}
46
47			# Set selected data
48
49			protected function setData(array $data) {
50
51			$id = $this->definition->param('id')->cast($data['id']);
52
53			# Import data
54
55			if (isset(self::$cache[static::$table][$id])) {
56
57			$this->dataset = self::$cache[static::$table][$id]->dataset;
58			}
59
60			# Update data
61
62			$this->dataset->update($data);
63
64			# Cache entity
65
66			self::$cache[static::$table][$this->id] = $this;
			0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
67
68			# ------------------------
69
70			return true;
71			}
72
73			# Constructor
74
75			public function __construct() {
76
77			# Get definition
78
79			$this->definition = Entitizer::definition(static::$table);
80
81			# Preset data
82
83			$this->dataset = Entitizer::dataset(static::$table);
84			}
85
86			# Init entity
87
88			public function init($value, string $name = 'id') {
89
90			if (0 !== $this->id) return false;
			0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
91
92			# Get initiation index
93
94			if (false === ($index = $this->definition->index($name))) return false;
95
96			if (($index->type !== 'PRIMARY') && ($index->type !== 'UNIQUE')) return false;
97
98			# Process name & value
99
100			$name = $index->name; $value = $this->definition->param($name)->cast($value);
101
102			# Select entity from DB
103
104			if (!static::$nesting) $this->selectDefault($name, $value); else $this->selectNesting($name, $value);
105
106			# ------------------------
107
108			return ((DB::last() && (DB::last()->rows === 1)) ? $this->setData(DB::last()->row()) : false);
109			}
110
111			# Check if unique param value exists
112
113			public function check($value, string $name) {
114
115			# Get initiation index
116
117			if (false === ($index = $this->definition->index($name))) return false;
118
119			if ($index->type !== 'UNIQUE') return false;
120
121			# Process name & value
122
123			$name = $index->name; $value = $this->definition->param($name)->cast($value);
124
125			# Select entity from DB
126
127			$condition = ($name . " = '" . addslashes($value) . "' AND id != " . $this->id);
			0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
128
129			DB::select(static::$table, 'id', $condition, null, 1);
130
131			# ------------------------
132
133			return ((DB::last() && DB::last()->status) ? DB::last()->rows : false);
134			}
135
136			# Return definition
137
138			public function definition() {
139
140			return $this->definition;
141			}
142
143			# Return data
144
145			public function data() {
146
147			return $this->dataset->data();
148			}
149
150			# Return param value
151
152			public function get(string $name) {
153
154			return $this->dataset->get($name);
155			}
156
157			# Getter
158
159			public function __get(string $name) {
160
161			return $this->dataset->get($name);
162			}
163			}
164			}
165

cadmium-org / cadmium-cms

Push — 0.3.0 ( 0d73f1...9a02d7 )

Entity A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

Duplication Side-by-Side

Filter issues like