Page - Code Metrics - Inspection of "Merge pull request #11 from cadmium-org/0.4.0" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a357e7...195a07 )

by Anton

created 2016-11-18 15:24 UTC

Page A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	7.5 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	3
dl	3
loc	40
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processEntityParent()	3	6	3
A	processEntity()	0	4	3

How to fix Duplicated Code

<?php

namespace Modules\Entitizer\Handler\Edit {

	use Modules\Entitizer, Template;

	class Page extends Entitizer\Utils\Handler {

		use Entitizer\Common\Page;

		protected $title = 'TITLE_CONTENT_PAGES_EDIT';

		# Handler configuration

		protected static $controller = 'Modules\Entitizer\Controller\Page';

		protected static $link = '/admin/content/pages';

		protected static $naming = 'title', $naming_new = '';

		protected static $form_class = 'Modules\Entitizer\Form\Page';

		protected static $message_success_save = 'PAGE_SUCCESS_SAVE';

		protected static $message_error_move = 'PAGE_ERROR_MOVE';

		protected static $message_error_remove = 'PAGE_ERROR_REMOVE';

		protected static $view = 'Blocks/Entitizer/Pages/Main';

		# Add parent additional data

		protected function processEntityParent(Template\Block $parent) {

			if ((0 !== $this->parent->id) && $this->parent->active) $parent->getBlock('browse')->link = $this->parent->link;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			else { $parent->getBlock('browse')->disable(); $parent->getBlock('browse_disabled')->enable(); }
		}

		# Add additional parent data for specific entity

		protected function processEntity(Template\Block $contents) {

			if (!$this->create && $this->parent->locked) $contents->getBlock('locked')->enable();
		}
	}
}


1		<?php
2
3		namespace Modules\Entitizer\Handler\Edit {
4
5		use Modules\Entitizer, Template;
6
7		class Page extends Entitizer\Utils\Handler {
8
9		use Entitizer\Common\Page;
10
11		protected $title = 'TITLE_CONTENT_PAGES_EDIT';
12
13		# Handler configuration
14
15		protected static $controller = 'Modules\Entitizer\Controller\Page';
16
17		protected static $link = '/admin/content/pages';
18
19		protected static $naming = 'title', $naming_new = '';
20
21		protected static $form_class = 'Modules\Entitizer\Form\Page';
22
23		protected static $message_success_save = 'PAGE_SUCCESS_SAVE';
24
25		protected static $message_error_move = 'PAGE_ERROR_MOVE';
26
27		protected static $message_error_remove = 'PAGE_ERROR_REMOVE';
28
29		protected static $view = 'Blocks/Entitizer/Pages/Main';
30
31		# Add parent additional data
32
33		protected function processEntityParent(Template\Block $parent) {
34
35	View Code Duplication	if ((0 !== $this->parent->id) && $this->parent->active) $parent->getBlock('browse')->link = $this->parent->link;
		0 ignored issues – show Duplication introduced 2016-11-14 22:52 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Documentation introduced 2016-11-17 00:07 UTC by Report Bug Copy Issue Report The property `link` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36
37		else { $parent->getBlock('browse')->disable(); $parent->getBlock('browse_disabled')->enable(); }
38		}
39
40		# Add additional parent data for specific entity
41
42		protected function processEntity(Template\Block $contents) {
43
44		if (!$this->create && $this->parent->locked) $contents->getBlock('locked')->enable();
45		}
46		}
47		}
48

cadmium-org / cadmium-cms

Push — master ( a357e7...195a07 )

Page A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like