Conditions | 22 |
Paths | 18 |
Total Lines | 75 |
Code Lines | 22 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
75 | public static function set(string $name, $value) { |
||
76 | |||
77 | if (!isset(self::$settings[$name])) return false; |
||
78 | |||
79 | # Validate language |
||
80 | |||
81 | if (($name === 'admin_language') || ($name === 'site_language')) { |
||
82 | |||
83 | if (false === ($value = Extend\Languages::validate($value))) return false; |
||
84 | } |
||
85 | |||
86 | # Validate template |
||
87 | |||
88 | else if (($name === 'admin_template') || ($name === 'site_template')) { |
||
89 | |||
90 | if (false === ($value = Extend\Templates::validate($value))) return false; |
||
91 | } |
||
92 | |||
93 | # Validate site title |
||
94 | |||
95 | else if ($name === 'site_title') { |
||
96 | |||
97 | if ('' === ($value = (function(string $value) { return $value; })($value))) return false; |
||
98 | } |
||
99 | |||
100 | # Validate site status |
||
101 | |||
102 | else if ($name === 'site_status') { |
||
103 | |||
104 | if (false === ($value = Lister\Status::validate($value))) return false; |
||
105 | } |
||
106 | |||
107 | # Validate site slogan/description/keywords |
||
108 | |||
109 | else if (($name === 'site_slogan') || ($name === 'site_description') || ($name === 'site_keywords')) { |
||
110 | |||
111 | $value = (function(string $value) { return $value; })($value); |
||
112 | } |
||
113 | |||
114 | # Validate system url |
||
115 | |||
116 | else if ($name === 'system_url') { |
||
117 | |||
118 | if (false === ($value = Validate::url($value))) return false; |
||
119 | } |
||
120 | |||
121 | # Validate system email |
||
122 | |||
123 | else if ($name === 'system_email') { |
||
124 | |||
125 | if (false === ($value = Validate::email($value))) return false; |
||
126 | } |
||
127 | |||
128 | # Validate system timezone |
||
129 | |||
130 | else if ($name === 'system_timezone') { |
||
131 | |||
132 | if (false === ($value = Timezone::validate($value))) return false; |
||
133 | } |
||
134 | |||
135 | # Validate users registration |
||
136 | |||
137 | else if ($name === 'users_registration') { |
||
138 | |||
139 | $value = (function(bool $value) { return $value; })($value); |
||
140 | } |
||
141 | |||
142 | # Set value |
||
143 | |||
144 | self::$settings[$name] = $value; |
||
145 | |||
146 | # ------------------------ |
||
147 | |||
148 | return true; |
||
149 | } |
||
150 | |||
161 |