Completed
Push — master ( 92ad6f...416cb1 )
by Anton
19:38
created
www/engine/System/Classes/Modules/Profile/Controller/Personal.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,13 +20,19 @@  discard block
 block discarded – undo
20 20
 
21 21
 			# Validate values
22 22
 
23
-			if (false === ($email = Validate::email($email))) return 'USER_ERROR_EMAIL_INVALID';
23
+			if (false === ($email = Validate::email($email))) {
24
+				return 'USER_ERROR_EMAIL_INVALID';
25
+			}
24 26
 
25 27
 			# Check email exists
26 28
 
27
-			if (false === ($check_email = Auth::user()->check('email', $email))) return 'USER_ERROR_EDIT_PERSONAL';
29
+			if (false === ($check_email = Auth::user()->check('email', $email))) {
30
+				return 'USER_ERROR_EDIT_PERSONAL';
31
+			}
28 32
 
29
-			if ($check_email === 1) return 'USER_ERROR_EMAIL_DUPLICATE';
33
+			if ($check_email === 1) {
34
+				return 'USER_ERROR_EMAIL_DUPLICATE';
35
+			}
30 36
 
31 37
 			# Update user
32 38
 
@@ -40,7 +46,9 @@  discard block
 block discarded – undo
40 46
 			$data['country']            = $country;
41 47
 			$data['timezone']           = $timezone;
42 48
 
43
-			if (!Auth::user()->edit($data)) return 'USER_ERROR_EDIT_PERSONAL';
49
+			if (!Auth::user()->edit($data)) {
50
+				return 'USER_ERROR_EDIT_PERSONAL';
51
+			}
44 52
 
45 53
 			# ------------------------
46 54
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Profile/Controller/Password.php 1 patch
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,17 +20,25 @@  discard block
 block discarded – undo
20 20
 
21 21
 			# Validate values
22 22
 
23
-			if (false === ($password = Auth\Validate::userPassword($password))) return 'USER_ERROR_PASSWORD_INVALID';
23
+			if (false === ($password = Auth\Validate::userPassword($password))) {
24
+				return 'USER_ERROR_PASSWORD_INVALID';
25
+			}
24 26
 
25
-			if (false === ($password_new = Auth\Validate::userPassword($password_new))) return 'USER_ERROR_PASSWORD_NEW_INVALID';
27
+			if (false === ($password_new = Auth\Validate::userPassword($password_new))) {
28
+				return 'USER_ERROR_PASSWORD_NEW_INVALID';
29
+			}
26 30
 
27
-			if (0 !== strcmp($password_new, $password_retype)) return 'USER_ERROR_PASSWORD_MISMATCH';
31
+			if (0 !== strcmp($password_new, $password_retype)) {
32
+				return 'USER_ERROR_PASSWORD_MISMATCH';
33
+			}
28 34
 
29 35
 			# Check password
30 36
 
31 37
 			$password = Str::encode(Auth::user()->auth_key, $password);
32 38
 
33
-			if (0 !== strcmp(Auth::user()->password, $password)) return 'USER_ERROR_PASSWORD_INCORRECT';
39
+			if (0 !== strcmp(Auth::user()->password, $password)) {
40
+				return 'USER_ERROR_PASSWORD_INCORRECT';
41
+			}
34 42
 
35 43
 			# Encode password
36 44
 
@@ -43,7 +51,9 @@  discard block
 block discarded – undo
43 51
 			$data['auth_key']           = $auth_key;
44 52
 			$data['password']           = $password;
45 53
 
46
-			if (!Auth::user()->edit($data)) return 'USER_ERROR_EDIT_PASSWORD';
54
+			if (!Auth::user()->edit($data)) {
55
+				return 'USER_ERROR_EDIT_PASSWORD';
56
+			}
47 57
 
48 58
 			# ------------------------
49 59
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Profile/Handler/Overview.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,14 +30,18 @@
 block discarded – undo
30 30
 
31 31
 			foreach (['full_name', 'city'] as $name) {
32 32
 
33
-				if ('' === ($text = Auth::user()->$name)) $contents->block($name)->disable();
34
-
35
-				else $contents->block($name)->text = $text;
33
+				if ('' === ($text = Auth::user()->$name)) {
34
+					$contents->block($name)->disable();
35
+				} else {
36
+					$contents->block($name)->text = $text;
37
+				}
36 38
 			}
37 39
 
38 40
 			# Set country
39 41
 
40
-			if ('' === ($country = Auth::user()->country)) $contents->block('country')->disable(); else {
42
+			if ('' === ($country = Auth::user()->country)) {
43
+				$contents->block('country')->disable();
44
+			} else {
41 45
 
42 46
 				$contents->block('country')->code = $country;
43 47
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Profile/Handler/Edit.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,9 @@
 block discarded – undo
50 50
 
51 51
 			# Display success message
52 52
 
53
-			if (false !== Request::get('submitted')) Messages::success(Language::get('USER_SUCCESS_EDIT'));
53
+			if (false !== Request::get('submitted')) {
54
+				Messages::success(Language::get('USER_SUCCESS_EDIT'));
55
+			}
54 56
 
55 57
 			# ------------------------
56 58
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Controller/Login.php 1 patch
Braces   +24 added lines, -8 removed lines patch added patch discarded remove patch
@@ -10,7 +10,9 @@  discard block
 block discarded – undo
10 10
 
11 11
 		public function __invoke(array $post) {
12 12
 
13
-			if (Auth::check()) return true;
13
+			if (Auth::check()) {
14
+				return true;
15
+			}
14 16
 
15 17
 			# Declare variables
16 18
 
@@ -22,9 +24,13 @@  discard block
 block discarded – undo
22 24
 
23 25
 			# Validate values
24 26
 
25
-			if (false === ($name = Auth\Validate::userName($name))) return 'USER_ERROR_NAME_INVALID';
27
+			if (false === ($name = Auth\Validate::userName($name))) {
28
+				return 'USER_ERROR_NAME_INVALID';
29
+			}
26 30
 
27
-			if (false === ($password = Auth\Validate::userPassword($password))) return 'USER_ERROR_PASSWORD_INVALID';
31
+			if (false === ($password = Auth\Validate::userPassword($password))) {
32
+				return 'USER_ERROR_PASSWORD_INVALID';
33
+			}
28 34
 
29 35
 			# Create user object
30 36
 
@@ -32,19 +38,27 @@  discard block
 block discarded – undo
32 38
 
33 39
 			# Init user
34 40
 
35
-			if (!$user->init($name, 'name')) return 'USER_ERROR_NAME_INCORRECT';
41
+			if (!$user->init($name, 'name')) {
42
+				return 'USER_ERROR_NAME_INCORRECT';
43
+			}
36 44
 
37
-			if (Auth::admin() && ($user->rank < RANK_ADMINISTRATOR)) return 'USER_ERROR_NAME_INCORRECT';
45
+			if (Auth::admin() && ($user->rank < RANK_ADMINISTRATOR)) {
46
+				return 'USER_ERROR_NAME_INCORRECT';
47
+			}
38 48
 
39 49
 			# Check password
40 50
 
41 51
 			$password = Str::encode($user->auth_key, $password);
42 52
 
43
-			if (0 !== strcmp($user->password, $password)) return 'USER_ERROR_PASSWORD_INCORRECT';
53
+			if (0 !== strcmp($user->password, $password)) {
54
+				return 'USER_ERROR_PASSWORD_INCORRECT';
55
+			}
44 56
 
45 57
 			# Check access
46 58
 
47
-			if (!Auth::admin() && ($user->rank === RANK_GUEST)) return 'USER_ERROR_ACCESS';
59
+			if (!Auth::admin() && ($user->rank === RANK_GUEST)) {
60
+				return 'USER_ERROR_ACCESS';
61
+			}
48 62
 
49 63
 			# Create session
50 64
 
@@ -54,7 +68,9 @@  discard block
 block discarded – undo
54 68
 
55 69
 			$data = ['id' => $user->id, 'code' => $code, 'ip' => $ip, 'time' => $time];
56 70
 
57
-			if (!$session->create($data)) return 'USER_ERROR_AUTH_LOGIN';
71
+			if (!$session->create($data)) {
72
+				return 'USER_ERROR_AUTH_LOGIN';
73
+			}
58 74
 
59 75
 			# Set session variable
60 76
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Controller/Register.php 1 patch
Braces   +33 added lines, -11 removed lines patch added patch discarded remove patch
@@ -10,7 +10,9 @@  discard block
 block discarded – undo
10 10
 
11 11
 		public function __invoke(array $post) {
12 12
 
13
-			if (Auth::check()) return true;
13
+			if (Auth::check()) {
14
+				return true;
15
+			}
14 16
 
15 17
 			# Declare variables
16 18
 
@@ -22,15 +24,25 @@  discard block
 block discarded – undo
22 24
 
23 25
 			# Validate values
24 26
 
25
-			if (false === ($name = Auth\Validate::userName($name))) return 'USER_ERROR_NAME_INVALID';
27
+			if (false === ($name = Auth\Validate::userName($name))) {
28
+				return 'USER_ERROR_NAME_INVALID';
29
+			}
26 30
 
27
-			if (false === ($password = Auth\Validate::userPassword($password))) return 'USER_ERROR_PASSWORD_INVALID';
31
+			if (false === ($password = Auth\Validate::userPassword($password))) {
32
+				return 'USER_ERROR_PASSWORD_INVALID';
33
+			}
28 34
 
29
-			if (false === ($email = Validate::email($email))) return 'USER_ERROR_EMAIL_INVALID';
35
+			if (false === ($email = Validate::email($email))) {
36
+				return 'USER_ERROR_EMAIL_INVALID';
37
+			}
30 38
 
31
-			if (0 !== strcmp($password, $password_retype)) return 'USER_ERROR_PASSWORD_MISMATCH';
39
+			if (0 !== strcmp($password, $password_retype)) {
40
+				return 'USER_ERROR_PASSWORD_MISMATCH';
41
+			}
32 42
 
33
-			if (false === Security::checkCaptcha($captcha)) return 'USER_ERROR_CAPTCHA_INCORRECT';
43
+			if (false === Security::checkCaptcha($captcha)) {
44
+				return 'USER_ERROR_CAPTCHA_INCORRECT';
45
+			}
34 46
 
35 47
 			# Create user object
36 48
 
@@ -38,15 +50,23 @@  discard block
 block discarded – undo
38 50
 
39 51
 			# Check name exists
40 52
 
41
-			if (false === ($check_name = $user->check('name', $name))) return 'USER_ERROR_AUTH_REGISTER';
53
+			if (false === ($check_name = $user->check('name', $name))) {
54
+				return 'USER_ERROR_AUTH_REGISTER';
55
+			}
42 56
 
43
-			if ($check_name === 1) return 'USER_ERROR_NAME_DUPLICATE';
57
+			if ($check_name === 1) {
58
+				return 'USER_ERROR_NAME_DUPLICATE';
59
+			}
44 60
 
45 61
 			# Check email exists
46 62
 
47
-			if (false === ($check_email = $user->check('email', $email))) return 'USER_ERROR_AUTH_REGISTER';
63
+			if (false === ($check_email = $user->check('email', $email))) {
64
+				return 'USER_ERROR_AUTH_REGISTER';
65
+			}
48 66
 
49
-			if ($check_email === 1) return 'USER_ERROR_EMAIL_DUPLICATE';
67
+			if ($check_email === 1) {
68
+				return 'USER_ERROR_EMAIL_DUPLICATE';
69
+			}
50 70
 
51 71
 			# Encode password
52 72
 
@@ -69,7 +89,9 @@  discard block
 block discarded – undo
69 89
 			$data['time_registered']    = REQUEST_TIME;
70 90
 			$data['time_logged']        = REQUEST_TIME;
71 91
 
72
-			if (!$user->create($data)) return 'USER_ERROR_AUTH_REGISTER';
92
+			if (!$user->create($data)) {
93
+				return 'USER_ERROR_AUTH_REGISTER';
94
+			}
73 95
 
74 96
 			# Send mail
75 97
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Controller/Recover.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,7 +10,9 @@  discard block
 block discarded – undo
10 10
 
11 11
 		public function __invoke(array $post) {
12 12
 
13
-			if (!Auth::check()) return false;
13
+			if (!Auth::check()) {
14
+				return false;
15
+			}
14 16
 
15 17
 			# Declare variables
16 18
 
@@ -22,9 +24,13 @@  discard block
 block discarded – undo
22 24
 
23 25
 			# Validate values
24 26
 
25
-			if (false === ($password_new = Auth\Validate::userPassword($password_new))) return 'USER_ERROR_PASSWORD_NEW_INVALID';
27
+			if (false === ($password_new = Auth\Validate::userPassword($password_new))) {
28
+				return 'USER_ERROR_PASSWORD_NEW_INVALID';
29
+			}
26 30
 
27
-			if (0 !== strcmp($password_new, $password_retype)) return 'USER_ERROR_PASSWORD_MISMATCH';
31
+			if (0 !== strcmp($password_new, $password_retype)) {
32
+				return 'USER_ERROR_PASSWORD_MISMATCH';
33
+			}
28 34
 
29 35
 			# Encode password
30 36
 
@@ -34,7 +40,9 @@  discard block
 block discarded – undo
34 40
 
35 41
 			$data = ['auth_key' => $auth_key, 'password' => $password];
36 42
 
37
-			if (!Auth::user()->edit($data)) return 'USER_ERROR_AUTH_RECOVER';
43
+			if (!Auth::user()->edit($data)) {
44
+				return 'USER_ERROR_AUTH_RECOVER';
45
+			}
38 46
 
39 47
 			# Remove secret
40 48
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Controller/Reset.php 1 patch
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -10,7 +10,9 @@  discard block
 block discarded – undo
10 10
 
11 11
 		public function __invoke(array $post) {
12 12
 
13
-			if (Auth::check()) return true;
13
+			if (Auth::check()) {
14
+				return true;
15
+			}
14 16
 
15 17
 			# Declare variables
16 18
 
@@ -22,9 +24,13 @@  discard block
 block discarded – undo
22 24
 
23 25
 			# Validate values
24 26
 
25
-			if (false === ($name = Auth\Validate::userName($name))) return 'USER_ERROR_NAME_INVALID';
27
+			if (false === ($name = Auth\Validate::userName($name))) {
28
+				return 'USER_ERROR_NAME_INVALID';
29
+			}
26 30
 
27
-			if (false === Security::checkCaptcha($captcha)) return 'USER_ERROR_CAPTCHA_INCORRECT';
31
+			if (false === Security::checkCaptcha($captcha)) {
32
+				return 'USER_ERROR_CAPTCHA_INCORRECT';
33
+			}
28 34
 
29 35
 			# Create user object
30 36
 
@@ -32,13 +38,19 @@  discard block
 block discarded – undo
32 38
 
33 39
 			# Init user
34 40
 
35
-			if (!$user->init($name, 'name')) return 'USER_ERROR_NAME_INCORRECT';
41
+			if (!$user->init($name, 'name')) {
42
+				return 'USER_ERROR_NAME_INCORRECT';
43
+			}
36 44
 
37
-			if (Auth::admin() && ($user->rank < RANK_ADMINISTRATOR)) return 'USER_ERROR_NAME_INCORRECT';
45
+			if (Auth::admin() && ($user->rank < RANK_ADMINISTRATOR)) {
46
+				return 'USER_ERROR_NAME_INCORRECT';
47
+			}
38 48
 
39 49
 			# Check access
40 50
 
41
-			if (!Auth::admin() && ($user->rank === RANK_GUEST)) return 'USER_ERROR_ACCESS';
51
+			if (!Auth::admin() && ($user->rank === RANK_GUEST)) {
52
+				return 'USER_ERROR_ACCESS';
53
+			}
42 54
 
43 55
 			# Create session
44 56
 
@@ -48,7 +60,9 @@  discard block
 block discarded – undo
48 60
 
49 61
 			$data = ['id' => $user->id, 'code' => $code, 'ip' => $ip, 'time' => $time];
50 62
 
51
-			if (!$secret->create($data)) return 'USER_ERROR_AUTH_RESET';
63
+			if (!$secret->create($data)) {
64
+				return 'USER_ERROR_AUTH_RESET';
65
+			}
52 66
 
53 67
 			# Send mail
54 68
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Handler/Recover.php 1 patch
Braces   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -14,9 +14,11 @@
 block discarded – undo
14 14
 
15 15
 			# Init user by secret code
16 16
 
17
-			if (false !== ($code = Auth::secret())) $this->code = $code;
18
-
19
-			else Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/reset');
17
+			if (false !== ($code = Auth::secret())) {
18
+				$this->code = $code;
19
+			} else {
20
+				Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/reset');
21
+			}
20 22
 
21 23
 			# Create form
22 24
 
Please login to merge, or discard this patch.