Inspection of "Move classes to separate directory" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 0.2.1 ( e70612...dab97b )

by Anton

created 2016-01-06 19:57 UTC

Status

Unused Use Statements +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,8 @@
 block discarded – undo
 
 namespace Modules\Entitizer\Listview {
 
-	use Modules\Entitizer, Template;
+	use Modules\Entitizer;
+	use Template;
 
 	class Variables extends Entitizer\Utils\Listview {
 

Please login to merge, or discard this patch.

www/engine/System/Classes/Modules/Entitizer/Listview/Widgets.php 1 patch

Unused Use Statements +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,9 @@
 block discarded – undo
 
 namespace Modules\Entitizer\Listview {
 
-	use Modules\Entitizer, Template, Language;
+	use Modules\Entitizer;
+	use Template;
+	use Language;
 
 	class Widgets extends Entitizer\Utils\Listview {
 

Please login to merge, or discard this patch.

www/engine/System/Classes/Modules/Filemanager/Handler/Dir.php 1 patch

Unused Use Statements +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,9 @@
 block discarded – undo
 
 namespace Modules\Filemanager\Handler {
 
-	use Modules\Filemanager, Date, Template;
+	use Modules\Filemanager;
+	use Date;
+	use Template;
 
 	class Dir extends Filemanager\Utils\Handler {
 

Please login to merge, or discard this patch.

www/engine/System/Classes/Modules/Filemanager/Handler/File.php 1 patch

Unused Use Statements +6 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,12 @@
 block discarded – undo
 
 namespace Modules\Filemanager\Handler {
 
-	use Modules\Filemanager, Date, Explorer, Mime, Number, Template;
+	use Modules\Filemanager;
+	use Date;
+	use Explorer;
+	use Mime;
+	use Number;
+	use Template;
 
 	class File extends Filemanager\Utils\Handler {
 

Please login to merge, or discard this patch.

www/engine/System/Includes/Constants.php 1 patch

Spacing +41 added lines, -41 removed lines patch added patch discarded remove patch

@@ -2,78 +2,78 @@
 block discarded – undo
 
 # Cadmium
 
-define('CADMIUM_NAME',                              'Cadmium CMS');
-define('CADMIUM_HOME',                              'http://cadmium-cms.com');
+define('CADMIUM_NAME', 'Cadmium CMS');
+define('CADMIUM_HOME', 'http://cadmium-cms.com');
 
-define('CADMIUM_VERSION',                           '0.2.1');
-define('CADMIUM_COPY',                              '2016');
+define('CADMIUM_VERSION', '0.2.1');
+define('CADMIUM_COPY', '2016');
 
 # External
 
-define('JQUERY_VERSION',                            '2.1.4');
-define('SEMANTIC_UI_VERSION',                       '2.1.7');
-define('CKEDITOR_VERSION',                          '4.5.6');
+define('JQUERY_VERSION', '2.1.4');
+define('SEMANTIC_UI_VERSION', '2.1.7');
+define('CKEDITOR_VERSION', '4.5.6');
 
 # Sections
 
-define('SECTION_ADMIN',                             'Admin');
-define('SECTION_SITE',                              'Site');
+define('SECTION_ADMIN', 'Admin');
+define('SECTION_SITE', 'Site');
 
 # Entity types
 
-define('ENTITY_TYPE_PAGE',                          'page');
-define('ENTITY_TYPE_MENUITEM',                      'menuitem');
-define('ENTITY_TYPE_VARIABLE',                      'variable');
-define('ENTITY_TYPE_WIDGET',                        'widget');
-define('ENTITY_TYPE_USER',                          'user');
-define('ENTITY_TYPE_USER_SECRET',                   'user_secret');
-define('ENTITY_TYPE_USER_SESSION',                  'user_session');
+define('ENTITY_TYPE_PAGE', 'page');
+define('ENTITY_TYPE_MENUITEM', 'menuitem');
+define('ENTITY_TYPE_VARIABLE', 'variable');
+define('ENTITY_TYPE_WIDGET', 'widget');
+define('ENTITY_TYPE_USER', 'user');
+define('ENTITY_TYPE_USER_SECRET', 'user_secret');
+define('ENTITY_TYPE_USER_SESSION', 'user_session');
 
 # Filemanager types
 
-define('FILEMANAGER_TYPE_DIR',                      'dir');
-define('FILEMANAGER_TYPE_FILE',                     'file');
+define('FILEMANAGER_TYPE_DIR', 'dir');
+define('FILEMANAGER_TYPE_FILE', 'file');
 
 # Access
 
-define('ACCESS_PUBLIC',                             0);
-define('ACCESS_REGISTERED',                         1);
-define('ACCESS_ADMINISTRATOR',                      2);
+define('ACCESS_PUBLIC', 0);
+define('ACCESS_REGISTERED', 1);
+define('ACCESS_ADMINISTRATOR', 2);
 
 # Frequency
 
-define('FREQUENCY_ALWAYS',                          'always');
-define('FREQUENCY_HOURLY',                          'hourly');
-define('FREQUENCY_DAILY',                           'daily');
-define('FREQUENCY_WEEKLY',                          'weekly');
-define('FREQUENCY_MONTHLY',                         'monthly');
-define('FREQUENCY_YEARLY',                          'yearly');
-define('FREQUENCY_NEVER',                           'never');
+define('FREQUENCY_ALWAYS', 'always');
+define('FREQUENCY_HOURLY', 'hourly');
+define('FREQUENCY_DAILY', 'daily');
+define('FREQUENCY_WEEKLY', 'weekly');
+define('FREQUENCY_MONTHLY', 'monthly');
+define('FREQUENCY_YEARLY', 'yearly');
+define('FREQUENCY_NEVER', 'never');
 
 # Rank
 
-define('RANK_GUEST',                                0);
-define('RANK_USER',                                 1);
-define('RANK_ADMINISTRATOR',                        2);
+define('RANK_GUEST', 0);
+define('RANK_USER', 1);
+define('RANK_ADMINISTRATOR', 2);
 
 # Sex
 
-define('SEX_NOT_SELECTED',                          0);
-define('SEX_MALE',                                  1);
-define('SEX_FEMALE',                                2);
+define('SEX_NOT_SELECTED', 0);
+define('SEX_MALE', 1);
+define('SEX_FEMALE', 2);
 
 # Status
 
-define('STATUS_ONLINE',                             0);
-define('STATUS_MAINTENANCE',                        1);
-define('STATUS_UPDATE',                             2);
+define('STATUS_ONLINE', 0);
+define('STATUS_MAINTENANCE', 1);
+define('STATUS_UPDATE', 2);
 
 # Target
 
-define('TARGET_SELF',                               0);
-define('TARGET_BLANK',                              1);
+define('TARGET_SELF', 0);
+define('TARGET_BLANK', 1);
 
 # Visibility
 
-define('VISIBILITY_DRAFT',                          0);
-define('VISIBILITY_PUBLISHED',                      1);
+define('VISIBILITY_DRAFT', 0);
+define('VISIBILITY_PUBLISHED', 1);

Please login to merge, or discard this patch.

www/engine/System/Classes/Modules/Entitizer/Form/Menuitem.php 1 patch

Unused Use Statements +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,9 @@
 block discarded – undo
 
 namespace Modules\Entitizer\Form {
 
-	use Modules\Entitizer, Utils\Form, Utils\Lister;
+	use Modules\Entitizer;
+	use Utils\Form;
+	use Utils\Lister;
 
 	class Page extends Form {
 

Please login to merge, or discard this patch.

www/engine/System/Classes/Modules/Entitizer/Form/Variable.php 1 patch

Unused Use Statements +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,8 @@
 block discarded – undo
 
 namespace Modules\Entitizer\Form {
 
-	use Modules\Entitizer, Utils\Form;
+	use Modules\Entitizer;
+	use Utils\Form;
 
 	class Widget extends Form {
 

Please login to merge, or discard this patch.

www/engine/System/Classes/Utils/Template/Variables.php 1 patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,11 +23,15 @@
 block discarded – undo
 
 			$selection = ['name', 'value']; $order = ['name' => 'ASC'];
 
-			if (!(DB::select(TABLE_VARIABLES, $selection, null, $order) && DB::last()->status)) return;
+			if (!(DB::select(TABLE_VARIABLES, $selection, null, $order) && DB::last()->status)) {
+				return;
+			}
 
 			# Process results
 
-			while (null !== ($variable = DB::last()->row())) $this->addItem($variable['name'], $variable['value']);
+			while (null !== ($variable = DB::last()->row())) {
+				$this->addItem($variable['name'], $variable['value']);
+			}
 		}
 
 		# Return items

Please login to merge, or discard this patch.

www/engine/System/Classes/Utils/Template/Widgets.php 1 patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,11 +23,15 @@
 block discarded – undo
 
 			$selection = ['name', 'contents']; $condition = ['display' => 1]; $order = ['name' => 'ASC'];
 
-			if (!(DB::select(TABLE_WIDGETS, $selection, $condition, $order) && DB::last()->status)) return;
+			if (!(DB::select(TABLE_WIDGETS, $selection, $condition, $order) && DB::last()->status)) {
+				return;
+			}
 
 			# Process results
 
-			while (null !== ($widget = DB::last()->row())) $this->addItem($widget['name'], $widget['contents']);
+			while (null !== ($widget = DB::last()->row())) {
+				$this->addItem($widget['name'], $widget['contents']);
+			}
 		}
 
 		# Return items

Please login to merge, or discard this patch.

		@@ -23,11 +23,15 @@
		block discarded – undo
23	23
24	24	$selection = ['name', 'value']; $order = ['name' => 'ASC'];
25	25
26		- if (!(DB::select(TABLE_VARIABLES, $selection, null, $order) && DB::last()->status)) return;
	26	+ if (!(DB::select(TABLE_VARIABLES, $selection, null, $order) && DB::last()->status)) {
	27	+ return;
	28	+ }
27	29
28	30	# Process results
29	31
30		- while (null !== ($variable = DB::last()->row())) $this->addItem($variable['name'], $variable['value']);
	32	+ while (null !== ($variable = DB::last()->row())) {
	33	+ $this->addItem($variable['name'], $variable['value']);
	34	+ }
31	35	}
32	36
33	37	# Return items

		@@ -23,11 +23,15 @@
		block discarded – undo
23	23
24	24	$selection = ['name', 'contents']; $condition = ['display' => 1]; $order = ['name' => 'ASC'];
25	25
26		- if (!(DB::select(TABLE_WIDGETS, $selection, $condition, $order) && DB::last()->status)) return;
	26	+ if (!(DB::select(TABLE_WIDGETS, $selection, $condition, $order) && DB::last()->status)) {
	27	+ return;
	28	+ }
27	29
28	30	# Process results
29	31
30		- while (null !== ($widget = DB::last()->row())) $this->addItem($widget['name'], $widget['contents']);
	32	+ while (null !== ($widget = DB::last()->row())) {
	33	+ $this->addItem($widget['name'], $widget['contents']);
	34	+ }
31	35	}
32	36
33	37	# Return items

		@@ -2,7 +2,8 @@
		block discarded – undo
2	2
3	3	namespace Modules\Entitizer\Listview {
4	4
5		- use Modules\Entitizer, Template;
	5	+ use Modules\Entitizer;
	6	+ use Template;
6	7
7	8	class Variables extends Entitizer\Utils\Listview {
8	9

		@@ -2,7 +2,9 @@
		block discarded – undo
2	2
3	3	namespace Modules\Entitizer\Listview {
4	4
5		- use Modules\Entitizer, Template, Language;
	5	+ use Modules\Entitizer;
	6	+ use Template;
	7	+ use Language;
6	8
7	9	class Widgets extends Entitizer\Utils\Listview {
8	10

		@@ -2,7 +2,9 @@
		block discarded – undo
2	2
3	3	namespace Modules\Filemanager\Handler {
4	4
5		- use Modules\Filemanager, Date, Template;
	5	+ use Modules\Filemanager;
	6	+ use Date;
	7	+ use Template;
6	8
7	9	class Dir extends Filemanager\Utils\Handler {
8	10

		@@ -2,7 +2,12 @@
		block discarded – undo
2	2
3	3	namespace Modules\Filemanager\Handler {
4	4
5		- use Modules\Filemanager, Date, Explorer, Mime, Number, Template;
	5	+ use Modules\Filemanager;
	6	+ use Date;
	7	+ use Explorer;
	8	+ use Mime;
	9	+ use Number;
	10	+ use Template;
6	11
7	12	class File extends Filemanager\Utils\Handler {
8	13

		@@ -2,78 +2,78 @@
		block discarded – undo
2	2
3	3	# Cadmium
4	4
5		-define('CADMIUM_NAME', 'Cadmium CMS');
6		-define('CADMIUM_HOME', 'http://cadmium-cms.com');
	5	+define('CADMIUM_NAME', 'Cadmium CMS');
	6	+define('CADMIUM_HOME', 'http://cadmium-cms.com');
7	7
8		-define('CADMIUM_VERSION', '0.2.1');
9		-define('CADMIUM_COPY', '2016');
	8	+define('CADMIUM_VERSION', '0.2.1');
	9	+define('CADMIUM_COPY', '2016');
10	10
11	11	# External
12	12
13		-define('JQUERY_VERSION', '2.1.4');
14		-define('SEMANTIC_UI_VERSION', '2.1.7');
15		-define('CKEDITOR_VERSION', '4.5.6');
	13	+define('JQUERY_VERSION', '2.1.4');
	14	+define('SEMANTIC_UI_VERSION', '2.1.7');
	15	+define('CKEDITOR_VERSION', '4.5.6');
16	16
17	17	# Sections
18	18
19		-define('SECTION_ADMIN', 'Admin');
20		-define('SECTION_SITE', 'Site');
	19	+define('SECTION_ADMIN', 'Admin');
	20	+define('SECTION_SITE', 'Site');
21	21
22	22	# Entity types
23	23
24		-define('ENTITY_TYPE_PAGE', 'page');
25		-define('ENTITY_TYPE_MENUITEM', 'menuitem');
26		-define('ENTITY_TYPE_VARIABLE', 'variable');
27		-define('ENTITY_TYPE_WIDGET', 'widget');
28		-define('ENTITY_TYPE_USER', 'user');
29		-define('ENTITY_TYPE_USER_SECRET', 'user_secret');
30		-define('ENTITY_TYPE_USER_SESSION', 'user_session');
	24	+define('ENTITY_TYPE_PAGE', 'page');
	25	+define('ENTITY_TYPE_MENUITEM', 'menuitem');
	26	+define('ENTITY_TYPE_VARIABLE', 'variable');
	27	+define('ENTITY_TYPE_WIDGET', 'widget');
	28	+define('ENTITY_TYPE_USER', 'user');
	29	+define('ENTITY_TYPE_USER_SECRET', 'user_secret');
	30	+define('ENTITY_TYPE_USER_SESSION', 'user_session');
31	31
32	32	# Filemanager types
33	33
34		-define('FILEMANAGER_TYPE_DIR', 'dir');
35		-define('FILEMANAGER_TYPE_FILE', 'file');
	34	+define('FILEMANAGER_TYPE_DIR', 'dir');
	35	+define('FILEMANAGER_TYPE_FILE', 'file');
36	36
37	37	# Access
38	38
39		-define('ACCESS_PUBLIC', 0);
40		-define('ACCESS_REGISTERED', 1);
41		-define('ACCESS_ADMINISTRATOR', 2);
	39	+define('ACCESS_PUBLIC', 0);
	40	+define('ACCESS_REGISTERED', 1);
	41	+define('ACCESS_ADMINISTRATOR', 2);
42	42
43	43	# Frequency
44	44
45		-define('FREQUENCY_ALWAYS', 'always');
46		-define('FREQUENCY_HOURLY', 'hourly');
47		-define('FREQUENCY_DAILY', 'daily');
48		-define('FREQUENCY_WEEKLY', 'weekly');
49		-define('FREQUENCY_MONTHLY', 'monthly');
50		-define('FREQUENCY_YEARLY', 'yearly');
51		-define('FREQUENCY_NEVER', 'never');
	45	+define('FREQUENCY_ALWAYS', 'always');
	46	+define('FREQUENCY_HOURLY', 'hourly');
	47	+define('FREQUENCY_DAILY', 'daily');
	48	+define('FREQUENCY_WEEKLY', 'weekly');
	49	+define('FREQUENCY_MONTHLY', 'monthly');
	50	+define('FREQUENCY_YEARLY', 'yearly');
	51	+define('FREQUENCY_NEVER', 'never');
52	52
53	53	# Rank
54	54
55		-define('RANK_GUEST', 0);
56		-define('RANK_USER', 1);
57		-define('RANK_ADMINISTRATOR', 2);
	55	+define('RANK_GUEST', 0);
	56	+define('RANK_USER', 1);
	57	+define('RANK_ADMINISTRATOR', 2);
58	58
59	59	# Sex
60	60
61		-define('SEX_NOT_SELECTED', 0);
62		-define('SEX_MALE', 1);
63		-define('SEX_FEMALE', 2);
	61	+define('SEX_NOT_SELECTED', 0);
	62	+define('SEX_MALE', 1);
	63	+define('SEX_FEMALE', 2);
64	64
65	65	# Status
66	66
67		-define('STATUS_ONLINE', 0);
68		-define('STATUS_MAINTENANCE', 1);
69		-define('STATUS_UPDATE', 2);
	67	+define('STATUS_ONLINE', 0);
	68	+define('STATUS_MAINTENANCE', 1);
	69	+define('STATUS_UPDATE', 2);
70	70
71	71	# Target
72	72
73		-define('TARGET_SELF', 0);
74		-define('TARGET_BLANK', 1);
	73	+define('TARGET_SELF', 0);
	74	+define('TARGET_BLANK', 1);
75	75
76	76	# Visibility
77	77
78		-define('VISIBILITY_DRAFT', 0);
79		-define('VISIBILITY_PUBLISHED', 1);
	78	+define('VISIBILITY_DRAFT', 0);
	79	+define('VISIBILITY_PUBLISHED', 1);

		@@ -2,7 +2,9 @@
		block discarded – undo
2	2
3	3	namespace Modules\Entitizer\Form {
4	4
5		- use Modules\Entitizer, Utils\Form, Utils\Lister;
	5	+ use Modules\Entitizer;
	6	+ use Utils\Form;
	7	+ use Utils\Lister;
6	8
7	9	class Page extends Form {
8	10

cadmium-org / cadmium-cms

Push — 0.2.1 ( e70612...dab97b )

Status

Category

Unused Use Statements +2 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +41 added lines, -41 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +2 added lines, -1 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch