Menu - Code Metrics - Inspection of "Merge branch 0.4.7" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#19)

by Anton

created 2017-06-17 19:35 UTC

Menu A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	0
loc	62
rs	10
c	0
b	0
f	0
wmc	8
lcom	1
cbo	5

3 Methods

Rating	Name	Size	Complexity
B	parseItem()	27	4
A	__construct()	6	2
A	getBlock()	10	2

<?php

/**
 * @package Cadmium\System\Utils
 * @author Anton Romanov
 * @copyright Copyright (c) 2015-2017, Anton Romanov
 * @link http://cadmium-cms.com
 */

namespace Utils {

	use Modules\Entitizer, Template;

	class Menu {

		private $menu = [0 => ['children' => []]];

		/**
		 * Parse a menu item
		 */

		private function parseItem(int $id) : Template\Block {

			if ([] !== $this->menu[$id]['children']) {

				$item = View::get('Blocks/Utils/Menu/Container');

				$item->text = $this->menu[$id]['dataset']->text;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

				$item->children = ($children = Template::createBlock());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

				foreach ($this->menu[$id]['children'] as $child) $children->addItem($this->parseItem($child));

			} else {

				$item = View::get('Blocks/Utils/Menu/Item');

				$item->target = (($this->menu[$id]['dataset']->target === TARGET_BLANK) ? '_blank' : '_self');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

				$item->link = $this->menu[$id]['dataset']->link;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

				$item->text = $this->menu[$id]['dataset']->text;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			}

			# ------------------------

			return $item;
		}

		/**
		 * Constructor
		 */

		public function __construct() {

			$menu = Entitizer::getTreeview(TABLE_MENU)->getSubtree(0, ['active' => true]);

			if (false !== $menu) $this->menu = $menu;
		}

		/**
		 * Get a menu block
		 */

		public function getBlock() : Template\Block {

			$menu = Template::createBlock();

			foreach ($this->menu[0]['children'] as $id) $menu->addItem($this->parseItem($id));

			# ------------------------

			return $menu;
		}
	}
}


1			<?php
2
3			/**
4			* @package Cadmium\System\Utils
5			* @author Anton Romanov
6			* @copyright Copyright (c) 2015-2017, Anton Romanov
7			* @link http://cadmium-cms.com
8			*/
9
10			namespace Utils {
11
12			use Modules\Entitizer, Template;
13
14			class Menu {
15
16			private $menu = [0 => ['children' => []]];
17
18			/**
19			* Parse a menu item
20			*/
21
22			private function parseItem(int $id) : Template\Block {
23
24			if ([] !== $this->menu[$id]['children']) {
25
26			$item = View::get('Blocks/Utils/Menu/Container');
27
28			$item->text = $this->menu[$id]['dataset']->text;
			0 ignored issues – show Documentation introduced 2017-04-30 22:42 UTC by Report Bug Copy Issue Report The property `text` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29
30			$item->children = ($children = Template::createBlock());
			0 ignored issues – show Documentation introduced 2017-04-30 22:42 UTC by Report Bug Copy Issue Report The property `children` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31
32			foreach ($this->menu[$id]['children'] as $child) $children->addItem($this->parseItem($child));
33
34			} else {
35
36			$item = View::get('Blocks/Utils/Menu/Item');
37
38			$item->target = (($this->menu[$id]['dataset']->target === TARGET_BLANK) ? '_blank' : '_self');
			0 ignored issues – show Documentation introduced 2017-04-30 22:42 UTC by Report Bug Copy Issue Report The property `target` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39
40			$item->link = $this->menu[$id]['dataset']->link;
			0 ignored issues – show Documentation introduced 2017-04-30 22:42 UTC by Report Bug Copy Issue Report The property `link` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41
42			$item->text = $this->menu[$id]['dataset']->text;
			0 ignored issues – show Documentation introduced 2017-04-30 22:42 UTC by Report Bug Copy Issue Report The property `text` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
43			}
44
45			# ------------------------
46
47			return $item;
48			}
49
50			/**
51			* Constructor
52			*/
53
54			public function __construct() {
55
56			$menu = Entitizer::getTreeview(TABLE_MENU)->getSubtree(0, ['active' => true]);
57
58			if (false !== $menu) $this->menu = $menu;
59			}
60
61			/**
62			* Get a menu block
63			*/
64
65			public function getBlock() : Template\Block {
66
67			$menu = Template::createBlock();
68
69			foreach ($this->menu[0]['children'] as $id) $menu->addItem($this->parseItem($id));
70
71			# ------------------------
72
73			return $menu;
74			}
75			}
76			}
77

cadmium-org / cadmium-cms

Pull Request — master (#19)

Menu A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like