Page::updateSlugs() - Code Metrics - Inspection of "Initial commit for 0.3.0" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — 0.3.0 (b16461)

by Anton

created 2016-04-16 14:38 UTC

Page::updateSlugs() C

↳ Parent: Page

Complexity

Conditions	7
Paths	4

Size

Total Lines	42
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	42
rs	6.7272
cc	7
eloc	18
nc	4
nop	0

<?php

namespace Modules\Entitizer\Entity {

	use Modules\Auth, Modules\Entitizer, Modules\Settings, DB;

	class Page extends Entitizer\Utils\Entity {

		use Entitizer\Common\Page;

		# Check if active

		private function getActive() {

			return (($this->visibility === VISIBILITY_PUBLISHED) && !$this->locked);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		}

		# Get link

		private function getLink() {

			if ('' === $this->data['slug']) return '';

			return (INSTALL_PATH . '/' . $this->data['slug']);
		}

		# Get canonical

		private function getCanonical() {

			if ('' === $this->data['slug']) return '';

			return (Settings::get('system_url') . (($this->id !== 1) ? ('/' . $this->data['slug']) : ''));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		}

		# Implement entity

		protected function implement() {

			$this->data['active'] = $this->getActive();

			$this->data['link'] = $this->getLink();

			$this->data['canonical'] = $this->getCanonical();
		}

		# Init by slug

		public function initBySlug(string $slug) {

			if (!$this->modifiable || (0 !== $this->id)) return false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			# Process value

			$slug = $this->definition->param('slug')->cast($slug);

			# Process selection

			$selection = array_keys($this->definition->params());

			foreach ($selection as $key => $field) $selection[$key] = ('ent.' . $field);

			# Process query

			$query = ("SELECT " . implode(', ', $selection) .", rel.ancestor as parent_id ") .

			         ("FROM " . static::$table . " ent ") .

			         ("LEFT JOIN " . static::$table_relations . " rel ON rel.descendant = ent.id AND rel.depth = 1 ") .

			         ("WHERE ent.visibility = " . VISIBILITY_PUBLISHED . " AND ent.access <= " . Auth::user()->rank . " AND ") .

			         ("ent.locked = 0 AND ent.slug = '" . addslashes($slug) . "' LIMIT 1");

			# Select entity from DB

			if (($this->error = !(DB::send($query) && DB::last()->status)) || (DB::last()->rows !== 1)) return false;


			# ------------------------

			return $this->setData(DB::last()->row());
		}

		# Update slugs

		public function updateSlugs() {

			if (!$this->modifiable || (0 === $this->id)) return false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			# Send lock/update request

			$query = ("UPDATE " . static::$table . " ent JOIN (") .

			         ("SELECT rel.descendant as id, GROUP_CONCAT(ens.name ORDER BY rls.depth DESC SEPARATOR '/') slug ") .

			         ("FROM " . static::$table_relations . " rel ") .

			         ("JOIN " . static::$table_relations . " rls ON rls.descendant = rel.descendant ") .

			         ("JOIN " . static::$table . " ens ON ens.id = rls.ancestor ") .

			         ("WHERE rel.ancestor = " . $this->id . " GROUP BY rel.descendant") .
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			         (") slg ON slg.id = ent.id SET ent.locked = 1, ent.slug = slg.slug");

			if (!(DB::send($query) && DB::last()->status)) return false;

			# Send unlock request

			$query = ("UPDATE " . static::$table . " ent JOIN (") .

			         ("SELECT rel.descendant as id FROM " . static::$table_relations . " rel ") .

			         ("JOIN " . static::$table . " enc ON enc.id = rel.descendant AND enc.locked = 1 ") .

			         ("LEFT JOIN " . static::$table . " end ON end.id != enc.id AND end.slug = enc.slug ") .

			         ("WHERE end.id IS NULL GROUP BY rel.descendant") .

			         (") chk ON chk.id = ent.id SET ent.locked = 0");

			if (!(DB::send($query) && DB::last()->status)) return false;

			# ------------------------

			return true;
		}

		# Create page entry in DB

		public function create(array $data) {

			if (!parent::create($data)) return false;

			$this->updateSlugs();

			# ------------------------

			return true;
		}

		# Edit page entry in DB

		public function edit(array $data) {

			if (!parent::edit($data)) return false;

			$this->updateSlugs();

			# ------------------------

			return true;
		}

		# Move page to new parent

		public function move(int $parent_id) {

			if (!parent::move($parent_id)) return false;

			$this->updateSlugs();

			# ------------------------

			return true;
		}
	}
}


1		<?php
2
3		namespace Modules\Entitizer\Entity {
4
5		use Modules\Auth, Modules\Entitizer, Modules\Settings, DB;
6
7		class Page extends Entitizer\Utils\Entity {
8
9		use Entitizer\Common\Page;
10
11		# Check if active
12
13		private function getActive() {
14
15		return (($this->visibility === VISIBILITY_PUBLISHED) && !$this->locked);
		0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `visibility` does not exist on `object<Modules\Entitizer\Entity\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `locked` does not exist on `object<Modules\Entitizer\Entity\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
16		}
17
18		# Get link
19
20		private function getLink() {
21
22		if ('' === $this->data['slug']) return '';
23
24		return (INSTALL_PATH . '/' . $this->data['slug']);
25		}
26
27		# Get canonical
28
29		private function getCanonical() {
30
31		if ('' === $this->data['slug']) return '';
32
33		return (Settings::get('system_url') . (($this->id !== 1) ? ('/' . $this->data['slug']) : ''));
		0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Entity\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34		}
35
36		# Implement entity
37
38		protected function implement() {
39
40		$this->data['active'] = $this->getActive();
41
42		$this->data['link'] = $this->getLink();
43
44		$this->data['canonical'] = $this->getCanonical();
45		}
46
47		# Init by slug
48
49		public function initBySlug(string $slug) {
50
51		if (!$this->modifiable \|\| (0 !== $this->id)) return false;
		0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Entity\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52
53		# Process value
54
55		$slug = $this->definition->param('slug')->cast($slug);
56
57		# Process selection
58
59		$selection = array_keys($this->definition->params());
60
61		foreach ($selection as $key => $field) $selection[$key] = ('ent.' . $field);
62
63		# Process query
64
65		$query = ("SELECT " . implode(', ', $selection) .", rel.ancestor as parent_id ") .
66
67		("FROM " . static::$table . " ent ") .
68
69		("LEFT JOIN " . static::$table_relations . " rel ON rel.descendant = ent.id AND rel.depth = 1 ") .
70
71		("WHERE ent.visibility = " . VISIBILITY_PUBLISHED . " AND ent.access <= " . Auth::user()->rank . " AND ") .
72
73		("ent.locked = 0 AND ent.slug = '" . addslashes($slug) . "' LIMIT 1");
74
75		# Select entity from DB
76
77	View Code Duplication	if (($this->error = !(DB::send($query) && DB::last()->status)) \|\| (DB::last()->rows !== 1)) return false;
		0 ignored issues – show Duplication introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78
79		# ------------------------
80
81		return $this->setData(DB::last()->row());
82		}
83
84		# Update slugs
85
86		public function updateSlugs() {
87
88		if (!$this->modifiable \|\| (0 === $this->id)) return false;
		0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Entity\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
89
90		# Send lock/update request
91
92		$query = ("UPDATE " . static::$table . " ent JOIN (") .
93
94		("SELECT rel.descendant as id, GROUP_CONCAT(ens.name ORDER BY rls.depth DESC SEPARATOR '/') slug ") .
95
96		("FROM " . static::$table_relations . " rel ") .
97
98		("JOIN " . static::$table_relations . " rls ON rls.descendant = rel.descendant ") .
99
100		("JOIN " . static::$table . " ens ON ens.id = rls.ancestor ") .
101
102		("WHERE rel.ancestor = " . $this->id . " GROUP BY rel.descendant") .
		0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Entity\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
103
104		(") slg ON slg.id = ent.id SET ent.locked = 1, ent.slug = slg.slug");
105
106		if (!(DB::send($query) && DB::last()->status)) return false;
107
108		# Send unlock request
109
110		$query = ("UPDATE " . static::$table . " ent JOIN (") .
111
112		("SELECT rel.descendant as id FROM " . static::$table_relations . " rel ") .
113
114		("JOIN " . static::$table . " enc ON enc.id = rel.descendant AND enc.locked = 1 ") .
115
116		("LEFT JOIN " . static::$table . " end ON end.id != enc.id AND end.slug = enc.slug ") .
117
118		("WHERE end.id IS NULL GROUP BY rel.descendant") .
119
120		(") chk ON chk.id = ent.id SET ent.locked = 0");
121
122		if (!(DB::send($query) && DB::last()->status)) return false;
123
124		# ------------------------
125
126		return true;
127		}
128
129		# Create page entry in DB
130
131		public function create(array $data) {
132
133		if (!parent::create($data)) return false;
134
135		$this->updateSlugs();
136
137		# ------------------------
138
139		return true;
140		}
141
142		# Edit page entry in DB
143
144		public function edit(array $data) {
145
146		if (!parent::edit($data)) return false;
147
148		$this->updateSlugs();
149
150		# ------------------------
151
152		return true;
153		}
154
155		# Move page to new parent
156
157		public function move(int $parent_id) {
158
159		if (!parent::move($parent_id)) return false;
160
161		$this->updateSlugs();
162
163		# ------------------------
164
165		return true;
166		}
167		}
168		}
169

cadmium-org / cadmium-cms

Branch — 0.3.0 (b16461)

Page::updateSlugs() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like