Uploader::save() - Code Metrics - Inspection of "Merge pull request #6 from cadmium-org/0.2.1" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 416cb1...222de5 )

by Anton

created 2016-01-10 17:42 UTC

Uploader::save() C

↳ Parent: Uploader

Complexity

Conditions	11
Paths	9

Size

Total Lines	40
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	40
rs	5.2653
cc	11
eloc	12
nc	9
nop	2

How to fix Complexity

<?php

namespace Utils {

	use Modules\Informer, Utils\Messages, Explorer, Language, Request;

	abstract class Uploader {

		# Translate error code

		private static function translateError(int $error) {

			if ($error === UPLOAD_ERR_INI_SIZE)         return 'UPLOADER_ERROR_INI_SIZE';

			if ($error === UPLOAD_ERR_FORM_SIZE)        return 'UPLOADER_ERROR_FORM_SIZE';

			if ($error === UPLOAD_ERR_PARTIAL)          return 'UPLOADER_ERROR_PARTIAL';

			if ($error === UPLOAD_ERR_NO_FILE)          return 'UPLOADER_ERROR_NO_FILE';

			if ($error === UPLOAD_ERR_NO_TMP_DIR)       return 'UPLOADER_ERROR_NO_TMP_DIR';

			if ($error === UPLOAD_ERR_CANT_WRITE)       return 'UPLOADER_ERROR_CANT_WRITE';

			if ($error === UPLOAD_ERR_EXTENSION)        return 'UPLOADER_ERROR_EXTENSION';

			# ------------------------

			return 'UPLOADER_ERROR_UNKNOWN';
		}

		# Save uploaded file

		public static function save(string $name, string $dir_name) {

			if ((false === ($file = Request::file($name))) || !is_uploaded_file($file['tmp_name'])) return false;

			# Check for demo mode

			if (Informer::isDemoMode()) return 'DEMO_MODE_RESTRICTION';

			# Check for upload errors

			if ($file['error'] !== UPLOAD_ERR_OK) return self::translateError($file['error']);

			# Check size

			if ($file['size'] > CONFIG_UPLOADS_MAX_SIZE) return 'UPLOADER_ERROR_SIZE';

			# Check file extension

			$extensions = ['php', 'phtml', 'php3', 'php4', 'php5', 'phps'];

			if (in_array(Explorer::extension($file['name'], false), $extensions)) return 'UPLOADER_ERROR_TYPE';

			# Check target directory

			if (!Explorer::isDir($dir_name)) return 'UPLOADER_ERROR_DIR';

			# Check target file

			$file_name = ($dir_name . '/' . basename($file['name']));

			if (Explorer::isDir($file_name) || Explorer::isFile($file_name)) return 'UPLOADER_ERROR_EXISTS';

			# Save uploaded file

			if (!@move_uploaded_file($file['tmp_name'], $file_name)) return 'UPLOADER_ERROR_SAVE';

			# ------------------------

			return true;
		}

		# Submit uploaded file

		public static function submit(string $name, string $dir_name) {

			$result = self::save($name, $dir_name);

			if (is_string($result)) { Messages::error(Language::get($result)); return false; }

			# ------------------------

			return (true === $result);
		}
	}
}


1			<?php
2
3			namespace Utils {
4
5			use Modules\Informer, Utils\Messages, Explorer, Language, Request;
6
7			abstract class Uploader {
8
9			# Translate error code
10
11			private static function translateError(int $error) {
12
13			if ($error === UPLOAD_ERR_INI_SIZE) return 'UPLOADER_ERROR_INI_SIZE';
14
15			if ($error === UPLOAD_ERR_FORM_SIZE) return 'UPLOADER_ERROR_FORM_SIZE';
16
17			if ($error === UPLOAD_ERR_PARTIAL) return 'UPLOADER_ERROR_PARTIAL';
18
19			if ($error === UPLOAD_ERR_NO_FILE) return 'UPLOADER_ERROR_NO_FILE';
20
21			if ($error === UPLOAD_ERR_NO_TMP_DIR) return 'UPLOADER_ERROR_NO_TMP_DIR';
22
23			if ($error === UPLOAD_ERR_CANT_WRITE) return 'UPLOADER_ERROR_CANT_WRITE';
24
25			if ($error === UPLOAD_ERR_EXTENSION) return 'UPLOADER_ERROR_EXTENSION';
26
27			# ------------------------
28
29			return 'UPLOADER_ERROR_UNKNOWN';
30			}
31
32			# Save uploaded file
33
34			public static function save(string $name, string $dir_name) {
35
36			if ((false === ($file = Request::file($name))) \|\| !is_uploaded_file($file['tmp_name'])) return false;
37
38			# Check for demo mode
39
40			if (Informer::isDemoMode()) return 'DEMO_MODE_RESTRICTION';
41
42			# Check for upload errors
43
44			if ($file['error'] !== UPLOAD_ERR_OK) return self::translateError($file['error']);
45
46			# Check size
47
48			if ($file['size'] > CONFIG_UPLOADS_MAX_SIZE) return 'UPLOADER_ERROR_SIZE';
49
50			# Check file extension
51
52			$extensions = ['php', 'phtml', 'php3', 'php4', 'php5', 'phps'];
53
54			if (in_array(Explorer::extension($file['name'], false), $extensions)) return 'UPLOADER_ERROR_TYPE';
55
56			# Check target directory
57
58			if (!Explorer::isDir($dir_name)) return 'UPLOADER_ERROR_DIR';
59
60			# Check target file
61
62			$file_name = ($dir_name . '/' . basename($file['name']));
63
64			if (Explorer::isDir($file_name) \|\| Explorer::isFile($file_name)) return 'UPLOADER_ERROR_EXISTS';
65
66			# Save uploaded file
67
68			if (!@move_uploaded_file($file['tmp_name'], $file_name)) return 'UPLOADER_ERROR_SAVE';
69
70			# ------------------------
71
72			return true;
73			}
74
75			# Submit uploaded file
76
77			public static function submit(string $name, string $dir_name) {
78
79			$result = self::save($name, $dir_name);
80
81			if (is_string($result)) { Messages::error(Language::get($result)); return false; }
82
83			# ------------------------
84
85			return (true === $result);
86			}
87			}
88			}
89

cadmium-org / cadmium-cms

Push — master ( 416cb1...222de5 )

Uploader::save() C

Complexity

Size

Duplication

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like