Widgets - Code Metrics - Inspection of "Merge pull request #6 from cadmium-org/0.2.1" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 416cb1...222de5 )

by Anton

created 2016-01-10 17:42 UTC

Widgets A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Metric	Value
wmc	3
lcom	0
cbo	3
dl	0
loc	35
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processEntity()	0	1	1
A	processItem()	0	6	2

<?php

namespace Modules\Entitizer\Listview {

	use Modules\Entitizer, Template, Language;

	class Widgets extends Entitizer\Utils\Listview {

		use Entitizer\Common\Widget;

		# Listview configuration

		protected static $lister = 'Modules\Entitizer\Lister\Widgets';

		protected static $link = '/admin/content/widgets';

		protected static $naming = 'title';

		protected static $display = CONFIG_ADMIN_WIDGETS_DISPLAY;

		protected static $view_main = 'Blocks\Entitizer\Widgets\Listview\Main';

		protected static $view_item = 'Blocks\Entitizer\Widgets\Listview\Item';

		protected static $view_ajax_main = '';

		protected static $view_ajax_item = '';

		# Add additional data for specific entity

		protected function processEntity() {}

		# Add item additional data

		protected function processItem(Template\Asset\Block $view, Entitizer\Entity\Widget $widget) {

			$view->name = $widget->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			$view->display = Language::get($widget->display ? 'WIDGET_DISPLAY_ACTIVE' : 'WIDGET_DISPLAY_DISABLED');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		}
	}
}


1			<?php
2
3			namespace Modules\Entitizer\Listview {
4
5			use Modules\Entitizer, Template, Language;
6
7			class Widgets extends Entitizer\Utils\Listview {
8
9			use Entitizer\Common\Widget;
10
11			# Listview configuration
12
13			protected static $lister = 'Modules\Entitizer\Lister\Widgets';
14
15			protected static $link = '/admin/content/widgets';
16
17			protected static $naming = 'title';
18
19			protected static $display = CONFIG_ADMIN_WIDGETS_DISPLAY;
20
21			protected static $view_main = 'Blocks\Entitizer\Widgets\Listview\Main';
22
23			protected static $view_item = 'Blocks\Entitizer\Widgets\Listview\Item';
24
25			protected static $view_ajax_main = '';
26
27			protected static $view_ajax_item = '';
28
29			# Add additional data for specific entity
30
31			protected function processEntity() {}
32
33			# Add item additional data
34
35			protected function processItem(Template\Asset\Block $view, Entitizer\Entity\Widget $widget) {
36
37			$view->name = $widget->name;
			0 ignored issues – show Documentation introduced 2016-01-03 22:02 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Template\Asset\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-01-06 17:19 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist in `Modules\Entitizer\Entity\Widget`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
38
39			$view->display = Language::get($widget->display ? 'WIDGET_DISPLAY_ACTIVE' : 'WIDGET_DISPLAY_DISABLED');
			0 ignored issues – show Documentation introduced 2016-01-03 22:02 UTC by Report Bug Copy Issue Report The property `display` does not exist on `object<Template\Asset\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-01-06 17:19 UTC by Report Bug Copy Issue Report The property `display` does not exist on `object<Modules\Entitizer\Entity\Widget>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			}
41			}
42			}
43

cadmium-org / cadmium-cms

Push — master ( 416cb1...222de5 )

Widgets A

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Duplication Side-by-Side

Filter issues like