Variable - Code Metrics - Inspection of "Merge pull request #6 from cadmium-org/0.2.1" - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 416cb1...222de5 )

by Anton

created 2016-01-10 17:42 UTC

Variable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Metric	Value
wmc	1
lcom	0
cbo	1
dl	0
loc	19
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1

<?php

namespace Modules\Entitizer\Form {

	use Modules\Entitizer, Utils\Form;

	class Variable extends Form {

		# Constructor

		public function __construct(Entitizer\Entity\Variable $variable) {

			parent::__construct(ENTITY_TYPE_VARIABLE);

			# Add fields

			$this->addText('title', $variable->title, FORM_FIELD_TEXT, CONFIG_VARIABLE_TITLE_MAX_LENGTH, ['required' => true]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			$this->addText('name', $variable->name, FORM_FIELD_TEXT, CONFIG_VARIABLE_NAME_MAX_LENGTH,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

				['required' => true, 'convert' => 'var']);

			$this->addText('value', $variable->value, FORM_FIELD_TEXT, CONFIG_VARIABLE_VALUE_MAX_LENGTH);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		}
	}
}


1			<?php
2
3			namespace Modules\Entitizer\Form {
4
5			use Modules\Entitizer, Utils\Form;
6
7			class Variable extends Form {
8
9			# Constructor
10
11			public function __construct(Entitizer\Entity\Variable $variable) {
12
13			parent::__construct(ENTITY_TYPE_VARIABLE);
14
15			# Add fields
16
17			$this->addText('title', $variable->title, FORM_FIELD_TEXT, CONFIG_VARIABLE_TITLE_MAX_LENGTH, ['required' => true]);
			0 ignored issues – show Documentation introduced 2016-01-06 17:19 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<Modules\Entitizer\Entity\Variable>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
18
19			$this->addText('name', $variable->name, FORM_FIELD_TEXT, CONFIG_VARIABLE_NAME_MAX_LENGTH,
			0 ignored issues – show Documentation introduced 2016-01-06 17:19 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Modules\Entitizer\Entity\Variable>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20
21			['required' => true, 'convert' => 'var']);
22
23			$this->addText('value', $variable->value, FORM_FIELD_TEXT, CONFIG_VARIABLE_VALUE_MAX_LENGTH);
			0 ignored issues – show Documentation introduced 2016-01-06 17:19 UTC by Report Bug Copy Issue Report The property `value` does not exist on `object<Modules\Entitizer\Entity\Variable>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24			}
25			}
26			}
27

cadmium-org / cadmium-cms

Push — master ( 416cb1...222de5 )

Variable A

Complexity

Size/Duplication

Coupling/Cohesion

1 Method

Duplication Side-by-Side

Filter issues like