Passed
Push — master ( 1f6010...1bd3c9 )
by Anton
04:57
created
www/engine/System/Classes/Modules/Extend/Utils/Handler/Addons.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,13 +35,17 @@  discard block
 block discarded – undo
35 35
 
36 36
 				$name = Request::post('name');
37 37
 
38
-				if (!$this->loader->install($name, true)) return $ajax->setError(Language::get(static::$error_install));
38
+				if (!$this->loader->install($name, true)) {
39
+					return $ajax->setError(Language::get(static::$error_install));
40
+				}
39 41
 
40 42
 			} else if (Request::post('action') === 'uninstall') {
41 43
 
42 44
 				$name = Request::post('name');
43 45
 
44
-				if (!$this->loader->install($name, false)) return $ajax->setError(Language::get(static::$error_uninstall));
46
+				if (!$this->loader->install($name, false)) {
47
+					return $ajax->setError(Language::get(static::$error_uninstall));
48
+				}
45 49
 			}
46 50
 
47 51
 			# ------------------------
@@ -55,7 +59,9 @@  discard block
 block discarded – undo
55 59
 
56 60
 			$this->loader = new static::$loader_class;
57 61
 
58
-			if ($ajax) return $this->handleAjax();
62
+			if ($ajax) {
63
+				return $this->handleAjax();
64
+			}
59 65
 
60 66
 			# ------------------------
61 67
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Settings/Utils/Handler.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
 			if ($this->form->handle(new static::$controller_class, true)) {
50 50
 
51
-				Request::redirect(INSTALL_PATH . (static::$url . '?submitted'));
51
+				Request::redirect(INSTALL_PATH.(static::$url.'?submitted'));
52 52
 			}
53 53
 
54 54
 			# Display success message
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,9 @@
 block discarded – undo
40 40
 
41 41
 			# Display success message
42 42
 
43
-			if (false !== Request::get('submitted')) Popup::set('positive', Language::get('SETTINGS_SUCCESS'));
43
+			if (false !== Request::get('submitted')) {
44
+				Popup::set('positive', Language::get('SETTINGS_SUCCESS'));
45
+			}
44 46
 
45 47
 			# ------------------------
46 48
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Settings/Utils/Controller.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,12 +21,16 @@
 block discarded – undo
21 21
 
22 22
 			foreach (Settings::setArray($post) as $name => $result) {
23 23
 
24
-				if (!$result) return (isset($errors[$name]) ? [$name, $errors[$name]] : false);
24
+				if (!$result) {
25
+					return (isset($errors[$name]) ? [$name, $errors[$name]] : false);
26
+				}
25 27
 			}
26 28
 
27 29
 			# Save settings
28 30
 
29
-			if (!Settings::save()) return 'SETTINGS_ERROR_SAVE';
31
+			if (!Settings::save()) {
32
+				return 'SETTINGS_ERROR_SAVE';
33
+			}
30 34
 
31 35
 			# ------------------------
32 36
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Settings/Utils/Dataset.php 2 patches
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 			if (empty($_SERVER['HTTP_HOST'])) return CONFIG_SYSTEM_URL;
23 23
 
24
-			return ((Request::isSecure() ? 'https://' : 'http://') . $_SERVER['HTTP_HOST']);
24
+			return ((Request::isSecure() ? 'https://' : 'http://').$_SERVER['HTTP_HOST']);
25 25
 		}
26 26
 
27 27
 		/**
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
 			if (empty($_SERVER['HTTP_HOST'])) return CONFIG_SYSTEM_EMAIL;
34 34
 
35
-			return ('admin@' . $_SERVER['HTTP_HOST']);
35
+			return ('admin@'.$_SERVER['HTTP_HOST']);
36 36
 		}
37 37
 
38 38
 		/**
@@ -43,98 +43,98 @@  discard block
 block discarded – undo
43 43
 
44 44
 			# Site language
45 45
 
46
-			$this->addParam('site_language', CONFIG_SITE_LANGUAGE, function (string $name) {
46
+			$this->addParam('site_language', CONFIG_SITE_LANGUAGE, function(string $name) {
47 47
 
48 48
 				return ((false !== ($name = Extend\Languages::validate($name))) ? $name : null);
49 49
 			});
50 50
 
51 51
 			# Site template
52 52
 
53
-			$this->addParam('site_template', CONFIG_SITE_TEMPLATE, function (string $name) {
53
+			$this->addParam('site_template', CONFIG_SITE_TEMPLATE, function(string $name) {
54 54
 
55 55
 				return ((false !== ($name = Extend\Templates::validate($name))) ? $name : null);
56 56
 			});
57 57
 
58 58
 			# Site title
59 59
 
60
-			$this->addParam('site_title', CONFIG_SITE_TITLE, function (string $title) {
60
+			$this->addParam('site_title', CONFIG_SITE_TITLE, function(string $title) {
61 61
 
62 62
 				return (('' !== $title) ? $title : null);
63 63
 			});
64 64
 
65 65
 			# Site slogan
66 66
 
67
-			$this->addParam('site_slogan', CONFIG_SITE_SLOGAN, function (string $slogan) {
67
+			$this->addParam('site_slogan', CONFIG_SITE_SLOGAN, function(string $slogan) {
68 68
 
69 69
 				return $slogan;
70 70
 			});
71 71
 
72 72
 			# Site status
73 73
 
74
-			$this->addParam('site_status', CONFIG_SITE_STATUS, function (int $status) {
74
+			$this->addParam('site_status', CONFIG_SITE_STATUS, function(int $status) {
75 75
 
76 76
 				return ((false !== ($status = Range\Status::validate($status))) ? $status : null);
77 77
 			});
78 78
 
79 79
 			# Site description
80 80
 
81
-			$this->addParam('site_description', CONFIG_SITE_DESCRIPTION, function (string $description) {
81
+			$this->addParam('site_description', CONFIG_SITE_DESCRIPTION, function(string $description) {
82 82
 
83 83
 				return $description;
84 84
 			});
85 85
 
86 86
 			# Site keywords
87 87
 
88
-			$this->addParam('site_keywords', CONFIG_SITE_KEYWORDS, function (string $keywords) {
88
+			$this->addParam('site_keywords', CONFIG_SITE_KEYWORDS, function(string $keywords) {
89 89
 
90 90
 				return $keywords;
91 91
 			});
92 92
 
93 93
 			# System url
94 94
 
95
-			$this->addParam('system_url', $this->getSystemUrl(), function (string $url) {
95
+			$this->addParam('system_url', $this->getSystemUrl(), function(string $url) {
96 96
 
97 97
 				return ((false !== ($url = Validate::url($url))) ? $url : null);
98 98
 			});
99 99
 
100 100
 			# System email
101 101
 
102
-			$this->addParam('system_email', $this->getSystemEmail(), function (string $email) {
102
+			$this->addParam('system_email', $this->getSystemEmail(), function(string $email) {
103 103
 
104 104
 				return ((false !== ($email = Validate::email($email))) ? $email : null);
105 105
 			});
106 106
 
107 107
 			# System timezone
108 108
 
109
-			$this->addParam('system_timezone', CONFIG_SYSTEM_TIMEZONE, function (string $timezone) {
109
+			$this->addParam('system_timezone', CONFIG_SYSTEM_TIMEZONE, function(string $timezone) {
110 110
 
111 111
 				return ((false !== ($timezone = Timezone::validate($timezone))) ? $timezone : null);
112 112
 			});
113 113
 
114 114
 			# Admin language
115 115
 
116
-			$this->addParam('admin_language', CONFIG_ADMIN_LANGUAGE, function (string $name) {
116
+			$this->addParam('admin_language', CONFIG_ADMIN_LANGUAGE, function(string $name) {
117 117
 
118 118
 				return ((false !== ($name = Extend\Languages::validate($name))) ? $name : null);
119 119
 			});
120 120
 
121 121
 			# Admin template
122 122
 
123
-			$this->addParam('admin_template', CONFIG_ADMIN_TEMPLATE, function (string $name) {
123
+			$this->addParam('admin_template', CONFIG_ADMIN_TEMPLATE, function(string $name) {
124 124
 
125 125
 				return ((false !== ($name = Extend\Templates::validate($name))) ? $name : null);
126 126
 			});
127 127
 
128 128
 			# Admin display entities
129 129
 
130
-			$this->addParam('admin_display_entities', CONFIG_ADMIN_DISPLAY_ENTITIES, function (int $display) {
130
+			$this->addParam('admin_display_entities', CONFIG_ADMIN_DISPLAY_ENTITIES, function(int $display) {
131 131
 
132 132
 				return ((false !== ($display = Range\Display\Entities::validate($display))) ? $display : null);
133 133
 			});
134 134
 
135 135
 			# Admin display files
136 136
 
137
-			$this->addParam('admin_display_files', CONFIG_ADMIN_DISPLAY_FILES, function (int $display) {
137
+			$this->addParam('admin_display_files', CONFIG_ADMIN_DISPLAY_FILES, function(int $display) {
138 138
 
139 139
 				return ((false !== ($display = Range\Display\Files::validate($display))) ? $display : null);
140 140
 			});
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,9 @@  discard block
 block discarded – undo
19 19
 
20 20
 		private function getSystemUrl() : string {
21 21
 
22
-			if (empty($_SERVER['HTTP_HOST'])) return CONFIG_SYSTEM_URL;
22
+			if (empty($_SERVER['HTTP_HOST'])) {
23
+				return CONFIG_SYSTEM_URL;
24
+			}
23 25
 
24 26
 			return ((Request::isSecure() ? 'https://' : 'http://') . $_SERVER['HTTP_HOST']);
25 27
 		}
@@ -30,7 +32,9 @@  discard block
 block discarded – undo
30 32
 
31 33
 		private function getSystemEmail() : string {
32 34
 
33
-			if (empty($_SERVER['HTTP_HOST'])) return CONFIG_SYSTEM_EMAIL;
35
+			if (empty($_SERVER['HTTP_HOST'])) {
36
+				return CONFIG_SYSTEM_EMAIL;
37
+			}
34 38
 
35 39
 			return ('admin@' . $_SERVER['HTTP_HOST']);
36 40
 		}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Install/Controller/Database.php 1 patch
Braces   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -31,21 +31,19 @@  discard block
 block discarded – undo
31 31
 
32 32
 			# Connect to DB
33 33
 
34
-			try { DB::connect($server, $user, $password, $name); }
35
-
36
-			catch (Exception\DBConnect $error) { return 'INSTALL_ERROR_DATABASE_CONNECT'; }
37
-
38
-			catch (Exception\DBCharset $error) { return 'INSTALL_ERROR_DATABASE_CHARSET'; }
39
-
40
-			catch (Exception\DBSelect $error) { return 'INSTALL_ERROR_DATABASE_SELECT'; }
34
+			try { DB::connect($server, $user, $password, $name); } catch (Exception\DBConnect $error) { return 'INSTALL_ERROR_DATABASE_CONNECT'; } catch (Exception\DBCharset $error) { return 'INSTALL_ERROR_DATABASE_CHARSET'; } catch (Exception\DBSelect $error) { return 'INSTALL_ERROR_DATABASE_SELECT'; }
41 35
 
42 36
 			# Create tables
43 37
 
44
-			if (!Install\Utils\Tables::create()) return 'INSTALL_ERROR_DATABASE_TABLES_CREATE';
38
+			if (!Install\Utils\Tables::create()) {
39
+				return 'INSTALL_ERROR_DATABASE_TABLES_CREATE';
40
+			}
45 41
 
46 42
 			# Fill tables
47 43
 
48
-			if (!Install\Utils\Tables::fill()) return 'INSTALL_ERROR_DATABASE_TABLES_FILL';
44
+			if (!Install\Utils\Tables::fill()) {
45
+				return 'INSTALL_ERROR_DATABASE_TABLES_FILL';
46
+			}
49 47
 
50 48
 			# Save system file
51 49
 
@@ -58,7 +56,9 @@  discard block
 block discarded – undo
58 56
 
59 57
 			$system['time'] = REQUEST_TIME;
60 58
 
61
-			if (!Schema::get('System')->save($system)) return 'INSTALL_ERROR_SYSTEM';
59
+			if (!Schema::get('System')->save($system)) {
60
+				return 'INSTALL_ERROR_SYSTEM';
61
+			}
62 62
 
63 63
 			# ------------------------
64 64
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Install/Handler/Check.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
 				$class = ($status ? 'positive' : 'negative'); $icon = ($status ? 'check circle' : 'warning circle');
31 31
 
32
-				$text = Language::get('INSTALL_REQUIREMENT_' . strtoupper($name) . '_' . ($status ? 'SUCCESS' : 'FAIL'));
32
+				$text = Language::get('INSTALL_REQUIREMENT_'.strtoupper($name).'_'.($status ? 'SUCCESS' : 'FAIL'));
33 33
 
34 34
 				$requirements[] = ['class' => $class, 'icon' => $icon, 'text' => $text];
35 35
 			}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Informer/Handler/Information.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 
24 24
 			# Set server entries
25 25
 
26
-			$contents->os_version           = (php_uname('s') . ', ' . php_uname('v'));
26
+			$contents->os_version           = (php_uname('s').', '.php_uname('v'));
27 27
 
28 28
 			$contents->php_version          = phpversion();
29 29
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
 			$contents->debug_mode_class     = (DEBUG_MODE ? 'red' : 'grey');
37 37
 
38
-			$contents->debug_mode_value     = Language::get('INFORMATION_VALUE_DEBUG_MODE_' . (DEBUG_MODE ? 'ON' : 'OFF'));
38
+			$contents->debug_mode_value     = Language::get('INFORMATION_VALUE_DEBUG_MODE_'.(DEBUG_MODE ? 'ON' : 'OFF'));
39 39
 
40 40
 			# Set third-party entries
41 41
 
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
 		private function setPhpEntries(Template\Block $contents) {
54 54
 
55
-			$status_value = function (string $value) { return (Validate::boolean($value) ? 'On' : 'Off'); };
55
+			$status_value = function(string $value) { return (Validate::boolean($value) ? 'On' : 'Off'); };
56 56
 
57 57
 			# Set errors entries
58 58
 
@@ -81,14 +81,14 @@  discard block
 block discarded – undo
81 81
 
82 82
 		private function setDiagnosticsEntries(Template\Block $contents) {
83 83
 
84
-			$extension_value = function (bool $value) {
84
+			$extension_value = function(bool $value) {
85 85
 
86
-				return Language::get('INFORMATION_VALUE_EXTENSION_' . (!$value ? 'NOT_' : '') . 'LOADED' );
86
+				return Language::get('INFORMATION_VALUE_EXTENSION_'.(!$value ? 'NOT_' : '').'LOADED');
87 87
 			};
88 88
 
89
-			$dir_value = function (bool $value) {
89
+			$dir_value = function(bool $value) {
90 90
 
91
-				return Language::get('INFORMATION_VALUE_DIR_' . (!$value ? 'NOT_' : '') . 'WRITABLE' );
91
+				return Language::get('INFORMATION_VALUE_DIR_'.(!$value ? 'NOT_' : '').'WRITABLE');
92 92
 			};
93 93
 
94 94
 			# Get loops
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
 			foreach (Install::getExtensions() as $name => $status) {
101 101
 
102
-				$name = Language::get('INFORMATION_ROW_EXTENSION_' . strtoupper($name));
102
+				$name = Language::get('INFORMATION_ROW_EXTENSION_'.strtoupper($name));
103 103
 
104 104
 				$class = ($status ? 'green' : 'red'); $value = $extension_value($status);
105 105
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
 			foreach (Install::getDirs() as $name => $status) {
112 112
 
113
-				$name = Language::get('INFORMATION_ROW_DIR_' . strtoupper($name));
113
+				$name = Language::get('INFORMATION_ROW_DIR_'.strtoupper($name));
114 114
 
115 115
 				$class = ($status ? 'green' : 'red'); $value = $dir_value($status);
116 116
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Informer/Handler/Dashboard.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 
34 34
 			# Set server entries
35 35
 
36
-			$contents->os_version           = (php_uname('s') . ', ' . php_uname('v'));
36
+			$contents->os_version           = (php_uname('s').', '.php_uname('v'));
37 37
 
38 38
 			$contents->php_version          = phpversion();
39 39
 
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -52,15 +52,21 @@
 block discarded – undo
52 52
 
53 53
 			# Check if server meets system requirements
54 54
 
55
-			if (!Install::checkRequirements()) Messages::set('error', Language::get('DASHBOARD_MESSAGE_INSTALL_REQUIREMENTS'));
55
+			if (!Install::checkRequirements()) {
56
+				Messages::set('error', Language::get('DASHBOARD_MESSAGE_INSTALL_REQUIREMENTS'));
57
+			}
56 58
 
57 59
 			# Check if install file exists
58 60
 
59
-			if (Install::checkFile()) Messages::set('warning', Language::get('DASHBOARD_MESSAGE_INSTALL_FILE'));
61
+			if (Install::checkFile()) {
62
+				Messages::set('warning', Language::get('DASHBOARD_MESSAGE_INSTALL_FILE'));
63
+			}
60 64
 
61 65
 			# Check if settings file is loaded
62 66
 
63
-			if (!Settings::areLoaded()) Messages::set('info', Language::get('DASHBOARD_MESSAGE_SETTINGS_FILE'));
67
+			if (!Settings::areLoaded()) {
68
+				Messages::set('info', Language::get('DASHBOARD_MESSAGE_SETTINGS_FILE'));
69
+			}
64 70
 
65 71
 			# ------------------------
66 72
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Entitizer/Controller/Variable.php 1 patch
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -29,17 +29,25 @@  discard block
 block discarded – undo
29 29
 
30 30
 			# Validate name
31 31
 
32
-			if (false === ($name = Validate::templateComponentName($name))) return ['name', 'VARIABLE_ERROR_NAME_INVALID'];
32
+			if (false === ($name = Validate::templateComponentName($name))) {
33
+				return ['name', 'VARIABLE_ERROR_NAME_INVALID'];
34
+			}
33 35
 
34 36
 			# Check name reserved
35 37
 
36
-			if (false !== Template::getGlobal($name)) return ['name', 'VARIABLE_ERROR_NAME_RESERVED'];
38
+			if (false !== Template::getGlobal($name)) {
39
+				return ['name', 'VARIABLE_ERROR_NAME_RESERVED'];
40
+			}
37 41
 
38 42
 			# Check name exists
39 43
 
40
-			if (false === ($check_name = $this->variable->check($name, 'name'))) return 'VARIABLE_ERROR_MODIFY';
44
+			if (false === ($check_name = $this->variable->check($name, 'name'))) {
45
+				return 'VARIABLE_ERROR_MODIFY';
46
+			}
41 47
 
42
-			if ($check_name === 1) return ['name', 'VARIABLE_ERROR_NAME_DUPLICATE'];
48
+			if ($check_name === 1) {
49
+				return ['name', 'VARIABLE_ERROR_NAME_DUPLICATE'];
50
+			}
43 51
 
44 52
 			# Modify variable
45 53
 
@@ -51,7 +59,9 @@  discard block
 block discarded – undo
51 59
 
52 60
 			$modifier = ((0 === $this->variable->id) ? 'create' : 'edit');
53 61
 
54
-			if (!$this->variable->$modifier($data)) return 'VARIABLE_ERROR_MODIFY';
62
+			if (!$this->variable->$modifier($data)) {
63
+				return 'VARIABLE_ERROR_MODIFY';
64
+			}
55 65
 
56 66
 			# ------------------------
57 67
 
Please login to merge, or discard this patch.