Passed
Pull Request — master (#11)
by Anton
03:24
created
www/engine/Framework/Engine.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -10,13 +10,13 @@  discard block
 block discarded – undo
10 10
 
11 11
 		private static function parseContents(string $contents, Throwable $exc) {
12 12
 
13
-		   $contents = str_replace('$message$',            $exc->getMessage(),                  $contents);
13
+		   $contents = str_replace('$message$', $exc->getMessage(), $contents);
14 14
 
15
-		   $contents = str_replace('$file$',               $exc->getFile(),                     $contents);
15
+		   $contents = str_replace('$file$', $exc->getFile(), $contents);
16 16
 
17
-		   $contents = str_replace('$line$',               $exc->getLine(),                     $contents);
17
+		   $contents = str_replace('$line$', $exc->getLine(), $contents);
18 18
 
19
-		   $contents = str_replace('$trace$',              nl2br($exc->getTraceAsString()),     $contents);
19
+		   $contents = str_replace('$trace$', nl2br($exc->getTraceAsString()), $contents);
20 20
 
21 21
 		   # ------------------------
22 22
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
 			# Load template
56 56
 
57
-			$file_name = (DIR_TEMPLATES . 'Exception.tpl');
57
+			$file_name = (DIR_TEMPLATES.'Exception.tpl');
58 58
 
59 59
 			if (false === ($contents = @file_get_contents($file_name))) $output = nl2br($exc);
60 60
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 			header('Pragma: no-cache');
72 72
 
73
-			header(getenv('SERVER_PROTOCOL') . ' 500 Internal Server Error', true, 500);
73
+			header(getenv('SERVER_PROTOCOL').' 500 Internal Server Error', true, 500);
74 74
 
75 75
 			header('Content-type: text/html; charset=UTF-8');
76 76
 
Please login to merge, or discard this patch.
Braces   +23 added lines, -9 removed lines patch added patch discarded remove patch
@@ -29,17 +29,29 @@  discard block
 block discarded – undo
29 29
 
30 30
 		public static function getIP() {
31 31
 
32
-			if (!empty(getenv('HTTP_CLIENT_IP')))           return getenv('HTTP_CLIENT_IP');
32
+			if (!empty(getenv('HTTP_CLIENT_IP'))) {
33
+				return getenv('HTTP_CLIENT_IP');
34
+			}
33 35
 
34
-			if (!empty(getenv('HTTP_X_FORWARDED_FOR')))     return getenv('HTTP_X_FORWARDED_FOR');
36
+			if (!empty(getenv('HTTP_X_FORWARDED_FOR'))) {
37
+				return getenv('HTTP_X_FORWARDED_FOR');
38
+			}
35 39
 
36
-			if (!empty(getenv('HTTP_X_FORWARDED')))         return getenv('HTTP_X_FORWARDED');
40
+			if (!empty(getenv('HTTP_X_FORWARDED'))) {
41
+				return getenv('HTTP_X_FORWARDED');
42
+			}
37 43
 
38
-			if (!empty(getenv('HTTP_FORWARDED_FOR')))       return getenv('HTTP_FORWARDED_FOR');
44
+			if (!empty(getenv('HTTP_FORWARDED_FOR'))) {
45
+				return getenv('HTTP_FORWARDED_FOR');
46
+			}
39 47
 
40
-			if (!empty(getenv('HTTP_FORWARDED')))           return getenv('HTTP_FORWARDED');
48
+			if (!empty(getenv('HTTP_FORWARDED'))) {
49
+				return getenv('HTTP_FORWARDED');
50
+			}
41 51
 
42
-			if (!empty(getenv('REMOTE_ADDR')))              return getenv('REMOTE_ADDR');
52
+			if (!empty(getenv('REMOTE_ADDR'))) {
53
+				return getenv('REMOTE_ADDR');
54
+			}
43 55
 
44 56
 			# ------------------------
45 57
 
@@ -56,9 +68,11 @@  discard block
 block discarded – undo
56 68
 
57 69
 			$file_name = (DIR_TEMPLATES . 'Exception.tpl');
58 70
 
59
-			if (false === ($contents = @file_get_contents($file_name))) $output = nl2br($exc);
60
-
61
-			else $output = self::parseContents($contents, $exc);
71
+			if (false === ($contents = @file_get_contents($file_name))) {
72
+				$output = nl2br($exc);
73
+			} else {
74
+				$output = self::parseContents($contents, $exc);
75
+			}
62 76
 
63 77
 			# Set headers
64 78
 
Please login to merge, or discard this patch.
www/engine/System/Includes/Constants.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -2,68 +2,68 @@
 block discarded – undo
2 2
 
3 3
 # Cadmium
4 4
 
5
-define('CADMIUM_NAME',                              'Cadmium CMS');
6
-define('CADMIUM_HOME',                              'http://cadmium-cms.com');
5
+define('CADMIUM_NAME', 'Cadmium CMS');
6
+define('CADMIUM_HOME', 'http://cadmium-cms.com');
7 7
 
8
-define('CADMIUM_VERSION',                           '0.4.0');
9
-define('CADMIUM_COPY',                              '2016');
8
+define('CADMIUM_VERSION', '0.4.0');
9
+define('CADMIUM_COPY', '2016');
10 10
 
11 11
 # External
12 12
 
13
-define('JQUERY_VERSION',                            '3.1.1');
14
-define('SEMANTIC_UI_VERSION',                       '2.2.6');
15
-define('CKEDITOR_VERSION',                          '4.5.11');
13
+define('JQUERY_VERSION', '3.1.1');
14
+define('SEMANTIC_UI_VERSION', '2.2.6');
15
+define('CKEDITOR_VERSION', '4.5.11');
16 16
 
17 17
 # Sections
18 18
 
19
-define('SECTION_ADMIN',                             'admin');
20
-define('SECTION_SITE',                              'site');
19
+define('SECTION_ADMIN', 'admin');
20
+define('SECTION_SITE', 'site');
21 21
 
22 22
 # Filemanager types
23 23
 
24
-define('FILEMANAGER_TYPE_DIR',                      'dir');
25
-define('FILEMANAGER_TYPE_FILE',                     'file');
24
+define('FILEMANAGER_TYPE_DIR', 'dir');
25
+define('FILEMANAGER_TYPE_FILE', 'file');
26 26
 
27 27
 # Access
28 28
 
29
-define('ACCESS_PUBLIC',                             0);
30
-define('ACCESS_REGISTERED',                         1);
31
-define('ACCESS_ADMINISTRATOR',                      2);
29
+define('ACCESS_PUBLIC', 0);
30
+define('ACCESS_REGISTERED', 1);
31
+define('ACCESS_ADMINISTRATOR', 2);
32 32
 
33 33
 # Frequency
34 34
 
35
-define('FREQUENCY_ALWAYS',                          'always');
36
-define('FREQUENCY_HOURLY',                          'hourly');
37
-define('FREQUENCY_DAILY',                           'daily');
38
-define('FREQUENCY_WEEKLY',                          'weekly');
39
-define('FREQUENCY_MONTHLY',                         'monthly');
40
-define('FREQUENCY_YEARLY',                          'yearly');
41
-define('FREQUENCY_NEVER',                           'never');
35
+define('FREQUENCY_ALWAYS', 'always');
36
+define('FREQUENCY_HOURLY', 'hourly');
37
+define('FREQUENCY_DAILY', 'daily');
38
+define('FREQUENCY_WEEKLY', 'weekly');
39
+define('FREQUENCY_MONTHLY', 'monthly');
40
+define('FREQUENCY_YEARLY', 'yearly');
41
+define('FREQUENCY_NEVER', 'never');
42 42
 
43 43
 # Rank
44 44
 
45
-define('RANK_GUEST',                                0);
46
-define('RANK_USER',                                 1);
47
-define('RANK_ADMINISTRATOR',                        2);
45
+define('RANK_GUEST', 0);
46
+define('RANK_USER', 1);
47
+define('RANK_ADMINISTRATOR', 2);
48 48
 
49 49
 # Sex
50 50
 
51
-define('SEX_NOT_SELECTED',                          0);
52
-define('SEX_MALE',                                  1);
53
-define('SEX_FEMALE',                                2);
51
+define('SEX_NOT_SELECTED', 0);
52
+define('SEX_MALE', 1);
53
+define('SEX_FEMALE', 2);
54 54
 
55 55
 # Status
56 56
 
57
-define('STATUS_ONLINE',                             0);
58
-define('STATUS_MAINTENANCE',                        1);
59
-define('STATUS_UPDATE',                             2);
57
+define('STATUS_ONLINE', 0);
58
+define('STATUS_MAINTENANCE', 1);
59
+define('STATUS_UPDATE', 2);
60 60
 
61 61
 # Target
62 62
 
63
-define('TARGET_SELF',                               0);
64
-define('TARGET_BLANK',                              1);
63
+define('TARGET_SELF', 0);
64
+define('TARGET_BLANK', 1);
65 65
 
66 66
 # Visibility
67 67
 
68
-define('VISIBILITY_DRAFT',                          0);
69
-define('VISIBILITY_PUBLISHED',                      1);
68
+define('VISIBILITY_DRAFT', 0);
69
+define('VISIBILITY_PUBLISHED', 1);
Please login to merge, or discard this patch.
www/engine/System/Includes/Regex.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -2,16 +2,16 @@
 block discarded – undo
2 2
 
3 3
 # Regular expressions
4 4
 
5
-define('REGEX_MAP_ITEM_PATH',                       '/^[a-zA-Z0-9_\-\+\.\,\'\*\(\)\[\]:;!$%~]+$/');
6
-define('REGEX_MAP_ITEM_HANDLER',                    '/^[A-Z][a-zA-Z0-9]*$/');
5
+define('REGEX_MAP_ITEM_PATH', '/^[a-zA-Z0-9_\-\+\.\,\'\*\(\)\[\]:;!$%~]+$/');
6
+define('REGEX_MAP_ITEM_HANDLER', '/^[A-Z][a-zA-Z0-9]*$/');
7 7
 
8
-define('REGEX_ADDON_NAME',                          '/^[A-Z0-9][a-zA-Z0-9]*$/');
9
-define('REGEX_LANGUAGE_NAME',                       '/^[a-z][a-z]-[A-Z][A-Z]$/');
10
-define('REGEX_TEMPLATE_NAME',                       '/^[A-Z0-9][a-zA-Z0-9]*$/');
8
+define('REGEX_ADDON_NAME', '/^[A-Z0-9][a-zA-Z0-9]*$/');
9
+define('REGEX_LANGUAGE_NAME', '/^[a-z][a-z]-[A-Z][A-Z]$/');
10
+define('REGEX_TEMPLATE_NAME', '/^[A-Z0-9][a-zA-Z0-9]*$/');
11 11
 
12
-define('REGEX_USER_AUTH_CODE',                      '/^[a-zA-Z0-9]{40}$/');
12
+define('REGEX_USER_AUTH_CODE', '/^[a-zA-Z0-9]{40}$/');
13 13
 
14
-define('REGEX_USER_NAME',                           '/^(?!_)(?!.*_$)(?!.*_{2,})[a-zA-Z0-9_]+$/');
15
-define('REGEX_USER_PASSWORD',                       '/^.+$/');
14
+define('REGEX_USER_NAME', '/^(?!_)(?!.*_$)(?!.*_{2,})[a-zA-Z0-9_]+$/');
15
+define('REGEX_USER_PASSWORD', '/^.+$/');
16 16
 
17
-define('REGEX_FILE_NAME',                           '/^[^\/?%*:|"<>\\\]+$/');
17
+define('REGEX_FILE_NAME', '/^[^\/?%*:|"<>\\\]+$/');
Please login to merge, or discard this patch.
www/engine/System/Classes/Addons/Contact/Handler.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 
36 36
 			# Handle form
37 37
 
38
-			if ($this->form->handle(new Controller)) Request::redirect(INSTALL_PATH . '/contact?submitted');
38
+			if ($this->form->handle(new Controller)) Request::redirect(INSTALL_PATH.'/contact?submitted');
39 39
 
40 40
 			# Display success message
41 41
 
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,11 +35,15 @@
 block discarded – undo
35 35
 
36 36
 			# Handle form
37 37
 
38
-			if ($this->form->handle(new Controller)) Request::redirect(INSTALL_PATH . '/contact?submitted');
38
+			if ($this->form->handle(new Controller)) {
39
+				Request::redirect(INSTALL_PATH . '/contact?submitted');
40
+			}
39 41
 
40 42
 			# Display success message
41 43
 
42
-			if (false !== Request::get('submitted')) Messages::set('success', Language::get('CONTACT_SUCCESS_SEND'));
44
+			if (false !== Request::get('submitted')) {
45
+				Messages::set('success', Language::get('CONTACT_SUCCESS_SEND'));
46
+			}
43 47
 
44 48
 			# ------------------------
45 49
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Addons/Contact/Controller.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
 			# Send mail
28 28
 
29
-			$to = Settings::get('system_email'); $subject = (Settings::get('site_title') . ' | Contact form message');
29
+			$to = Settings::get('system_email'); $subject = (Settings::get('site_title').' | Contact form message');
30 30
 
31 31
 			if (!Mailer::send($to, $name, $email, $email, $subject, $message)) return 'CONTACT_ERROR_SEND';
32 32
 
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,15 +20,21 @@
 block discarded – undo
20 20
 
21 21
 			# Validate values
22 22
 
23
-			if (false === ($email = Validate::userEmail($email))) return ['email', 'CONTACT_ERROR_EMAIL_INVALID'];
23
+			if (false === ($email = Validate::userEmail($email))) {
24
+				return ['email', 'CONTACT_ERROR_EMAIL_INVALID'];
25
+			}
24 26
 
25
-			if (false === Security::checkCaptcha($captcha)) return ['captcha', 'CONTACT_ERROR_CAPTCHA_INCORRECT'];
27
+			if (false === Security::checkCaptcha($captcha)) {
28
+				return ['captcha', 'CONTACT_ERROR_CAPTCHA_INCORRECT'];
29
+			}
26 30
 
27 31
 			# Send mail
28 32
 
29 33
 			$to = Settings::get('system_email'); $subject = (Settings::get('site_title') . ' | Contact form message');
30 34
 
31
-			if (!Mailer::send($to, $name, $email, $email, $subject, $message)) return 'CONTACT_ERROR_SEND';
35
+			if (!Mailer::send($to, $name, $email, $email, $subject, $message)) {
36
+				return 'CONTACT_ERROR_SEND';
37
+			}
32 38
 
33 39
 			# ------------------------
34 40
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Dispatcher.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 
15 15
 			if (null === ($data = Schema::get('System')->load())) {
16 16
 
17
-				Request::redirect(INSTALL_PATH . '/install.php');
17
+				Request::redirect(INSTALL_PATH.'/install.php');
18 18
 			}
19 19
 
20 20
 			# Connect to database
Please login to merge, or discard this patch.
www/engine/System/Classes/Frames/Admin/Area/Auth.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 
15 15
 			# Check auth
16 16
 
17
-			if (Modules\Auth::check()) Request::redirect(INSTALL_PATH . '/admin');
17
+			if (Modules\Auth::check()) Request::redirect(INSTALL_PATH.'/admin');
18 18
 
19 19
 			# Handle request
20 20
 
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,11 +14,15 @@
 block discarded – undo
14 14
 
15 15
 			# Check auth
16 16
 
17
-			if (Modules\Auth::check()) Request::redirect(INSTALL_PATH . '/admin');
17
+			if (Modules\Auth::check()) {
18
+				Request::redirect(INSTALL_PATH . '/admin');
19
+			}
18 20
 
19 21
 			# Handle request
20 22
 
21
-			if (Template::isBlock($result = $this->handle())) return $this->displayPage($result, STATUS_CODE_401);
23
+			if (Template::isBlock($result = $this->handle())) {
24
+				return $this->displayPage($result, STATUS_CODE_401);
25
+			}
22 26
 
23 27
 			# ------------------------
24 28
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Frames/Admin/Area/Authorized.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 
17 17
 			if (!Modules\Auth::check() || ((false !== Request::get('logout')) && Modules\Auth::logout())) {
18 18
 
19
-				Request::redirect(INSTALL_PATH . '/admin/login');
19
+				Request::redirect(INSTALL_PATH.'/admin/login');
20 20
 			}
21 21
 
22 22
 			# Handle request
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,9 +19,13 @@
 block discarded – undo
19 19
 
20 20
 			# Handle request
21 21
 
22
-			if (Template::isBlock($result = $this->handle())) return $this->displayPage($result, STATUS_CODE_200);
22
+			if (Template::isBlock($result = $this->handle())) {
23
+				return $this->displayPage($result, STATUS_CODE_200);
24
+			}
23 25
 
24
-			if (Ajax::isResponse($result)) return Ajax::output($result);
26
+			if (Ajax::isResponse($result)) {
27
+				return Ajax::output($result);
28
+			}
25 29
 
26 30
 			# ------------------------
27 31
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Frames/Admin/Section.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 
24 24
 		private function getLayout(Template\Block $contents) {
25 25
 
26
-			$layout = View::get('Layouts/' . $this->layout);
26
+			$layout = View::get('Layouts/'.$this->layout);
27 27
 
28 28
 			# Set menu and user
29 29
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 
83 83
 		protected function displayPage(Template\Block $contents, int $status = STATUS_CODE_200) {
84 84
 
85
-			$page = View::get('Main/' . $this->layout);
85
+			$page = View::get('Main/'.$this->layout);
86 86
 
87 87
 			# Set language
88 88
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
 			# Set title
92 92
 
93
-			$page->title = ((('' !== $this->title) ? (Language::get($this->title) . ' | ') : '') . CADMIUM_NAME);
93
+			$page->title = ((('' !== $this->title) ? (Language::get($this->title).' | ') : '').CADMIUM_NAME);
94 94
 
95 95
 			# Set layout
96 96
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,9 @@
 block discarded – undo
111 111
 
112 112
 				$ips = preg_split('/ +/', CONFIG_ADMIN_IP, -1, PREG_SPLIT_NO_EMPTY);
113 113
 
114
-				if (!in_array(REQUEST_CLIENT_IP, $ips, true)) return Status::error404();
114
+				if (!in_array(REQUEST_CLIENT_IP, $ips, true)) {
115
+					return Status::error404();
116
+				}
115 117
 			}
116 118
 
117 119
 			# ------------------------
Please login to merge, or discard this patch.