Passed
Pull Request — master (#11)
by Anton
03:24
created
www/engine/Framework/Classes/Form/Form.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@
 block discarded – undo
181 181
 
182 182
 			foreach ($this->fields as $field) {
183 183
 
184
-				$block->setBlock(('field_' . $field->getName()), $field->getBlock());
184
+				$block->setBlock(('field_'.$field->getName()), $field->getBlock());
185 185
 			}
186 186
 		}
187 187
 	}
Please login to merge, or discard this patch.
Braces   +20 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,7 +23,9 @@  discard block
 block discarded – undo
23 23
 
24 24
 		private function addField(Form\Field $field) {
25 25
 
26
-			if ($this->posted || ('' === ($key = $field->getKey()))) return false;
26
+			if ($this->posted || ('' === ($key = $field->getKey()))) {
27
+				return false;
28
+			}
27 29
 
28 30
 			$this->fields[$key] = $field;
29 31
 
@@ -38,7 +40,9 @@  discard block
 block discarded – undo
38 40
 
39 41
 		public function __construct(string $name = '') {
40 42
 
41
-			if (preg_match(REGEX_FORM_NAME, $name)) $this->name = $name;
43
+			if (preg_match(REGEX_FORM_NAME, $name)) {
44
+				$this->name = $name;
45
+			}
42 46
 		}
43 47
 
44 48
 		/**
@@ -90,9 +94,15 @@  discard block
 block discarded – undo
90 94
 
91 95
 			foreach ($this->fields as $field) {
92 96
 
93
-				if (($field instanceof Form\Field\Checkbox) || $field->disabled) continue;
97
+				if (($field instanceof Form\Field\Checkbox) || $field->disabled) {
98
+					continue;
99
+				}
94 100
 
95
-				if (false !== Request::post($field->getName())) $check = true; else return false;
101
+				if (false !== Request::post($field->getName())) {
102
+					$check = true;
103
+				} else {
104
+					return false;
105
+				}
96 106
 			}
97 107
 
98 108
 			# ------------------------
@@ -108,7 +118,9 @@  discard block
 block discarded – undo
108 118
 
109 119
 		public function post() {
110 120
 
111
-			if ($this->posted || !$this->check()) return false;
121
+			if ($this->posted || !$this->check()) {
122
+				return false;
123
+			}
112 124
 
113 125
 			$post = []; $errors = false;
114 126
 
@@ -116,7 +128,9 @@  discard block
 block discarded – undo
116 128
 
117 129
 				$field->post(); $post[$field->getKey()] = $field->getValue();
118 130
 
119
-				if ($field->error) $errors = true;
131
+				if ($field->error) {
132
+					$errors = true;
133
+				}
120 134
 			}
121 135
 
122 136
 			$this->posted = true; $this->errors = $errors;
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 		/**
19 19
 		 * Add a field to the form
20 20
 		 *
21
-		 * @return true if the field was successfully added, otherwise false
21
+		 * @return boolean if the field was successfully added, otherwise false
22 22
 		 */
23 23
 
24 24
 		private function addField(Form\Field $field) : bool {
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 		/**
45 45
 		 * Add a text field
46 46
 		 *
47
-		 * @return true if the field was successfully added, otherwise false
47
+		 * @return boolean if the field was successfully added, otherwise false
48 48
 		 */
49 49
 
50 50
 		public function addText(string $key, string $value = '',
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 		/**
58 58
 		 * Add a select field
59 59
 		 *
60
-		 * @return true if the field was successfully added, otherwise false
60
+		 * @return boolean if the field was successfully added, otherwise false
61 61
 		 */
62 62
 
63 63
 		public function addSelect(string $key, string $value = '',
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 		/**
71 71
 		 * Add a checkbox field
72 72
 		 *
73
-		 * @return true if the field was successfully added, otherwise false
73
+		 * @return boolean if the field was successfully added, otherwise false
74 74
 		 */
75 75
 
76 76
 		public function addCheckbox(string $key, string $value = '') : bool {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 		/**
82 82
 		 * Check if valid POST data has been recieved
83 83
 		 *
84
-		 * @return true if the data has been recieved, otherwise false
84
+		 * @return boolean if the data has been recieved, otherwise false
85 85
 		 */
86 86
 
87 87
 		public function check() : bool {
Please login to merge, or discard this patch.
www/engine/Framework/Classes/Form/Field/Checkbox.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,9 @@
 block discarded – undo
53 53
 
54 54
 			$tag->setAttribute('type', 'checkbox');
55 55
 
56
-			if ($this->value) $tag->setAttribute('checked', 'checked');
56
+			if ($this->value) {
57
+				$tag->setAttribute('checked', 'checked');
58
+			}
57 59
 
58 60
 			# ------------------------
59 61
 
Please login to merge, or discard this patch.
www/engine/Framework/Classes/Explorer/Explorer.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 
24 24
 					if (($name === '.') || ($name === '..')) continue;
25 25
 
26
-					if (@$checker($dir_name . $name)) yield $name;
26
+					if (@$checker($dir_name.$name)) yield $name;
27 27
 				}
28 28
 
29 29
 				closedir($handler);
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
 				foreach (array_diff($list, ['.', '..']) as $name) {
95 95
 
96
-					$name = ($dir_name . '/' . $name);
96
+					$name = ($dir_name.'/'.$name);
97 97
 
98 98
 					if (@is_dir($name)) self::removeDir($name, true);
99 99
 
Please login to merge, or discard this patch.
Braces   +23 added lines, -9 removed lines patch added patch discarded remove patch
@@ -21,9 +21,13 @@  discard block
 block discarded – undo
21 21
 
22 22
 				while (false !== ($name = readdir($handler))) {
23 23
 
24
-					if (($name === '.') || ($name === '..')) continue;
24
+					if (($name === '.') || ($name === '..')) {
25
+						continue;
26
+					}
25 27
 
26
-					if (@$checker($dir_name . $name)) yield $name;
28
+					if (@$checker($dir_name . $name)) {
29
+						yield $name;
30
+					}
27 31
 				}
28 32
 
29 33
 				closedir($handler);
@@ -36,7 +40,9 @@  discard block
 block discarded – undo
36 40
 
37 41
 		private static function getInfo(string $file_name, int $param, bool $check_exists = true) {
38 42
 
39
-			if ($check_exists && !self::isFile($file_name)) return false;
43
+			if ($check_exists && !self::isFile($file_name)) {
44
+				return false;
45
+			}
40 46
 
41 47
 			return pathinfo($file_name, $param);
42 48
 		}
@@ -95,9 +101,11 @@  discard block
 block discarded – undo
95 101
 
96 102
 					$name = ($dir_name . '/' . $name);
97 103
 
98
-					if (@is_dir($name)) self::removeDir($name, true);
99
-
100
-					else if (@is_file($name)) self::removeFile($name);
104
+					if (@is_dir($name)) {
105
+						self::removeDir($name, true);
106
+					} else if (@is_file($name)) {
107
+						self::removeFile($name);
108
+					}
101 109
 				}
102 110
 			}
103 111
 
@@ -123,7 +131,9 @@  discard block
 block discarded – undo
123 131
 
124 132
 		public static function iterateDirs(string $dir_name) {
125 133
 
126
-			foreach (self::getList($dir_name, 'is_dir') as $name) yield $name;
134
+			foreach (self::getList($dir_name, 'is_dir') as $name) {
135
+				yield $name;
136
+			}
127 137
 		}
128 138
 
129 139
 		/**
@@ -132,7 +142,9 @@  discard block
 block discarded – undo
132 142
 
133 143
 		public static function iterateFiles(string $dir_name) {
134 144
 
135
-			foreach (self::getList($dir_name, 'is_file') as $name) yield $name;
145
+			foreach (self::getList($dir_name, 'is_file') as $name) {
146
+				yield $name;
147
+			}
136 148
 		}
137 149
 
138 150
 		/**
@@ -238,7 +250,9 @@  discard block
 block discarded – undo
238 250
 
239 251
 		public static function include(string $file_name) {
240 252
 
241
-			if ((strtolower(self::getExtension($file_name)) !== 'php')) return false;
253
+			if ((strtolower(self::getExtension($file_name)) !== 'php')) {
254
+				return false;
255
+			}
242 256
 
243 257
 			return @include $file_name;
244 258
 		}
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 		/**
65 65
 		 * Create a directory
66 66
 		 *
67
-		 * @return true on success or false on failure
67
+		 * @return boolean on success or false on failure
68 68
 		 */
69 69
 
70 70
 		public static function createDir(string $dir_name, int $mode = 0755) : bool {
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 		/**
76 76
 		 * Create a file
77 77
 		 *
78
-		 * @return true on success or false on failure
78
+		 * @return boolean on success or false on failure
79 79
 		 */
80 80
 
81 81
 		public static function createFile(string $file_name) : bool {
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 		/**
87 87
 		 * Remove a directory
88 88
 		 *
89
-		 * @return true on success or false on failure
89
+		 * @return boolean on success or false on failure
90 90
 		 */
91 91
 
92 92
 		public static function removeDir(string $dir_name, bool $recursive = false) : bool {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 		/**
112 112
 		 * Remove a file
113 113
 		 *
114
-		 * @return true on success or false on failure
114
+		 * @return boolean on success or false on failure
115 115
 		 */
116 116
 
117 117
 		public static function removeFile(string $file_name) : bool {
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 		/**
192 192
 		 * Get an extnesion of a file
193 193
 		 *
194
-		 * @return the string or false if check_exists is true and the file does not actually exists
194
+		 * @return string string or false if check_exists is true and the file does not actually exists
195 195
 		 */
196 196
 
197 197
 		public static function getExtension(string $file_name, bool $check_exists = true) {
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 		/**
214 214
 		 * Get file contents
215 215
 		 *
216
-		 * @return the read data or false on failure
216
+		 * @return string read data or false on failure
217 217
 		 */
218 218
 
219 219
 		public static function getContents(string $file_name) {
Please login to merge, or discard this patch.
www/engine/Framework/Classes/JSON/JSON.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,9 @@  discard block
 block discarded – undo
41 41
 
42 42
 		public static function load(string $file_name) {
43 43
 
44
-			if (false === ($contents = Explorer::getContents($file_name))) return null;
44
+			if (false === ($contents = Explorer::getContents($file_name))) {
45
+				return null;
46
+			}
45 47
 
46 48
 			return self::parse($contents);
47 49
 		}
@@ -54,7 +56,9 @@  discard block
 block discarded – undo
54 56
 
55 57
 		public static function save(string $file_name, $value) {
56 58
 
57
-			if (false === ($value = self::stringify($value))) return false;
59
+			if (false === ($value = self::stringify($value))) {
60
+				return false;
61
+			}
58 62
 
59 63
 			return Explorer::putContents($file_name, $value);
60 64
 		}
Please login to merge, or discard this patch.
www/engine/Framework/Engine.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -10,13 +10,13 @@  discard block
 block discarded – undo
10 10
 
11 11
 		private static function parseContents(string $contents, Throwable $exc) {
12 12
 
13
-		   $contents = str_replace('$message$',            $exc->getMessage(),                  $contents);
13
+		   $contents = str_replace('$message$', $exc->getMessage(), $contents);
14 14
 
15
-		   $contents = str_replace('$file$',               $exc->getFile(),                     $contents);
15
+		   $contents = str_replace('$file$', $exc->getFile(), $contents);
16 16
 
17
-		   $contents = str_replace('$line$',               $exc->getLine(),                     $contents);
17
+		   $contents = str_replace('$line$', $exc->getLine(), $contents);
18 18
 
19
-		   $contents = str_replace('$trace$',              nl2br($exc->getTraceAsString()),     $contents);
19
+		   $contents = str_replace('$trace$', nl2br($exc->getTraceAsString()), $contents);
20 20
 
21 21
 		   # ------------------------
22 22
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
 			# Load template
56 56
 
57
-			$file_name = (DIR_TEMPLATES . 'Exception.tpl');
57
+			$file_name = (DIR_TEMPLATES.'Exception.tpl');
58 58
 
59 59
 			if (false === ($contents = @file_get_contents($file_name))) $output = nl2br($exc);
60 60
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 			header('Pragma: no-cache');
72 72
 
73
-			header(getenv('SERVER_PROTOCOL') . ' 500 Internal Server Error', true, 500);
73
+			header(getenv('SERVER_PROTOCOL').' 500 Internal Server Error', true, 500);
74 74
 
75 75
 			header('Content-type: text/html; charset=UTF-8');
76 76
 
Please login to merge, or discard this patch.
Braces   +23 added lines, -9 removed lines patch added patch discarded remove patch
@@ -29,17 +29,29 @@  discard block
 block discarded – undo
29 29
 
30 30
 		public static function getIP() {
31 31
 
32
-			if (!empty(getenv('HTTP_CLIENT_IP')))           return getenv('HTTP_CLIENT_IP');
32
+			if (!empty(getenv('HTTP_CLIENT_IP'))) {
33
+				return getenv('HTTP_CLIENT_IP');
34
+			}
33 35
 
34
-			if (!empty(getenv('HTTP_X_FORWARDED_FOR')))     return getenv('HTTP_X_FORWARDED_FOR');
36
+			if (!empty(getenv('HTTP_X_FORWARDED_FOR'))) {
37
+				return getenv('HTTP_X_FORWARDED_FOR');
38
+			}
35 39
 
36
-			if (!empty(getenv('HTTP_X_FORWARDED')))         return getenv('HTTP_X_FORWARDED');
40
+			if (!empty(getenv('HTTP_X_FORWARDED'))) {
41
+				return getenv('HTTP_X_FORWARDED');
42
+			}
37 43
 
38
-			if (!empty(getenv('HTTP_FORWARDED_FOR')))       return getenv('HTTP_FORWARDED_FOR');
44
+			if (!empty(getenv('HTTP_FORWARDED_FOR'))) {
45
+				return getenv('HTTP_FORWARDED_FOR');
46
+			}
39 47
 
40
-			if (!empty(getenv('HTTP_FORWARDED')))           return getenv('HTTP_FORWARDED');
48
+			if (!empty(getenv('HTTP_FORWARDED'))) {
49
+				return getenv('HTTP_FORWARDED');
50
+			}
41 51
 
42
-			if (!empty(getenv('REMOTE_ADDR')))              return getenv('REMOTE_ADDR');
52
+			if (!empty(getenv('REMOTE_ADDR'))) {
53
+				return getenv('REMOTE_ADDR');
54
+			}
43 55
 
44 56
 			# ------------------------
45 57
 
@@ -56,9 +68,11 @@  discard block
 block discarded – undo
56 68
 
57 69
 			$file_name = (DIR_TEMPLATES . 'Exception.tpl');
58 70
 
59
-			if (false === ($contents = @file_get_contents($file_name))) $output = nl2br($exc);
60
-
61
-			else $output = self::parseContents($contents, $exc);
71
+			if (false === ($contents = @file_get_contents($file_name))) {
72
+				$output = nl2br($exc);
73
+			} else {
74
+				$output = self::parseContents($contents, $exc);
75
+			}
62 76
 
63 77
 			# Set headers
64 78
 
Please login to merge, or discard this patch.
www/engine/System/Includes/Constants.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -2,68 +2,68 @@
 block discarded – undo
2 2
 
3 3
 # Cadmium
4 4
 
5
-define('CADMIUM_NAME',                              'Cadmium CMS');
6
-define('CADMIUM_HOME',                              'http://cadmium-cms.com');
5
+define('CADMIUM_NAME', 'Cadmium CMS');
6
+define('CADMIUM_HOME', 'http://cadmium-cms.com');
7 7
 
8
-define('CADMIUM_VERSION',                           '0.4.0');
9
-define('CADMIUM_COPY',                              '2016');
8
+define('CADMIUM_VERSION', '0.4.0');
9
+define('CADMIUM_COPY', '2016');
10 10
 
11 11
 # External
12 12
 
13
-define('JQUERY_VERSION',                            '3.1.1');
14
-define('SEMANTIC_UI_VERSION',                       '2.2.6');
15
-define('CKEDITOR_VERSION',                          '4.5.11');
13
+define('JQUERY_VERSION', '3.1.1');
14
+define('SEMANTIC_UI_VERSION', '2.2.6');
15
+define('CKEDITOR_VERSION', '4.5.11');
16 16
 
17 17
 # Sections
18 18
 
19
-define('SECTION_ADMIN',                             'admin');
20
-define('SECTION_SITE',                              'site');
19
+define('SECTION_ADMIN', 'admin');
20
+define('SECTION_SITE', 'site');
21 21
 
22 22
 # Filemanager types
23 23
 
24
-define('FILEMANAGER_TYPE_DIR',                      'dir');
25
-define('FILEMANAGER_TYPE_FILE',                     'file');
24
+define('FILEMANAGER_TYPE_DIR', 'dir');
25
+define('FILEMANAGER_TYPE_FILE', 'file');
26 26
 
27 27
 # Access
28 28
 
29
-define('ACCESS_PUBLIC',                             0);
30
-define('ACCESS_REGISTERED',                         1);
31
-define('ACCESS_ADMINISTRATOR',                      2);
29
+define('ACCESS_PUBLIC', 0);
30
+define('ACCESS_REGISTERED', 1);
31
+define('ACCESS_ADMINISTRATOR', 2);
32 32
 
33 33
 # Frequency
34 34
 
35
-define('FREQUENCY_ALWAYS',                          'always');
36
-define('FREQUENCY_HOURLY',                          'hourly');
37
-define('FREQUENCY_DAILY',                           'daily');
38
-define('FREQUENCY_WEEKLY',                          'weekly');
39
-define('FREQUENCY_MONTHLY',                         'monthly');
40
-define('FREQUENCY_YEARLY',                          'yearly');
41
-define('FREQUENCY_NEVER',                           'never');
35
+define('FREQUENCY_ALWAYS', 'always');
36
+define('FREQUENCY_HOURLY', 'hourly');
37
+define('FREQUENCY_DAILY', 'daily');
38
+define('FREQUENCY_WEEKLY', 'weekly');
39
+define('FREQUENCY_MONTHLY', 'monthly');
40
+define('FREQUENCY_YEARLY', 'yearly');
41
+define('FREQUENCY_NEVER', 'never');
42 42
 
43 43
 # Rank
44 44
 
45
-define('RANK_GUEST',                                0);
46
-define('RANK_USER',                                 1);
47
-define('RANK_ADMINISTRATOR',                        2);
45
+define('RANK_GUEST', 0);
46
+define('RANK_USER', 1);
47
+define('RANK_ADMINISTRATOR', 2);
48 48
 
49 49
 # Sex
50 50
 
51
-define('SEX_NOT_SELECTED',                          0);
52
-define('SEX_MALE',                                  1);
53
-define('SEX_FEMALE',                                2);
51
+define('SEX_NOT_SELECTED', 0);
52
+define('SEX_MALE', 1);
53
+define('SEX_FEMALE', 2);
54 54
 
55 55
 # Status
56 56
 
57
-define('STATUS_ONLINE',                             0);
58
-define('STATUS_MAINTENANCE',                        1);
59
-define('STATUS_UPDATE',                             2);
57
+define('STATUS_ONLINE', 0);
58
+define('STATUS_MAINTENANCE', 1);
59
+define('STATUS_UPDATE', 2);
60 60
 
61 61
 # Target
62 62
 
63
-define('TARGET_SELF',                               0);
64
-define('TARGET_BLANK',                              1);
63
+define('TARGET_SELF', 0);
64
+define('TARGET_BLANK', 1);
65 65
 
66 66
 # Visibility
67 67
 
68
-define('VISIBILITY_DRAFT',                          0);
69
-define('VISIBILITY_PUBLISHED',                      1);
68
+define('VISIBILITY_DRAFT', 0);
69
+define('VISIBILITY_PUBLISHED', 1);
Please login to merge, or discard this patch.
www/engine/System/Includes/Regex.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -2,16 +2,16 @@
 block discarded – undo
2 2
 
3 3
 # Regular expressions
4 4
 
5
-define('REGEX_MAP_ITEM_PATH',                       '/^[a-zA-Z0-9_\-\+\.\,\'\*\(\)\[\]:;!$%~]+$/');
6
-define('REGEX_MAP_ITEM_HANDLER',                    '/^[A-Z][a-zA-Z0-9]*$/');
5
+define('REGEX_MAP_ITEM_PATH', '/^[a-zA-Z0-9_\-\+\.\,\'\*\(\)\[\]:;!$%~]+$/');
6
+define('REGEX_MAP_ITEM_HANDLER', '/^[A-Z][a-zA-Z0-9]*$/');
7 7
 
8
-define('REGEX_ADDON_NAME',                          '/^[A-Z0-9][a-zA-Z0-9]*$/');
9
-define('REGEX_LANGUAGE_NAME',                       '/^[a-z][a-z]-[A-Z][A-Z]$/');
10
-define('REGEX_TEMPLATE_NAME',                       '/^[A-Z0-9][a-zA-Z0-9]*$/');
8
+define('REGEX_ADDON_NAME', '/^[A-Z0-9][a-zA-Z0-9]*$/');
9
+define('REGEX_LANGUAGE_NAME', '/^[a-z][a-z]-[A-Z][A-Z]$/');
10
+define('REGEX_TEMPLATE_NAME', '/^[A-Z0-9][a-zA-Z0-9]*$/');
11 11
 
12
-define('REGEX_USER_AUTH_CODE',                      '/^[a-zA-Z0-9]{40}$/');
12
+define('REGEX_USER_AUTH_CODE', '/^[a-zA-Z0-9]{40}$/');
13 13
 
14
-define('REGEX_USER_NAME',                           '/^(?!_)(?!.*_$)(?!.*_{2,})[a-zA-Z0-9_]+$/');
15
-define('REGEX_USER_PASSWORD',                       '/^.+$/');
14
+define('REGEX_USER_NAME', '/^(?!_)(?!.*_$)(?!.*_{2,})[a-zA-Z0-9_]+$/');
15
+define('REGEX_USER_PASSWORD', '/^.+$/');
16 16
 
17
-define('REGEX_FILE_NAME',                           '/^[^\/?%*:|"<>\\\]+$/');
17
+define('REGEX_FILE_NAME', '/^[^\/?%*:|"<>\\\]+$/');
Please login to merge, or discard this patch.
www/engine/System/Classes/Addons/Contact/Handler.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 
36 36
 			# Handle form
37 37
 
38
-			if ($this->form->handle(new Controller)) Request::redirect(INSTALL_PATH . '/contact?submitted');
38
+			if ($this->form->handle(new Controller)) Request::redirect(INSTALL_PATH.'/contact?submitted');
39 39
 
40 40
 			# Display success message
41 41
 
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,11 +35,15 @@
 block discarded – undo
35 35
 
36 36
 			# Handle form
37 37
 
38
-			if ($this->form->handle(new Controller)) Request::redirect(INSTALL_PATH . '/contact?submitted');
38
+			if ($this->form->handle(new Controller)) {
39
+				Request::redirect(INSTALL_PATH . '/contact?submitted');
40
+			}
39 41
 
40 42
 			# Display success message
41 43
 
42
-			if (false !== Request::get('submitted')) Messages::set('success', Language::get('CONTACT_SUCCESS_SEND'));
44
+			if (false !== Request::get('submitted')) {
45
+				Messages::set('success', Language::get('CONTACT_SUCCESS_SEND'));
46
+			}
43 47
 
44 48
 			# ------------------------
45 49
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Addons/Contact/Controller.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
 			# Send mail
28 28
 
29
-			$to = Settings::get('system_email'); $subject = (Settings::get('site_title') . ' | Contact form message');
29
+			$to = Settings::get('system_email'); $subject = (Settings::get('site_title').' | Contact form message');
30 30
 
31 31
 			if (!Mailer::send($to, $name, $email, $email, $subject, $message)) return 'CONTACT_ERROR_SEND';
32 32
 
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,15 +20,21 @@
 block discarded – undo
20 20
 
21 21
 			# Validate values
22 22
 
23
-			if (false === ($email = Validate::userEmail($email))) return ['email', 'CONTACT_ERROR_EMAIL_INVALID'];
23
+			if (false === ($email = Validate::userEmail($email))) {
24
+				return ['email', 'CONTACT_ERROR_EMAIL_INVALID'];
25
+			}
24 26
 
25
-			if (false === Security::checkCaptcha($captcha)) return ['captcha', 'CONTACT_ERROR_CAPTCHA_INCORRECT'];
27
+			if (false === Security::checkCaptcha($captcha)) {
28
+				return ['captcha', 'CONTACT_ERROR_CAPTCHA_INCORRECT'];
29
+			}
26 30
 
27 31
 			# Send mail
28 32
 
29 33
 			$to = Settings::get('system_email'); $subject = (Settings::get('site_title') . ' | Contact form message');
30 34
 
31
-			if (!Mailer::send($to, $name, $email, $email, $subject, $message)) return 'CONTACT_ERROR_SEND';
35
+			if (!Mailer::send($to, $name, $email, $email, $subject, $message)) {
36
+				return 'CONTACT_ERROR_SEND';
37
+			}
32 38
 
33 39
 			# ------------------------
34 40
 
Please login to merge, or discard this patch.