Passed
Push — master ( e0d6a2...2ec881 )
by Anton
05:25 queued 02:20
created
www/engine/System/Classes/Modules/Auth/Handler/Register.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 		protected function handle() {
14 14
 
15
-			if (!Auth::initial()) Request::redirect(INSTALL_PATH . '/admin/login');
15
+			if (!Auth::initial()) Request::redirect(INSTALL_PATH.'/admin/login');
16 16
 
17 17
 			return (new Auth\Action\Register)->handle();
18 18
 		}
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,9 @@
 block discarded – undo
12 12
 
13 13
 		protected function handle() {
14 14
 
15
-			if (!Auth::initial()) Request::redirect(INSTALL_PATH . '/admin/login');
15
+			if (!Auth::initial()) {
16
+				Request::redirect(INSTALL_PATH . '/admin/login');
17
+			}
16 18
 
17 19
 			return (new Auth\Action\Register)->handle();
18 20
 		}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Handler/Login.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 		protected function handle() {
14 14
 
15
-			if (Auth::initial()) Request::redirect(INSTALL_PATH . '/admin/register');
15
+			if (Auth::initial()) Request::redirect(INSTALL_PATH.'/admin/register');
16 16
 
17 17
 			return (new Auth\Action\Login)->handle();
18 18
 		}
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,9 @@
 block discarded – undo
12 12
 
13 13
 		protected function handle() {
14 14
 
15
-			if (Auth::initial()) Request::redirect(INSTALL_PATH . '/admin/register');
15
+			if (Auth::initial()) {
16
+				Request::redirect(INSTALL_PATH . '/admin/register');
17
+			}
16 18
 
17 19
 			return (new Auth\Action\Login)->handle();
18 20
 		}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Utils/Action.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,9 @@
 block discarded – undo
20 20
 
21 21
 			# Implement form
22 22
 
23
-			if (null !== $this->form) $this->form->implement($contents);
23
+			if (null !== $this->form) {
24
+				$this->form->implement($contents);
25
+			}
24 26
 
25 27
 			# ------------------------
26 28
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Utils/Mail.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 		private static function send(Entitizer\Entity\User $user, string $view, string $subject, string $link) {
12 12
 
13
-			$message = View::get((Auth::admin() ? 'Blocks/Auth/Mail/' : 'Blocks/Profile/Auth/Mail/') . $view);
13
+			$message = View::get((Auth::admin() ? 'Blocks/Auth/Mail/' : 'Blocks/Profile/Auth/Mail/').$view);
14 14
 
15 15
 			$message->name = $user->name; $message->link = $link; $message->copyright = Date::getYear();
16 16
 
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
 			$to = $user->email; $sender = Settings::get('site_title'); $reply_to = Settings::get('system_email');
20 20
 
21
-			$from = ((false !== ($host = parse_url(Settings::get('system_url'), PHP_URL_HOST))) ? ('noreply@' . $host) : '');
21
+			$from = ((false !== ($host = parse_url(Settings::get('system_url'), PHP_URL_HOST))) ? ('noreply@'.$host) : '');
22 22
 
23 23
 			return Mailer::send($to, $sender, $from, $reply_to, $subject, $message->getContents(), true);
24 24
 		}
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 
28 28
 		public static function reset(Entitizer\Entity\User $user, string $code) {
29 29
 
30
-			$link = (Settings::get('system_url') . (Auth::admin() ? '/admin' : '/profile') . '/recover?code=' . $code);
30
+			$link = (Settings::get('system_url').(Auth::admin() ? '/admin' : '/profile').'/recover?code='.$code);
31 31
 
32 32
 			return self::send($user, 'Reset', Language::get('MAIL_SUBJECT_RESET'), $link);
33 33
 		}
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
 		public static function register(Entitizer\Entity\User $user) {
38 38
 
39
-			$link = (Settings::get('system_url') . (Auth::admin() ? '/admin' : '/profile'));
39
+			$link = (Settings::get('system_url').(Auth::admin() ? '/admin' : '/profile'));
40 40
 
41 41
 			return self::send($user, 'Register', Language::get('MAIL_SUBJECT_REGISTER'), $link);
42 42
 		}
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Action/Reset.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
 			if ($this->form->handle(new Auth\Controller\Reset())) {
22 22
 
23
-				Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/login?submitted=reset');
23
+				Request::redirect(INSTALL_PATH.(Auth::admin() ? '/admin' : '/profile').'/login?submitted=reset');
24 24
 			}
25 25
 
26 26
 			# ------------------------
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Action/Register.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
 			if ($this->form->handle(new Auth\Controller\Register())) {
22 22
 
23
-				Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/login?submitted=register');
23
+				Request::redirect(INSTALL_PATH.(Auth::admin() ? '/admin' : '/profile').'/login?submitted=register');
24 24
 			}
25 25
 
26 26
 			# ------------------------
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Action/Recover.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
 			if (false !== ($code = Auth::secret())) $this->code = $code;
18 18
 
19
-			else Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/reset');
19
+			else Request::redirect(INSTALL_PATH.(Auth::admin() ? '/admin' : '/profile').'/reset');
20 20
 
21 21
 			# Create form
22 22
 
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
 			if ($this->form->handle(new Auth\Controller\Recover())) {
28 28
 
29
-				Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/login?submitted=recover');
29
+				Request::redirect(INSTALL_PATH.(Auth::admin() ? '/admin' : '/profile').'/login?submitted=recover');
30 30
 			}
31 31
 
32 32
 			# ------------------------
Please login to merge, or discard this patch.
Braces   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -14,9 +14,11 @@
 block discarded – undo
14 14
 
15 15
 			# Init user by secret code
16 16
 
17
-			if (false !== ($code = Auth::secret())) $this->code = $code;
18
-
19
-			else Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/reset');
17
+			if (false !== ($code = Auth::secret())) {
18
+				$this->code = $code;
19
+			} else {
20
+				Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile') . '/reset');
21
+			}
20 22
 
21 23
 			# Create form
22 24
 
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Action/Login.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
 			if ($this->form->handle(new Auth\Controller\Login())) {
22 22
 
23
-				Request::redirect(INSTALL_PATH . (Auth::admin() ? '/admin' : '/profile'));
23
+				Request::redirect(INSTALL_PATH.(Auth::admin() ? '/admin' : '/profile'));
24 24
 			}
25 25
 
26 26
 			# Display success message
Please login to merge, or discard this patch.
www/engine/System/Classes/Modules/Auth/Auth.php 1 patch
Braces   +36 added lines, -12 removed lines patch added patch discarded remove patch
@@ -12,9 +12,13 @@  discard block
 block discarded – undo
12 12
 
13 13
 		private static function getAuth(string $code, string $type, int $lifetime) {
14 14
 
15
-			if (!($auth = Entitizer::get($type))->init($code, 'code')) return false;
15
+			if (!($auth = Entitizer::get($type))->init($code, 'code')) {
16
+				return false;
17
+			}
16 18
 
17
-			if (($auth->ip !== REQUEST_CLIENT_IP) || ($auth->time < (REQUEST_TIME - $lifetime))) return false;
19
+			if (($auth->ip !== REQUEST_CLIENT_IP) || ($auth->time < (REQUEST_TIME - $lifetime))) {
20
+				return false;
21
+			}
18 22
 
19 23
 			# ------------------------
20 24
 
@@ -25,9 +29,13 @@  discard block
 block discarded – undo
25 29
 
26 30
 		private static function getUser(int $id) {
27 31
 
28
-			if (0 === ($user = Entitizer::get(TABLE_USERS, $id))->id) return false;
32
+			if (0 === ($user = Entitizer::get(TABLE_USERS, $id))->id) {
33
+				return false;
34
+			}
29 35
 
30
-			if ($user->rank < (self::$admin ? RANK_ADMINISTRATOR : RANK_USER)) return false;
36
+			if ($user->rank < (self::$admin ? RANK_ADMINISTRATOR : RANK_USER)) {
37
+				return false;
38
+			}
31 39
 
32 40
 			# ------------------------
33 41
 
@@ -42,17 +50,23 @@  discard block
 block discarded – undo
42 50
 
43 51
 			# Check session code
44 52
 
45
-			if (false === ($code = Validate::authCode(Session::get('code') ?? ''))) return false;
53
+			if (false === ($code = Validate::authCode(Session::get('code') ?? ''))) {
54
+				return false;
55
+			}
46 56
 
47 57
 			# Get auth
48 58
 
49 59
 			$type = TABLE_USERS_SESSIONS; $lifetime = CONFIG_USER_SESSION_LIFETIME;
50 60
 
51
-			if (false === ($session = self::getAuth($code, $type, $lifetime))) return false;
61
+			if (false === ($session = self::getAuth($code, $type, $lifetime))) {
62
+				return false;
63
+			}
52 64
 
53 65
 			# Get user
54 66
 
55
-			if (false === ($user = self::getUser($session->id))) return false;
67
+			if (false === ($user = self::getUser($session->id))) {
68
+				return false;
69
+			}
56 70
 
57 71
 			# Update session
58 72
 
@@ -71,21 +85,29 @@  discard block
 block discarded – undo
71 85
 
72 86
 		public static function secret() {
73 87
 
74
-			if ((null === self::$user) || (0 !== self::$user->id)) return false;
88
+			if ((null === self::$user) || (0 !== self::$user->id)) {
89
+				return false;
90
+			}
75 91
 
76 92
 			# Check secret code
77 93
 
78
-			if (false === ($code = Validate::authCode(Request::get('code')))) return false;
94
+			if (false === ($code = Validate::authCode(Request::get('code')))) {
95
+				return false;
96
+			}
79 97
 
80 98
 			# Get auth
81 99
 
82 100
 			$type = TABLE_USERS_SECRETS; $lifetime = CONFIG_USER_SECRET_LIFETIME;
83 101
 
84
-			if (false === ($secret = self::getAuth($code, $type, $lifetime))) return false;
102
+			if (false === ($secret = self::getAuth($code, $type, $lifetime))) {
103
+				return false;
104
+			}
85 105
 
86 106
 			# Get user
87 107
 
88
-			if (false === ($user = self::getUser($secret->id))) return false;
108
+			if (false === ($user = self::getUser($secret->id))) {
109
+				return false;
110
+			}
89 111
 
90 112
 			# ------------------------
91 113
 
@@ -96,7 +118,9 @@  discard block
 block discarded – undo
96 118
 
97 119
 		public static function logout() {
98 120
 
99
-			if ((null === self::$user) || (0 === self::$user->id)) return false;
121
+			if ((null === self::$user) || (0 === self::$user->id)) {
122
+				return false;
123
+			}
100 124
 
101 125
 			# Remove session
102 126
 
Please login to merge, or discard this patch.