Widget - Code Metrics - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Widget A
last analyzed 2017-10-02 14:48 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	59
rs	10
c	0
b	0
f	0
wmc	7
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	__invoke()	0	37	6

<?php

/**
 * @package Cadmium\System\Modules\Entitizer
 * @author Anton Romanov
 * @copyright Copyright (c) 2015-2017, Anton Romanov
 * @link http://cadmium-cms.com
 */

namespace Modules\Entitizer\Controller {

	use Modules\Entitizer, Utils\Validate;

	class Widget {

		private $widget = null;

		/**
		 * Constructor
		 */

		public function __construct(Entitizer\Entity\Widget $widget) {

			$this->widget = $widget;
		}

		/**
		 * Invoker
		 *
		 * @return true|string|array : true on success, otherwise an error code, or an array of type [$param_name, $error_code],
		 *         where $param_name is a name of param that has triggered the error,
		 *         and $error_code is a language phrase related to the error
		 */

		public function __invoke(array $post) {

			# Declare variables

			$title = ''; $name = ''; $active = ''; $contents = '';

			# Extract post array

			extract($post);

			# Validate name

			if (false === ($name = Validate::templateComponentName($name))) return ['name', 'WIDGET_ERROR_NAME_INVALID'];

			# Check name exists

			if (false === ($check_name = $this->widget->check($name, 'name'))) return 'WIDGET_ERROR_MODIFY';

			if ($check_name === 1) return ['name', 'WIDGET_ERROR_NAME_DUPLICATE'];

			# Modify widget

			$data = [];

			$data['title']              = $title;
			$data['name']               = $name;
			$data['active']             = $active;
			$data['contents']           = $contents;

			$modifier = ((0 === $this->widget->id) ? 'create' : 'edit');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			if (!$this->widget->$modifier($data)) return 'WIDGET_ERROR_MODIFY';

			# ------------------------

			return true;
		}
	}
}


1			<?php
2
3			/**
4			* @package Cadmium\System\Modules\Entitizer
5			* @author Anton Romanov
6			* @copyright Copyright (c) 2015-2017, Anton Romanov
7			* @link http://cadmium-cms.com
8			*/
9
10			namespace Modules\Entitizer\Controller {
11
12			use Modules\Entitizer, Utils\Validate;
13
14			class Widget {
15
16			private $widget = null;
17
18			/**
19			* Constructor
20			*/
21
22			public function __construct(Entitizer\Entity\Widget $widget) {
23
24			$this->widget = $widget;
25			}
26
27			/**
28			* Invoker
29			*
30			* @return true\|string\|array : true on success, otherwise an error code, or an array of type [$param_name, $error_code],
31			* where $param_name is a name of param that has triggered the error,
32			* and $error_code is a language phrase related to the error
33			*/
34
35			public function __invoke(array $post) {
36
37			# Declare variables
38
39			$title = ''; $name = ''; $active = ''; $contents = '';
40
41			# Extract post array
42
43			extract($post);
44
45			# Validate name
46
47			if (false === ($name = Validate::templateComponentName($name))) return ['name', 'WIDGET_ERROR_NAME_INVALID'];
48
49			# Check name exists
50
51			if (false === ($check_name = $this->widget->check($name, 'name'))) return 'WIDGET_ERROR_MODIFY';
52
53			if ($check_name === 1) return ['name', 'WIDGET_ERROR_NAME_DUPLICATE'];
54
55			# Modify widget
56
57			$data = [];
58
59			$data['title'] = $title;
60			$data['name'] = $name;
61			$data['active'] = $active;
62			$data['contents'] = $contents;
63
64			$modifier = ((0 === $this->widget->id) ? 'create' : 'edit');
			0 ignored issues – show Documentation introduced 2016-04-16 14:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Entity\Widget>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
65
66			if (!$this->widget->$modifier($data)) return 'WIDGET_ERROR_MODIFY';
67
68			# ------------------------
69
70			return true;
71			}
72			}
73			}
74

cadmium-org / cadmium-cms

Widget A last analyzed 2017-10-02 14:48 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

Widget A
last analyzed 2017-10-02 14:48 UTC