Action - Code Metrics - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Action A
last analyzed 2017-10-02 14:48 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	60
Duplicated Lines	6.67 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	4
loc	60
rs	10
c	0
b	0
f	0
wmc	9
lcom	1
cbo	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getContents()	0	16	4
B	handle()	4	24	5

How to fix Duplicated Code

<?php

/**
 * @package Cadmium\System\Modules\Auth
 * @author Anton Romanov
 * @copyright Copyright (c) 2015-2017, Anton Romanov
 * @link http://cadmium-cms.com
 */

namespace Modules\Auth\Utils {

	use Modules\Auth, Utils\Messages, Utils\View, Language, Request, Template;

	abstract class Action {

		protected $code = null, $user = null, $form = null;

		# Action configuration interface

		protected static $view = '', $form_class = '', $controller_class = '';

		protected static $redirect = '', $messages = [];

		/**
		 * Get the contents block
		 */

		private function getContents() : Template\Block {

			$contents = View::get((Auth::isAdmin() ? 'Blocks/Auth/' : 'Blocks/Profile/Auth/') . static::$view);

			# Set code

			if (null !== $this->code) $contents->code = $this->code;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			# Implement form

			if (null !== $this->form) $this->form->implement($contents);

			# ------------------------

			return $contents;
		}

		/**
		 * Handle the request
		 */

		public function handle() : Template\Block {

			# Create form

			$this->form = new static::$form_class;

			# Handle form

			if ($this->form->handle(new static::$controller_class($this->user))) {


				Request::redirect(INSTALL_PATH . (Auth::isAdmin() ? '/admin' : '/profile') . static::$redirect);
			}

			# Display success message

			foreach (static::$messages as $key => $message) if (Request::get('submitted') === $key) {

				Messages::set('success', Language::get($message['text']), Language::get($message['title']));
			}

			# ------------------------

			return $this->getContents();
		}
	}
}


1		<?php
2
3		/**
4		* @package Cadmium\System\Modules\Auth
5		* @author Anton Romanov
6		* @copyright Copyright (c) 2015-2017, Anton Romanov
7		* @link http://cadmium-cms.com
8		*/
9
10		namespace Modules\Auth\Utils {
11
12		use Modules\Auth, Utils\Messages, Utils\View, Language, Request, Template;
13
14		abstract class Action {
15
16		protected $code = null, $user = null, $form = null;
17
18		# Action configuration interface
19
20		protected static $view = '', $form_class = '', $controller_class = '';
21
22		protected static $redirect = '', $messages = [];
23
24		/**
25		* Get the contents block
26		*/
27
28		private function getContents() : Template\Block {
29
30		$contents = View::get((Auth::isAdmin() ? 'Blocks/Auth/' : 'Blocks/Profile/Auth/') . static::$view);
31
32		# Set code
33
34		if (null !== $this->code) $contents->code = $this->code;
		0 ignored issues – show Documentation introduced 2017-04-30 22:42 UTC by Report Bug Copy Issue Report The property `code` does not exist on `object<Template\Block>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35
36		# Implement form
37
38		if (null !== $this->form) $this->form->implement($contents);
39
40		# ------------------------
41
42		return $contents;
43		}
44
45		/**
46		* Handle the request
47		*/
48
49		public function handle() : Template\Block {
50
51		# Create form
52
53		$this->form = new static::$form_class;
54
55		# Handle form
56
57	View Code Duplication	if ($this->form->handle(new static::$controller_class($this->user))) {
		0 ignored issues – show Duplication introduced 2017-02-21 02:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58
59		Request::redirect(INSTALL_PATH . (Auth::isAdmin() ? '/admin' : '/profile') . static::$redirect);
60		}
61
62		# Display success message
63
64		foreach (static::$messages as $key => $message) if (Request::get('submitted') === $key) {
65
66		Messages::set('success', Language::get($message['text']), Language::get($message['title']));
67		}
68
69		# ------------------------
70
71		return $this->getContents();
72		}
73		}
74		}
75

cadmium-org / cadmium-cms

Action A last analyzed 2017-10-02 14:48 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Action A
last analyzed 2017-10-02 14:48 UTC