Reset - Code Metrics - cadmium-org/cadmium-cms - Measure and Improve Code Quality continuously with Scrutinizer

Reset A
last analyzed 2017-10-02 14:48 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	9.86 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

Metric	Value
dl	7
loc	71
rs	10
c	0
b	0
f	0
wmc	12
lcom	0
cbo	7

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	__invoke()	7	49	11

How to fix Duplicated Code

<?php

/**
 * @package Cadmium\System\Modules\Auth
 * @author Anton Romanov
 * @copyright Copyright (c) 2015-2017, Anton Romanov
 * @link http://cadmium-cms.com
 */

namespace Modules\Auth\Controller {

	use Modules\Auth, Modules\Entitizer, Utils\Security, Utils\Validate, Str;

	class Reset {

		private $user = null;

		/**
		 * Constructor
		 */

		public function __construct() {

			$this->user = Entitizer::get(TABLE_USERS);
		}

		/**
		 * Invoker
		 *
		 * @return true|string|array : true on success, otherwise an error code, or an array of type [$param_name, $error_code],
		 *         where $param_name is a name of param that has triggered the error,
		 *         and $error_code is a language phrase related to the error
		 */

		public function __invoke(array $post) {

			# Declare variables

			$name_email = ''; $captcha = '';

			# Extract post array

			extract($post);

			# Validate values

			if ((false === ($name = Validate::userName($name_email))) &&


				(false === ($email = Validate::userEmail($name_email)))) return ['name_email', 'USER_ERROR_NAME_INVALID'];

			if (false === Security::checkCaptcha($captcha)) return ['captcha', 'USER_ERROR_CAPTCHA_INCORRECT'];

			# Init user

			$init_by = ((false !== $name) ? 'name' : 'email');

			if ((!$this->user->init($$init_by, $init_by)) || (Auth::isAdmin() && ($this->user->rank < RANK_ADMINISTRATOR))) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

				return ['name_email', ('USER_ERROR_' . strtoupper($init_by) .'_INCORRECT')];
			}

			# Check access

			if (!Auth::isAdmin() && ($this->user->rank === RANK_GUEST)) return 'USER_ERROR_ACCESS';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			# Create secret

			$secret = Entitizer::get(TABLE_USERS_SECRETS, $this->user->id); $secret->remove();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			$code = Str::random(40); $ip = REQUEST_CLIENT_IP; $time = REQUEST_TIME;

			$data = ['id' => $this->user->id, 'code' => $code, 'ip' => $ip, 'time' => $time];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

			if (!$secret->create($data)) return 'USER_ERROR_AUTH_RESET';

			# Send mail

			Auth\Utils\Mail::sendPasswordMessage($this->user, $code);


			# ------------------------

			return true;
		}
	}
}


1		<?php
2
3		/**
4		* @package Cadmium\System\Modules\Auth
5		* @author Anton Romanov
6		* @copyright Copyright (c) 2015-2017, Anton Romanov
7		* @link http://cadmium-cms.com
8		*/
9
10		namespace Modules\Auth\Controller {
11
12		use Modules\Auth, Modules\Entitizer, Utils\Security, Utils\Validate, Str;
13
14		class Reset {
15
16		private $user = null;
17
18		/**
19		* Constructor
20		*/
21
22		public function __construct() {
23
24		$this->user = Entitizer::get(TABLE_USERS);
25		}
26
27		/**
28		* Invoker
29		*
30		* @return true\|string\|array : true on success, otherwise an error code, or an array of type [$param_name, $error_code],
31		* where $param_name is a name of param that has triggered the error,
32		* and $error_code is a language phrase related to the error
33		*/
34
35		public function __invoke(array $post) {
36
37		# Declare variables
38
39		$name_email = ''; $captcha = '';
40
41		# Extract post array
42
43		extract($post);
44
45		# Validate values
46
47	View Code Duplication	if ((false === ($name = Validate::userName($name_email))) &&
		0 ignored issues – show Duplication introduced 2017-02-21 02:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48
49		(false === ($email = Validate::userEmail($name_email)))) return ['name_email', 'USER_ERROR_NAME_INVALID'];
50
51		if (false === Security::checkCaptcha($captcha)) return ['captcha', 'USER_ERROR_CAPTCHA_INCORRECT'];
52
53		# Init user
54
55		$init_by = ((false !== $name) ? 'name' : 'email');
56
57	View Code Duplication	if ((!$this->user->init($$init_by, $init_by)) \|\| (Auth::isAdmin() && ($this->user->rank < RANK_ADMINISTRATOR))) {
		0 ignored issues – show Duplication introduced 2017-02-21 02:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Documentation introduced 2017-03-20 20:18 UTC by Report Bug Copy Issue Report The property `rank` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
58
59		return ['name_email', ('USER_ERROR_' . strtoupper($init_by) .'_INCORRECT')];
60		}
61
62		# Check access
63
64		if (!Auth::isAdmin() && ($this->user->rank === RANK_GUEST)) return 'USER_ERROR_ACCESS';
		0 ignored issues – show Documentation introduced 2017-03-20 20:18 UTC by Report Bug Copy Issue Report The property `rank` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
65
66		# Create secret
67
68		$secret = Entitizer::get(TABLE_USERS_SECRETS, $this->user->id); $secret->remove();
		0 ignored issues – show Documentation introduced 2017-03-20 20:18 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
69
70		$code = Str::random(40); $ip = REQUEST_CLIENT_IP; $time = REQUEST_TIME;
71
72		$data = ['id' => $this->user->id, 'code' => $code, 'ip' => $ip, 'time' => $time];
		0 ignored issues – show Documentation introduced 2017-03-20 20:18 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Modules\Entitizer\Utils\Entity>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
73
74		if (!$secret->create($data)) return 'USER_ERROR_AUTH_RESET';
75
76		# Send mail
77
78		Auth\Utils\Mail::sendPasswordMessage($this->user, $code);
		0 ignored issues – show Compatibility introduced 2017-03-20 20:18 UTC by Report Bug Copy Issue Report `$this->user` of type `object<Modules\Entitizer\Utils\Entity>` is not a sub-type of `object<Modules\Entitizer\Entity\User>`. It seems like you assume a child class of the class `Modules\Entitizer\Utils\Entity` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
79
80		# ------------------------
81
82		return true;
83		}
84		}
85		}
86

cadmium-org / cadmium-cms

Reset A last analyzed 2017-10-02 14:48 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Reset A
last analyzed 2017-10-02 14:48 UTC