Issues in PhpQueryEvents.php (master) - Issues in master - c-harris/phpquery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1066)

Security Analysis 7 potential vulnerabilities

Cross-Site Scripting (1)

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection (3)

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection (3)

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/PhpQueryEvents.php (7 issues)

Labels

Severity

Minor 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PhpQuery;

use PhpQuery\Dom\DOMEvent;

/**
 * Event handling class.
 *
 * @author  Tobiasz Cudnik
 * @package PhpQuery
 * @static
 */
abstract class PhpQueryEvents
{
    /**
     * Trigger a type of event on every matched element.
     *
     *
     * @TODO exclusive events (with !)
     * @TODO global events (test)
     * @TODO support more than event in $type (space-separated)
     * @param       $document
     * @param       $type
     * @param array $data
     * @param null  $node
     */
    public static function trigger($document, $type, $data = array(), $node = null)
    {
        // trigger: function(type, data, elem, donative, extra) {

        $documentID = PhpQuery::getDocumentID($document);
        $namespace  = null;
        if (strpos($type, '.') !== false) {
            list($name, $namespace) = explode('.', $type);
        } else {
            $name = $type;
        }
        if (!$node) {
            if (self::issetGlobal($documentID, $type)) {
                $pq = PhpQuery::getDocument($documentID);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                // TODO check add($pq->document)

                $pq->find('*')->add($pq->document)->trigger($type, $data);
            }
        } else {
            if (isset($data[0]) && $data[0] instanceof DOMEvent) {
                $event                = $data[0];
                $event->relatedTarget = $event->target;
                $event->target        = $node;
                $data                 = array_slice($data, 1);
            } else {
                $event = new DOMEvent(array(
                                          'type'      => $type,
                                          'target'    => $node,
                                          'timeStamp' => time(),
                                      ));
            }
            $i = 0;
            while ($node) {
                // TODO whois
                PhpQuery::debug(
                    "Triggering " . ($i ? "bubbled " : '')
                    . "event '{$type}' on " . "node \n"
                );
                //.PhpQueryObject::whois($node)."\n");

                $event->currentTarget = $node;
                $eventNode            = self::getNode($documentID, $node);
                if (isset($eventNode->eventHandlers)) {
                    foreach ($eventNode->eventHandlers as $eventType => $handlers) {
                        $eventNamespace = null;
                        if (strpos($type, '.') !== false) {
                            list($eventName, $eventNamespace) = explode('.', $eventType);
                        } else {
                            $eventName = $eventType;
                        }
                        if ($name != $eventName) {
                            continue;
                        }
                        if ($namespace && $eventNamespace && $namespace != $eventNamespace) {
                            continue;
                        }
                        foreach ($handlers as $handler) {
                            PhpQuery::debug("Calling event handler\n");
                            $event->data = $handler['data'] ? $handler['data'] : null;
                            $params      = array_merge(
                                array(
                                    $event
                                ),
                                $data
                            );
                            $return      = PhpQuery::callbackRun($handler['callback'], $params);
                            if ($return === false) {
                                $event->bubbles = false;
                            }
                        }
                    }
                }
                // to bubble or not to bubble...
                if (!$event->bubbles) {
                    break;
                }
                $node = $node->parentNode;
                $i++;
            }
        }
    }

    /**
     * Binds a handler to one or more events (like click) for each matched element.
     * Can also bind custom events.
     *
     * @param \DOMNode|PhpQueryObject|string $document
     * @param                                $node
     * @param string                         $type
     * @param string                         $data Optional
     * @param                                $callback
     *
     * @TODO support '!' (exclusive) events
     * @TODO support more than event in $type (space-separated)
     * @TODO support binding to global events
     */
    public static function add($document, $node, $type, $data, $callback = null)
    {
        PhpQuery::debug("Binding '$type' event");
        $documentID = PhpQuery::getDocumentID($document);
        //		if (is_null($callback) && is_callable($data)) {

        //			$callback = $data;

        //			$data = null;

        //		}
        $eventNode = self::getNode($documentID, $node);
        if (!$eventNode) {
            $eventNode = self::setNode($documentID, $node);
        }
        if (!isset($eventNode->eventHandlers[$type])) {
            $eventNode->eventHandlers[$type] = array();
        }
        $eventNode->eventHandlers[$type][] = array(
            'callback' => $callback,
            'data'     => $data,
        );
    }

    /**
     * Enter description here...
     *
     * @param \DOMNode|PhpQueryObject|string $document
     * @param                                $node
     * @param string                         $type
     * @param                                $callback
     *
     * @TODO namespace events
     * @TODO support more than event in $type (space-separated)
     */
    public static function remove($document, $node, $type = null, $callback = null)
    {
        $documentID = PhpQuery::getDocumentID($document);
        $eventNode  = self::getNode($documentID, $node);
        if (is_object($eventNode) && isset($eventNode->eventHandlers[$type])) {
            if ($callback) {
                foreach ($eventNode->eventHandlers[$type] as $k => $handler) {
                    if ($handler['callback'] == $callback) {
                        unset($eventNode->eventHandlers[$type][$k]);
                    }
                }
            } else {
                unset($eventNode->eventHandlers[$type]);
            }
        }
    }

    protected static function getNode($documentID, $node)
    {
        foreach (PhpQuery::$documents[$documentID]->eventsNodes as $eventNode) {
            if ($node->isSameNode($eventNode)) {
                return $eventNode;
            }
        }
    }

    protected static function setNode($documentID, $node)
    {
        PhpQuery::$documents[$documentID]->eventsNodes[] = $node;
        return PhpQuery::$documents[$documentID]->eventsNodes[count(PhpQuery::$documents[$documentID]->eventsNodes)
        - 1];
    }

    protected static function issetGlobal($documentID, $type)
    {
        return isset(PhpQuery::$documents[$documentID]) ? in_array(
            $type,
            PhpQuery::$documents[$documentID]->eventsGlobal
        )
            : false;
    }
}


1			<?php
2			namespace PhpQuery;
3
4			use PhpQuery\Dom\DOMEvent;
5
6			/**
7			* Event handling class.
8			*
9			* @author Tobiasz Cudnik
10			* @package PhpQuery
11			* @static
12			*/
13			abstract class PhpQueryEvents
14			{
15			/**
16			* Trigger a type of event on every matched element.
17			*
18			*
19			* @TODO exclusive events (with !)
20			* @TODO global events (test)
21			* @TODO support more than event in $type (space-separated)
22			* @param $document
23			* @param $type
24			* @param array $data
25			* @param null $node
26			*/
27			public static function trigger($document, $type, $data = array(), $node = null)
28			{
29			// trigger: function(type, data, elem, donative, extra) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30			$documentID = PhpQuery::getDocumentID($document);
31			$namespace = null;
32			if (strpos($type, '.') !== false) {
33			list($name, $namespace) = explode('.', $type);
34			} else {
35			$name = $type;
36			}
37			if (!$node) {
38			if (self::issetGlobal($documentID, $type)) {
39			$pq = PhpQuery::getDocument($documentID);
			0 ignored issues – show Bug introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$documentID` defined by `\PhpQuery\PhpQuery::getDocumentID($document)` on line `30` can also be of type `integer` or `string`; however, `PhpQuery\PhpQuery::getDocument()` does only seem to accept `null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
40			// TODO check add($pq->document)
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41			$pq->find('*')->add($pq->document)->trigger($type, $data);
42			}
43			} else {
44			if (isset($data[0]) && $data[0] instanceof DOMEvent) {
45			$event = $data[0];
46			$event->relatedTarget = $event->target;
47			$event->target = $node;
48			$data = array_slice($data, 1);
49			} else {
50			$event = new DOMEvent(array(
51			'type' => $type,
52			'target' => $node,
53			'timeStamp' => time(),
54			));
55			}
56			$i = 0;
57			while ($node) {
58			// TODO whois
59			PhpQuery::debug(
60			"Triggering " . ($i ? "bubbled " : '')
61			. "event '{$type}' on " . "node \n"
62			);
63			//.PhpQueryObject::whois($node)."\n");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64			$event->currentTarget = $node;
65			$eventNode = self::getNode($documentID, $node);
66			if (isset($eventNode->eventHandlers)) {
67			foreach ($eventNode->eventHandlers as $eventType => $handlers) {
68			$eventNamespace = null;
69			if (strpos($type, '.') !== false) {
70			list($eventName, $eventNamespace) = explode('.', $eventType);
71			} else {
72			$eventName = $eventType;
73			}
74			if ($name != $eventName) {
75			continue;
76			}
77			if ($namespace && $eventNamespace && $namespace != $eventNamespace) {
78			continue;
79			}
80			foreach ($handlers as $handler) {
81			PhpQuery::debug("Calling event handler\n");
82			$event->data = $handler['data'] ? $handler['data'] : null;
83			$params = array_merge(
84			array(
85			$event
86			),
87			$data
88			);
89			$return = PhpQuery::callbackRun($handler['callback'], $params);
90			if ($return === false) {
91			$event->bubbles = false;
92			}
93			}
94			}
95			}
96			// to bubble or not to bubble...
97			if (!$event->bubbles) {
98			break;
99			}
100			$node = $node->parentNode;
101			$i++;
102			}
103			}
104			}
105
106			/**
107			* Binds a handler to one or more events (like click) for each matched element.
108			* Can also bind custom events.
109			*
110			* @param \DOMNode\|PhpQueryObject\|string $document
111			* @param $node
112			* @param string $type
113			* @param string $data Optional
114			* @param $callback
115			*
116			* @TODO support '!' (exclusive) events
117			* @TODO support more than event in $type (space-separated)
118			* @TODO support binding to global events
119			*/
120			public static function add($document, $node, $type, $data, $callback = null)
121			{
122			PhpQuery::debug("Binding '$type' event");
123			$documentID = PhpQuery::getDocumentID($document);
124			// if (is_null($callback) && is_callable($data)) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
125			// $callback = $data;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
126			// $data = null;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-24 15:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
127			// }
128			$eventNode = self::getNode($documentID, $node);
129			if (!$eventNode) {
130			$eventNode = self::setNode($documentID, $node);
131			}
132			if (!isset($eventNode->eventHandlers[$type])) {
133			$eventNode->eventHandlers[$type] = array();
134			}
135			$eventNode->eventHandlers[$type][] = array(
136			'callback' => $callback,
137			'data' => $data,
138			);
139			}
140
141			/**
142			* Enter description here...
143			*
144			* @param \DOMNode\|PhpQueryObject\|string $document
145			* @param $node
146			* @param string $type
147			* @param $callback
148			*
149			* @TODO namespace events
150			* @TODO support more than event in $type (space-separated)
151			*/
152			public static function remove($document, $node, $type = null, $callback = null)
153			{
154			$documentID = PhpQuery::getDocumentID($document);
155			$eventNode = self::getNode($documentID, $node);
156			if (is_object($eventNode) && isset($eventNode->eventHandlers[$type])) {
157			if ($callback) {
158			foreach ($eventNode->eventHandlers[$type] as $k => $handler) {
159			if ($handler['callback'] == $callback) {
160			unset($eventNode->eventHandlers[$type][$k]);
161			}
162			}
163			} else {
164			unset($eventNode->eventHandlers[$type]);
165			}
166			}
167			}
168
169			protected static function getNode($documentID, $node)
170			{
171			foreach (PhpQuery::$documents[$documentID]->eventsNodes as $eventNode) {
172			if ($node->isSameNode($eventNode)) {
173			return $eventNode;
174			}
175			}
176			}
177
178			protected static function setNode($documentID, $node)
179			{
180			PhpQuery::$documents[$documentID]->eventsNodes[] = $node;
181			return PhpQuery::$documents[$documentID]->eventsNodes[count(PhpQuery::$documents[$documentID]->eventsNodes)
182			- 1];
183			}
184
185			protected static function issetGlobal($documentID, $type)
186			{
187			return isset(PhpQuery::$documents[$documentID]) ? in_array(
188			$type,
189			PhpQuery::$documents[$documentID]->eventsGlobal
190			)
191			: false;
192			}
193			}
194

c-harris / phpquery

Issues (1066)

Security Analysis 7 potential vulnerabilities

src/PhpQueryEvents.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like