PhpQuery\Dom\DOMDocumentWrapper::loadMarkupXML()

Complexity

Conditions	26
Paths	> 20000

Size

Total Lines	101
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function loadMarkupXML($markup, $requestedCharset = null)
    {
        if (PhpQuery::$debug) {
            PhpQuery::debug('Full markup load (XML): ' . substr($markup, 0, 250));
        }
        $this->loadMarkupReset();
        $this->isXML = true;
        // check agains XHTML in contentType or markup
        $isContentTypeXHTML = $this->isXHTML();
        $isMarkupXHTML      = $this->isXHTML($markup);
        if ($isContentTypeXHTML || $isMarkupXHTML) {
            self::debug('Full markup load (XML), XHTML detected');
            $this->isXHTML = true;
        }
        // determine document fragment
        if (!isset($this->isDocumentFragment)) {
            $this->isDocumentFragment = $this->isXHTML ? self::isDocumentFragmentXHTML($markup)
                : self::isDocumentFragmentXML($markup);
        }
        // this charset will be used
        $charset = null;
        // charset from XML declaration @var string
        $documentCharset = $this->charsetFromXML($markup);
        if (!$documentCharset) {

The expression $documentCharset of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            if ($this->isXHTML) {
                // this is XHTML, try to get charset from content-type meta header
                $documentCharset = $this->charsetFromHTML($markup);
                if ($documentCharset) {
                    PhpQuery::debug("Full markup load (XML), appending XHTML charset '$documentCharset'");
                    $this->charsetAppendToXML($markup, $documentCharset);

The call to the method PhpQuery\Dom\DOMDocumentWrapper::charsetAppendToXML() seems un-needed as the method has no side-effects.

                    $charset = $documentCharset;
                }
            }
            if (!$documentCharset) {
                // if still no document charset...
                $charset = $requestedCharset;
            }
        } else {
            if ($requestedCharset) {
                $charset = $requestedCharset;
            }
        }
        if (!$charset) {
            $charset = PhpQuery::$defaultCharset;
        }
        if ($requestedCharset && $documentCharset

This if statement is empty and can be removed.

            && $requestedCharset != $documentCharset
        ) {
            // TODO place for charset conversion
            //			$charset = $requestedCharset;

43% of this comment could be valid code. Did you maybe forget this after debugging?

        }
        $return = false;

$return is not used, you could remove the assignment.

        if ($this->isDocumentFragment) {
            PhpQuery::debug("Full markup load (XML), DocumentFragment detected, using charset '$charset'");
            $return = $this->documentFragmentLoadMarkup($this, $charset, $markup);
        } else {
            // FIXME ???

50% of this comment could be valid code. Did you maybe forget this after debugging?

            if ($isContentTypeXHTML && !$isMarkupXHTML) {
                if (!$documentCharset) {
                    PhpQuery::debug("Full markup load (XML), appending charset '$charset'");
                    $markup = $this->charsetAppendToXML($markup, $charset);
                }
            }
            // see http://pl2.php.net/manual/en/book.dom.php#78929
            // LIBXML_DTDLOAD (>= PHP 5.1)
            // does XML ctalogues works with LIBXML_NONET
            //		$this->document->resolveExternals = true;

46% of this comment could be valid code. Did you maybe forget this after debugging?

            // TODO test LIBXML_COMPACT for performance improvement
            // create document
            $this->documentCreate($charset);
            if (phpversion() < 5.1) {
                $this->document->resolveExternals = true;
                $return                           = PhpQuery::$debug === 2 ? $this->document->loadXML($markup)

                    : @$this->document->loadXML($markup);

            } else {
                /** @link http://pl2.php.net/manual/en/libxml.constants.php */
                $libxmlStatic = PhpQuery::$debug === 2 ? LIBXML_DTDLOAD
                    | LIBXML_DTDATTR | LIBXML_NONET
                    : LIBXML_DTDLOAD | LIBXML_DTDATTR | LIBXML_NONET | LIBXML_NOWARNING
                    | LIBXML_NOERROR;
                $return       = $this->document->loadXML($markup, $libxmlStatic);

                // 				if (! $return)

63% of this comment could be valid code. Did you maybe forget this after debugging?

                // 					$return = $this->document->loadHTML($markup);

58% of this comment could be valid code. Did you maybe forget this after debugging?

            }
            if ($return) {
                $this->root = $this->document;
            }
        }
        if ($return) {
            if (!$this->contentType) {
                if ($this->isXHTML) {
                    $this->contentType = 'application/xhtml+xml';

It seems like 'application/xhtml+xml' of type string is incompatible with the declared type object<PhpQuery\Dom\unknown_type> of property $contentType.

                } else {
                    $this->contentType = 'text/xml';

It seems like 'text/xml' of type string is incompatible with the declared type object<PhpQuery\Dom\unknown_type> of property $contentType.

                }
            }
            return $return;
        } else {
            throw new \Exception("Error loading XML markup");
        }
    }