Passed
Pull Request — master (#50)
by Alex
03:45
created
src/Edm/Validation/Internal/InterfaceValidator/VisitorOfINamedElement.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     {
15 15
         assert($item instanceof INamedElement);
16 16
         return null !== $item->getName()
17
-            ? null : [ InterfaceValidator::CreatePropertyMustNotBeNullError($item, 'Name') ];
17
+            ? null : [InterfaceValidator::CreatePropertyMustNotBeNullError($item, 'Name')];
18 18
     }
19 19
 
20 20
     public function forType(): string
Please login to merge, or discard this patch.
Validation/Internal/InterfaceValidator/VisitorOfIEntityTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
         assert($typeRef instanceof IEntityTypeReference);
16 16
 
17 17
         return null !== $typeRef->getDefinition() && !$typeRef->getDefinition()->getTypeKind()->isEntity()
18
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
18
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
19 19
     }
20 20
 
21 21
     public function forType(): string
Please login to merge, or discard this patch.
Internal/InterfaceValidator/VisitorOfIStructuredTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     {
15 15
         assert($typeRef instanceof IStructuredTypeReference);
16 16
         return null !== $typeRef->getDefinition() && !$typeRef->getDefinition()->getTypeKind()->IsStructured()
17
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
17
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
18 18
     }
19 19
 
20 20
     public function forType(): string
Please login to merge, or discard this patch.
Validation/Internal/InterfaceValidator/VisitorOfISpatialTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
         $primitive = $typeRef->getDefinition();
18 18
         assert($primitive instanceof IPrimitiveType);
19 19
         return null !== $typeRef->getDefinition() && !$primitive->getPrimitiveKind()->IsSpatial()
20
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
20
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
21 21
     }
22 22
 
23 23
     public function forType(): string
Please login to merge, or discard this patch.
Validation/Internal/InterfaceValidator/VisitorOfIBinaryTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
         $primitive = $typeRef->getDefinition();
18 18
         assert($primitive instanceof IPrimitiveType);
19 19
         return null !== $typeRef->getDefinition() && !$primitive->getPrimitiveKind()->isBinary()
20
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
20
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
21 21
     }
22 22
 
23 23
     public function forType(): string
Please login to merge, or discard this patch.
IStructuralProperty/StructuralPropertyInvalidPropertyType.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
         assert($property instanceof IStructuralProperty);
25 25
         if ($property->getDeclaringType()->getTypeKind()->isRow()) {
26 26
             $validatedType = $property->getType()->IsCollection() ?
27
-                $property->getType()->AsCollection()->ElementType()->getDefinition() :
28
-                $property->getType()->getDefinition();
27
+                $property->getType()->AsCollection()->ElementType()->getDefinition() : $property->getType()->getDefinition();
29 28
 
30 29
             EdmUtil::checkArgumentNull($validatedType, 'validatedType');
31 30
             if (!$validatedType->getTypeKind()->isPrimitive() &&
Please login to merge, or discard this patch.
src/Edm/Validation/ValidationContext.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -50,14 +50,12 @@
 block discarded – undo
50 50
         );
51 51
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts. */
52 52
         assert(
53
-            (is_array($isBad) ? new ReflectionMethod(...$isBad) :
54
-                new ReflectionFunction($isBad))->getParameters()[0]->getType()->getName() === IEdmElement::class,
53
+            (is_array($isBad) ? new ReflectionMethod(...$isBad) : new ReflectionFunction($isBad))->getParameters()[0]->getType()->getName() === IEdmElement::class,
55 54
             '$isBad should be a callable taking one parameter of Type IEdmElement'
56 55
         );
57 56
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts. */
58 57
         assert(
59
-            (is_array($isBad) ? new ReflectionMethod(...$isBad) :
60
-                new ReflectionFunction($isBad))->getReturnType()->getName() === 'bool',
58
+            (is_array($isBad) ? new ReflectionMethod(...$isBad) : new ReflectionFunction($isBad))->getReturnType()->getName() === 'bool',
61 59
             '$isBad should be a callable returning a boolean'
62 60
         );
63 61
         $this->model = $model;
Please login to merge, or discard this patch.
IEnumMember/EnumMemberValueMustHaveSameTypeAsUnderlyingType.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@
 block discarded – undo
28 28
         if (!$context->checkIsBad($enumMember->getDeclaringType()) &&
29 29
                        !$context->checkIsBad($enumMember->getDeclaringType()->getUnderlyingType()) &&
30 30
                        !ExpressionTypeChecker::TryAssertPrimitiveAsType(
31
-                           $enumMember->getValue(),
32
-                           EdmTypeSemantics::GetPrimitiveTypeReference($enumMember->getDeclaringType()->getUnderlyingType(), false),
33
-                           $discoveredErrors
34
-                       )) {
31
+                            $enumMember->getValue(),
32
+                            EdmTypeSemantics::GetPrimitiveTypeReference($enumMember->getDeclaringType()->getUnderlyingType(), false),
33
+                            $discoveredErrors
34
+                        )) {
35 35
             EdmUtil::checkArgumentNull($enumMember->Location(), 'enumMember->Location');
36 36
             $context->AddError(
37 37
                 $enumMember->Location(),
Please login to merge, or discard this patch.
IDirectValueAnnotation/DirectValueAnnotationHasXmlSerializableName.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
             // Note: this check can be done without the try/catch block, but we need XmlConvert.IsStartNCNameChar and
37 37
             // XmlConvert.IsNCNameChar, which are not available in 3.5.
38 38
             if (!XmlConvert::VerifyNCName($annotation->getName())) {
39
-                $value         = $annotation->getValue() ;
39
+                $value         = $annotation->getValue();
40 40
                 $errorLocation = ($value === null || !($value instanceof IValue)) ? null : $value->Location();
41 41
                 $error         = new EdmError(
42 42
                     $errorLocation,
Please login to merge, or discard this patch.