Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | class TTypeRefTypeTest extends TestCase |
||
| 9 | { |
||
| 10 | public function testSetDefaultValueNullString() |
||
| 11 | { |
||
| 12 | $foo = new TTypeRefType(); |
||
| 13 | $foo->setDefaultValue(null); |
||
| 14 | $this->assertEquals(null, $foo->getDefaultValue()); |
||
| 15 | } |
||
| 16 | |||
| 17 | public function testSetDefaultValueActualString() |
||
| 18 | { |
||
| 19 | $foo = new TTypeRefType(); |
||
| 20 | $foo->setDefaultValue("string"); |
||
| 21 | $this->assertEquals('string', $foo->getDefaultValue()); |
||
| 22 | } |
||
| 23 | |||
| 24 | public function testSetDefaultValueEmptyArrayAsString() |
||
| 25 | { |
||
| 26 | $expected = "Default value must be a string"; |
||
| 27 | $actual = null; |
||
| 28 | |||
| 29 | $foo = new TTypeRefType(); |
||
| 30 | try { |
||
| 31 | $foo->setDefaultValue([]); |
||
| 32 | } catch (\InvalidArgumentException $e) { |
||
| 33 | $actual = $e->getMessage(); |
||
| 34 | } |
||
| 35 | $this->assertEquals($expected, $actual); |
||
| 36 | } |
||
| 37 | |||
| 38 | public function testSetDefaultValueNonEmptyArrayAsString() |
||
| 39 | { |
||
| 40 | $expected = "Default value must be a string"; |
||
| 41 | $actual = null; |
||
| 42 | |||
| 43 | $foo = new TTypeRefType(); |
||
| 44 | try { |
||
| 45 | $foo->setDefaultValue(['a']); |
||
| 46 | } catch (\InvalidArgumentException $e) { |
||
| 47 | $actual = $e->getMessage(); |
||
| 48 | } |
||
| 49 | $this->assertEquals($expected, $actual); |
||
| 50 | } |
||
| 51 | |||
| 52 | public function testSetDefaultValueObjectAsString() |
||
| 53 | { |
||
| 54 | $expected = "Default value must be a string"; |
||
| 55 | $actual = null; |
||
| 56 | |||
| 57 | $foo = new TTypeRefType(); |
||
| 58 | try { |
||
| 59 | $foo->setDefaultValue(new \DateTime()); |
||
| 60 | } catch (\InvalidArgumentException $e) { |
||
| 61 | $actual = $e->getMessage(); |
||
| 62 | } |
||
| 63 | $this->assertEquals($expected, $actual); |
||
| 64 | } |
||
| 65 | } |
||
| 66 |