AlgoWeb\ODataMetadata\Util\XmlCharType::initInstance()

Complexity

Conditions	6
Paths	7

Size

Total Lines	32
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function initInstance(): void
    {
        if (self::$m_CharProperties != null) {
            return;
        }
        if (file_exists('XmlCharType.bin')) {
            $loaded                 = false;
            $file                   = fopen('XmlCharType.bin', 'rb');
            if (is_resource($file)) {
                self::$m_CharProperties = fopen('php://memory', 'w+b');

It seems like fopen('php://memory', 'w+b') can also be of type false. However, the property $m_CharProperties is declared as type null|resource. Maybe add an additional type check?

                if (is_resource(self::$m_CharProperties)) {
                    stream_copy_to_stream($file, self::$m_CharProperties);
                    $loaded = true;
                }
                fclose($file);
                if ($loaded) {
                    return;
                }
            }
        }

        $chProps                = [];
        self::$s_CharProperties = $chProps;
        self::setProperties(self::s_Whitespace, self::fWhitespace);
        self::setProperties(self::s_LetterXml4e, self::fLetter);
        self::setProperties(self::s_NCStartName, self::fNCStartNameSC);
        self::setProperties(self::s_NCName, self::fNCNameSC);
        self::setProperties(self::s_CharData, self::fCharData);
        self::setProperties(self::s_NCNameXml4e, self::fNCNameXml4e);
        self::setProperties(self::s_Text, self::fText);
        self::setProperties(self::s_AttrValue, self::fAttrValue);
        self::generateFile();
    }