Passed
Pull Request — master (#50)
by Alex
03:39
created
IFunctionImport/FunctionImportUnsupportedReturnTypeAfterV1.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
         assert($functionImport instanceof IFunctionImport);
25 25
         if (null !== $functionImport->getReturnType()) {
26 26
             $elementType = $functionImport->getReturnType()->IsCollection() ?
27
-                $functionImport->getReturnType()->AsCollection()->ElementType() :
28
-                $functionImport->getReturnType();
27
+                $functionImport->getReturnType()->AsCollection()->ElementType() : $functionImport->getReturnType();
29 28
             if (!$elementType->IsPrimitive() &&
30 29
                 !$elementType->IsEntity() &&
31 30
                 !$elementType->IsComplex() &&
Please login to merge, or discard this patch.
src/Helpers/ToTraceString.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
             case $element instanceof IProperty:
54 54
                 assert($element instanceof IProperty);
55 55
                 $type = $element->getType();
56
-                return $element->getName() ?? '' . ':' . ($type !== null ? self::ToTraceString($type) :'');
56
+                return $element->getName() ?? '' . ':' . ($type !== null ? self::ToTraceString($type) : '');
57 57
             case $element instanceof IEntityReferenceType:
58 58
                 assert($element instanceof IEntityReferenceType);
59 59
                 return strval(TypeKind::EntityReference()->getKey()) . '(' . (null !== $element->getEntityType() ?
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
             $sb,
189 189
             EdmConstants::FacetName_Srid,
190 190
             null !== $type->getSpatialReferenceIdentifier()
191
-                ? $type->getSpatialReferenceIdentifier(): EdmConstants::Value_SridVariable
191
+                ? $type->getSpatialReferenceIdentifier() : EdmConstants::Value_SridVariable
192 192
         );
193 193
         return $sb;
194 194
     }
Please login to merge, or discard this patch.
IFunctionImport/FunctionImportEntityTypeDoesNotMatchEntitySet.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,8 +32,7 @@
 block discarded – undo
32 32
         if (null !== $functionImport->getEntitySet() && null !== $returnType) {
33 33
             /** @var ITypeReference $elementType */
34 34
             $elementType = $returnType->IsCollection() ?
35
-                $returnType->AsCollection()->ElementType() :
36
-                $returnType;
35
+                $returnType->AsCollection()->ElementType() : $returnType;
37 36
             EdmUtil::checkArgumentNull($elementType->getDefinition(), 'elementType->getDefinition');
38 37
             if ($elementType->IsEntity()) {
39 38
                 $returnedEntityType = $elementType->AsEntity()->EntityDefinition();
Please login to merge, or discard this patch.
src/Library/Expressions/EdmIfExpression.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      */
48 48
     public function getExpressionKind(): ExpressionKind
49 49
     {
50
-        return ExpressionKind::If();
50
+        return ExpressionKind::If ();
51 51
     }
52 52
 
53 53
     /**
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      */
48 48
     public function getExpressionKind(): ExpressionKind
49 49
     {
50
-        return ExpressionKind::If();
50
+        return ExpressionKind::if();
51 51
     }
52 52
 
53 53
     /**
Please login to merge, or discard this patch.
src/Library/Expressions/EdmNullExpression.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function getValueKind(): ValueKind
34 34
     {
35
-        return ValueKind::Null();
35
+        return ValueKind::null();
36 36
     }
37 37
 
38 38
     /**
@@ -40,6 +40,6 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function getExpressionKind(): ExpressionKind
42 42
     {
43
-        return ExpressionKind::Null();
43
+        return ExpressionKind::null();
44 44
     }
45 45
 }
Please login to merge, or discard this patch.
src/Edm/Validation/Internal/InterfaceValidator/VisitorOfISchemaElement.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
     public function __construct()
21 21
     {
22 22
         $this->lookup[SchemaElementKind::TypeDefinition()->getKey()]  = ISchemaType::class;
23
-        $this->lookup[SchemaElementKind::Function()->getKey()]        = IFunction::class;
23
+        $this->lookup[SchemaElementKind::Function ()->getKey()]        = IFunction::class;
24 24
         $this->lookup[SchemaElementKind::ValueTerm()->getKey()]       = IValueTerm::class;
25 25
         $this->lookup[SchemaElementKind::EntityContainer()->getKey()] = IEntityContainer::class;
26 26
     }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
     public function __construct()
21 21
     {
22 22
         $this->lookup[SchemaElementKind::TypeDefinition()->getKey()]  = ISchemaType::class;
23
-        $this->lookup[SchemaElementKind::Function()->getKey()]        = IFunction::class;
23
+        $this->lookup[SchemaElementKind::function()->getKey()]        = IFunction::class;
24 24
         $this->lookup[SchemaElementKind::ValueTerm()->getKey()]       = IValueTerm::class;
25 25
         $this->lookup[SchemaElementKind::EntityContainer()->getKey()] = IEntityContainer::class;
26 26
     }
Please login to merge, or discard this patch.
src/Edm/Validation/Internal/InterfaceValidator/VisitorOfIValue.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
         $this->lookup[ValueKind::Floating()->getValue()]       = IFloatingValue::class;
40 40
         $this->lookup[ValueKind::Guid()->getValue()]           = IGuidValue::class;
41 41
         $this->lookup[ValueKind::Integer()->getValue()]        = IIntegerValue::class;
42
-        $this->lookup[ValueKind::Null()->getValue()]           = INullValue::class;
42
+        $this->lookup[ValueKind::null()->getValue()]           = INullValue::class;
43 43
         $this->lookup[ValueKind::String()->getValue()]         = IStringValue::class;
44 44
         $this->lookup[ValueKind::Structured()->getValue()]     = IStructuredValue::class;
45 45
         $this->lookup[ValueKind::Time()->getValue()]           = ITimeValue::class;
Please login to merge, or discard this patch.
src/Edm/Validation/ValidationContext.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,12 +56,10 @@
 block discarded – undo
56 56
         $stem = is_array($isBad) ? new ReflectionMethod(...$isBad) : new ReflectionFunction($isBad);
57 57
         $stemReturnType = $stem->getReturnType();
58 58
         $stemName = $stemReturnType instanceof ReflectionNamedType ?
59
-            $stemReturnType->getName() :
60
-            strval($stemReturnType);
59
+            $stemReturnType->getName() : strval($stemReturnType);
61 60
         $stemParmType = $stem->getParameters()[0]->getType();
62 61
         $stemParmName = $stemParmType instanceof ReflectionNamedType ?
63
-            $stemParmType->getName() :
64
-            strval($stemParmType);
62
+            $stemParmType->getName() : strval($stemParmType);
65 63
 
66 64
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts. */
67 65
         assert(
Please login to merge, or discard this patch.
src/Csdl/Internal/Serialization/EdmModelCsdlSchemaWriter.php 1 patch
Spacing   +5 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1352,8 +1352,7 @@  discard block
 block discarded – undo
1352 1352
      */
1353 1353
     public function WriteOptionalAttribute(string $attribute, $value, $defaultValue, callable $toXml): void
1354 1354
     {
1355
-        $stem = is_array($toXml) ? new ReflectionMethod(...$toXml) :
1356
-            new ReflectionFunction($toXml);
1355
+        $stem = is_array($toXml) ? new ReflectionMethod(...$toXml) : new ReflectionFunction($toXml);
1357 1356
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts.*/
1358 1357
         assert(
1359 1358
             1 === count(($stem)->getParameters()),
@@ -1361,8 +1360,7 @@  discard block
 block discarded – undo
1361 1360
         );
1362 1361
         $stemType = $stem->getReturnType();
1363 1362
         $name = $stemType instanceof ReflectionNamedType ?
1364
-            $stemType->getName() :
1365
-            strval($stemType);
1363
+            $stemType->getName() : strval($stemType);
1366 1364
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts.*/
1367 1365
         assert(
1368 1366
             'string' === $name,
@@ -1381,8 +1379,7 @@  discard block
 block discarded – undo
1381 1379
      */
1382 1380
     public function WriteRequiredAttribute(string $attribute, $value, callable $toXml): void
1383 1381
     {
1384
-        $stem = is_array($toXml) ? new ReflectionMethod(...$toXml) :
1385
-            new ReflectionFunction($toXml);
1382
+        $stem = is_array($toXml) ? new ReflectionMethod(...$toXml) : new ReflectionFunction($toXml);
1386 1383
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts.*/
1387 1384
         assert(
1388 1385
             1 === count($stem->getParameters()),
@@ -1390,8 +1387,7 @@  discard block
 block discarded – undo
1390 1387
         );
1391 1388
         $stemType = $stem->getReturnType();
1392 1389
         $name = $stemType instanceof ReflectionNamedType ?
1393
-            $stemType->getName() :
1394
-            strval($stemType);
1390
+            $stemType->getName() : strval($stemType);
1395 1391
         /* @noinspection PhpUnhandledExceptionInspection suppressing exceptions for asserts.*/
1396 1392
         assert(
1397 1393
             'string' === $name,
@@ -1488,7 +1484,7 @@  discard block
 block discarded – undo
1488 1484
 
1489 1485
     private static function SridAsXml(?int $i): string
1490 1486
     {
1491
-        return $i !== null ? strval($i) :  CsdlConstants::Value_SridVariable;
1487
+        return $i !== null ? strval($i) : CsdlConstants::Value_SridVariable;
1492 1488
     }
1493 1489
 
1494 1490
     /**
Please login to merge, or discard this patch.