Passed
Pull Request — master (#50)
by Alex
03:39
created
IEnumMember/EnumMemberValueMustHaveSameTypeAsUnderlyingType.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@
 block discarded – undo
28 28
         if (!$context->checkIsBad($enumMember->getDeclaringType()) &&
29 29
                        !$context->checkIsBad($enumMember->getDeclaringType()->getUnderlyingType()) &&
30 30
                        !ExpressionTypeChecker::TryAssertPrimitiveAsType(
31
-                           $enumMember->getValue(),
32
-                           EdmTypeSemantics::GetPrimitiveTypeReference($enumMember->getDeclaringType()->getUnderlyingType(), false),
33
-                           $discoveredErrors
34
-                       )) {
31
+                            $enumMember->getValue(),
32
+                            EdmTypeSemantics::GetPrimitiveTypeReference($enumMember->getDeclaringType()->getUnderlyingType(), false),
33
+                            $discoveredErrors
34
+                        )) {
35 35
             EdmUtil::checkArgumentNull($enumMember->Location(), 'enumMember->Location');
36 36
             $context->AddError(
37 37
                 $enumMember->Location(),
Please login to merge, or discard this patch.
IDirectValueAnnotation/DirectValueAnnotationHasXmlSerializableName.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
             // Note: this check can be done without the try/catch block, but we need XmlConvert.IsStartNCNameChar and
37 37
             // XmlConvert.IsNCNameChar, which are not available in 3.5.
38 38
             if (!XmlConvert::VerifyNCName($annotation->getName())) {
39
-                $value         = $annotation->getValue() ;
39
+                $value         = $annotation->getValue();
40 40
                 $errorLocation = ($value === null || !($value instanceof IValue)) ? null : $value->Location();
41 41
                 $error         = new EdmError(
42 42
                     $errorLocation,
Please login to merge, or discard this patch.
src/Edm/Validation/Internal/InterfaceValidator/VisitorOfIType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
                 break;
99 99
         }
100 100
 
101
-        return null !== $typeKindError ? [$typeKindError ] : null;
101
+        return null !== $typeKindError ? [$typeKindError] : null;
102 102
     }
103 103
 
104 104
     public function forType(): string
Please login to merge, or discard this patch.
src/Helpers/EdmElementComparer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 
145 145
         $thisTypeKeys  = array_keys($thisFunction->getParameters());
146 146
         $otherTypeKeys = array_keys($otherFunction->getParameters());
147
-        $keyCount      =  count($thisTypeKeys);
147
+        $keyCount      = count($thisTypeKeys);
148 148
         for ($i = 0; $i < $keyCount; ++$i) {
149 149
             if (!self::isEquivalentTo(
150 150
                 $thisFunction->getParameters()[$thisTypeKeys[$i]],
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         $thisTypeKeys  = array_keys($thisType->getDeclaredProperties());
209 209
         $otherTypeKeys = array_keys($otherType->getDeclaredProperties());
210
-        $keyCount      =  count($thisTypeKeys);
210
+        $keyCount      = count($thisTypeKeys);
211 211
         for ($i = 0; $i < $keyCount; ++$i) {
212 212
             if (!self::isEquivalentTo(
213 213
                 $thisType->getDeclaredProperties()[$thisTypeKeys[$i]],
Please login to merge, or discard this patch.
src/Helpers/VocabularyAnnotationHelpers.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
             $annotation,
52 52
             EdmConstants::InternalUri,
53 53
             CsdlConstants::AnnotationSerializationLocationAnnotation,
54
-            (object)$location
54
+            (object) $location
55 55
         );
56 56
     }
57 57
 
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
         /** @var IVocabularyAnnotation $annotation */
20 20
         $annotation = $this;
21 21
         return $annotation->GetSerializationLocation($model) ==
22
-               EdmVocabularyAnnotationSerializationLocation::Inline() || null === $annotation->TargetString();
22
+                EdmVocabularyAnnotationSerializationLocation::Inline() || null === $annotation->TargetString();
23 23
     }
24 24
 
25 25
     public function TargetString(): string
Please login to merge, or discard this patch.
src/Edm/Validation/Internal/InterfaceValidator/VisitorOfIExpression.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
         $this->lookup[ExpressionKind::ValueTermReference()->getValue()]         = IValueTermReferenceExpression::class;
62 62
         $this->lookup[ExpressionKind::EntitySetReference()->getValue()]         = IEntitySetReferenceExpression::class;
63 63
         $this->lookup[ExpressionKind::EnumMemberReference()->getValue()]        = IEnumMemberReferenceExpression::class;
64
-        $this->lookup[ExpressionKind::If()->getValue()]                         = IIfExpression::class;
64
+        $this->lookup[ExpressionKind::If ()->getValue()]                         = IIfExpression::class;
65 65
         $this->lookup[ExpressionKind::AssertType()->getValue()]                 = IAssertTypeExpression::class;
66 66
         $this->lookup[ExpressionKind::IsType()->getValue()]                     = IIsTypeExpression::class;
67 67
         $this->lookup[ExpressionKind::FunctionApplication()->getValue()]        = IApplyExpression::class;
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,9 @@
 block discarded – undo
61 61
         $this->lookup[ExpressionKind::ValueTermReference()->getValue()]         = IValueTermReferenceExpression::class;
62 62
         $this->lookup[ExpressionKind::EntitySetReference()->getValue()]         = IEntitySetReferenceExpression::class;
63 63
         $this->lookup[ExpressionKind::EnumMemberReference()->getValue()]        = IEnumMemberReferenceExpression::class;
64
-        $this->lookup[ExpressionKind::If()->getValue()]                         = IIfExpression::class;
64
+        $this->lookup[ExpressionKind::If() {
65
+            ->getValue()]                         = IIfExpression::class;
66
+        }
65 67
         $this->lookup[ExpressionKind::AssertType()->getValue()]                 = IAssertTypeExpression::class;
66 68
         $this->lookup[ExpressionKind::IsType()->getValue()]                     = IIsTypeExpression::class;
67 69
         $this->lookup[ExpressionKind::FunctionApplication()->getValue()]        = IApplyExpression::class;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         $this->lookup[ExpressionKind::DecimalConstant()->getValue()]            = IDecimalConstantExpression::class;
52 52
         $this->lookup[ExpressionKind::FloatingConstant()->getValue()]           = IFloatingConstantExpression::class;
53 53
         $this->lookup[ExpressionKind::GuidConstant()->getValue()]               = IGuidConstantExpression::class;
54
-        $this->lookup[ExpressionKind::Null()->getValue()]                       = INullExpression::class;
54
+        $this->lookup[ExpressionKind::null()->getValue()]                       = INullExpression::class;
55 55
         $this->lookup[ExpressionKind::Record()->getValue()]                     = IRecordExpression::class;
56 56
         $this->lookup[ExpressionKind::Collection()->getValue()]                 = ICollectionExpression::class;
57 57
         $this->lookup[ExpressionKind::Path()->getValue()]                       = IPathExpression::class;
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         $this->lookup[ExpressionKind::ValueTermReference()->getValue()]         = IValueTermReferenceExpression::class;
62 62
         $this->lookup[ExpressionKind::EntitySetReference()->getValue()]         = IEntitySetReferenceExpression::class;
63 63
         $this->lookup[ExpressionKind::EnumMemberReference()->getValue()]        = IEnumMemberReferenceExpression::class;
64
-        $this->lookup[ExpressionKind::If()->getValue()]                         = IIfExpression::class;
64
+        $this->lookup[ExpressionKind::if()->getValue()]                         = IIfExpression::class;
65 65
         $this->lookup[ExpressionKind::AssertType()->getValue()]                 = IAssertTypeExpression::class;
66 66
         $this->lookup[ExpressionKind::IsType()->getValue()]                     = IIsTypeExpression::class;
67 67
         $this->lookup[ExpressionKind::FunctionApplication()->getValue()]        = IApplyExpression::class;
Please login to merge, or discard this patch.
src/ModelVisitorConcerns/VisitElements.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     {
35 35
         /** @var EdmModelVisitor $this */
36 36
         switch ($element->getSchemaElementKind()) {
37
-            case SchemaElementKind::Function():
37
+            case SchemaElementKind::Function ():
38 38
                 assert($element instanceof IFunction);
39 39
                 $this->processFunction($element);
40 40
                 break;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     {
35 35
         /** @var EdmModelVisitor $this */
36 36
         switch ($element->getSchemaElementKind()) {
37
-            case SchemaElementKind::Function():
37
+            case SchemaElementKind::function():
38 38
                 assert($element instanceof IFunction);
39 39
                 $this->processFunction($element);
40 40
                 break;
Please login to merge, or discard this patch.
src/ModelVisitorConcerns/VisitAnnotations.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
     public function visitAnnotations(iterable $annotations): void
29 29
     {
30 30
         /** @var EdmModelVisitor $this */
31
-        self::visitCollection($annotations, [$this,'visitAnnotation']);
31
+        self::visitCollection($annotations, [$this, 'visitAnnotation']);
32 32
     }
33 33
 
34 34
     /**
Please login to merge, or discard this patch.
StructuralPropertyInvalidPropertyTypeConcurrencyMode.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,7 @@
 block discarded – undo
43 43
                 StringConst::EdmModel_Validator_Semantic_InvalidPropertyTypeConcurrencyMode(
44 44
                     (
45 45
                         $propType->IsCollection() ?
46
-                        EdmConstants::Type_Collection :
47
-                        $key
46
+                        EdmConstants::Type_Collection : $key
48 47
                     )
49 48
                 )
50 49
             );
Please login to merge, or discard this patch.