| Conditions | 34 |
| Paths | 34 |
| Total Lines | 53 |
| Code Lines | 50 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 63 | public function visitPrimitiveTypeReference(IPrimitiveTypeReference $reference): void |
||
| 64 | { |
||
| 65 | /** @var EdmModelVisitor $this */ |
||
| 66 | switch ($reference->primitiveKind()) { |
||
| 67 | case PrimitiveTypeKind::Binary(): |
||
| 68 | $this->processBinaryTypeReference($reference->asBinary()); |
||
| 69 | break; |
||
| 70 | case PrimitiveTypeKind::Decimal(): |
||
| 71 | $this->processDecimalTypeReference($reference->asDecimal()); |
||
| 72 | break; |
||
| 73 | case PrimitiveTypeKind::String(): |
||
| 74 | $this->processStringTypeReference($reference->asString()); |
||
| 75 | break; |
||
| 76 | case PrimitiveTypeKind::DateTime(): |
||
| 77 | case PrimitiveTypeKind::DateTimeOffset(): |
||
| 78 | case PrimitiveTypeKind::Time(): |
||
| 79 | $this->processTemporalTypeReference($reference->asTemporal()); |
||
| 80 | break; |
||
| 81 | case PrimitiveTypeKind::Geography(): |
||
| 82 | case PrimitiveTypeKind::GeographyPoint(): |
||
| 83 | case PrimitiveTypeKind::GeographyLineString(): |
||
| 84 | case PrimitiveTypeKind::GeographyPolygon(): |
||
| 85 | case PrimitiveTypeKind::GeographyCollection(): |
||
| 86 | case PrimitiveTypeKind::GeographyMultiPolygon(): |
||
| 87 | case PrimitiveTypeKind::GeographyMultiLineString(): |
||
| 88 | case PrimitiveTypeKind::GeographyMultiPoint(): |
||
| 89 | case PrimitiveTypeKind::Geometry(): |
||
| 90 | case PrimitiveTypeKind::GeometryPoint(): |
||
| 91 | case PrimitiveTypeKind::GeometryLineString(): |
||
| 92 | case PrimitiveTypeKind::GeometryPolygon(): |
||
| 93 | case PrimitiveTypeKind::GeometryCollection(): |
||
| 94 | case PrimitiveTypeKind::GeometryMultiPolygon(): |
||
| 95 | case PrimitiveTypeKind::GeometryMultiLineString(): |
||
| 96 | case PrimitiveTypeKind::GeometryMultiPoint(): |
||
| 97 | $this->processSpatialTypeReference($reference->asSpatial()); |
||
| 98 | break; |
||
| 99 | case PrimitiveTypeKind::Boolean(): |
||
| 100 | case PrimitiveTypeKind::Byte(): |
||
| 101 | case PrimitiveTypeKind::Double(): |
||
| 102 | case PrimitiveTypeKind::Guid(): |
||
| 103 | case PrimitiveTypeKind::Int16(): |
||
| 104 | case PrimitiveTypeKind::Int32(): |
||
| 105 | case PrimitiveTypeKind::Int64(): |
||
| 106 | case PrimitiveTypeKind::SByte(): |
||
| 107 | case PrimitiveTypeKind::Single(): |
||
| 108 | case PrimitiveTypeKind::Stream(): |
||
| 109 | case PrimitiveTypeKind::None(): |
||
| 110 | $this->processPrimitiveTypeReference($reference); |
||
| 111 | break; |
||
| 112 | default: |
||
| 113 | throw new InvalidOperationException( |
||
| 114 | StringConst::UnknownEnumVal_PrimitiveKind( |
||
| 115 | $reference->primitiveKind()->getKey() |
||
| 116 | ) |
||
| 121 |