c-harris /
ODataMetadata
| Conditions | 28 |
| Paths | 28 |
| Total Lines | 114 |
| Code Lines | 111 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 52 | public function visitExpression(IExpression $expression): void |
||
| 53 | { |
||
| 54 | /** @var EdmModelVisitor $this */ |
||
| 55 | switch ($expression->getExpressionKind()) { |
||
| 56 | case ExpressionKind::AssertType(): |
||
| 57 | assert($expression instanceof IAssertTypeExpression); |
||
| 58 | $this->processAssertTypeExpression($expression); |
||
| 59 | break; |
||
| 60 | case ExpressionKind::BinaryConstant(): |
||
| 61 | assert($expression instanceof IBinaryConstantExpression); |
||
| 62 | $this->processBinaryConstantExpression($expression); |
||
| 63 | break; |
||
| 64 | case ExpressionKind::BooleanConstant(): |
||
| 65 | assert($expression instanceof IBooleanConstantExpression); |
||
| 66 | $this->processBooleanConstantExpression($expression); |
||
| 67 | break; |
||
| 68 | case ExpressionKind::Collection(): |
||
| 69 | assert($expression instanceof ICollectionExpression); |
||
| 70 | $this->processCollectionExpression($expression); |
||
| 71 | break; |
||
| 72 | case ExpressionKind::DateTimeConstant(): |
||
| 73 | assert($expression instanceof IDateTimeConstantExpression); |
||
| 74 | $this->processDateTimeConstantExpression($expression); |
||
| 75 | break; |
||
| 76 | case ExpressionKind::DateTimeOffsetConstant(): |
||
| 77 | assert($expression instanceof IDateTimeOffsetConstantExpression); |
||
| 78 | $this->processDateTimeOffsetConstantExpression($expression); |
||
| 79 | break; |
||
| 80 | case ExpressionKind::DecimalConstant(): |
||
| 81 | assert($expression instanceof IDecimalConstantExpression); |
||
| 82 | $this->processDecimalConstantExpression($expression); |
||
| 83 | break; |
||
| 84 | case ExpressionKind::EntitySetReference(): |
||
| 85 | assert($expression instanceof IEntitySetReferenceExpression); |
||
| 86 | $this->processEntitySetReferenceExpression($expression); |
||
| 87 | break; |
||
| 88 | case ExpressionKind::EnumMemberReference(): |
||
| 89 | assert($expression instanceof IEnumMemberReferenceExpression); |
||
| 90 | $this->processEnumMemberReferenceExpression($expression); |
||
| 91 | break; |
||
| 92 | case ExpressionKind::FloatingConstant(): |
||
| 93 | assert($expression instanceof IFloatingConstantExpression); |
||
| 94 | $this->processFloatingConstantExpression($expression); |
||
| 95 | break; |
||
| 96 | case ExpressionKind::FunctionApplication(): |
||
| 97 | assert($expression instanceof IApplyExpression); |
||
| 98 | $this->processFunctionApplicationExpression($expression); |
||
| 99 | break; |
||
| 100 | case ExpressionKind::FunctionReference(): |
||
| 101 | assert($expression instanceof IFunctionReferenceExpression); |
||
| 102 | $this->processFunctionReferenceExpression($expression); |
||
| 103 | break; |
||
| 104 | case ExpressionKind::GuidConstant(): |
||
| 105 | assert($expression instanceof IGuidConstantExpression); |
||
| 106 | $this->processGuidConstantExpression($expression); |
||
| 107 | break; |
||
| 108 | case ExpressionKind::If(): |
||
| 109 | assert($expression instanceof IIfExpression); |
||
| 110 | $this->processIfExpression($expression); |
||
| 111 | break; |
||
| 112 | case ExpressionKind::IntegerConstant(): |
||
| 113 | assert($expression instanceof IIntegerConstantExpression); |
||
| 114 | $this->processIntegerConstantExpression($expression); |
||
| 115 | break; |
||
| 116 | case ExpressionKind::IsType(): |
||
| 117 | assert($expression instanceof IIsTypeExpression); |
||
| 118 | $this->processIsTypeExpression($expression); |
||
| 119 | break; |
||
| 120 | case ExpressionKind::ParameterReference(): |
||
| 121 | assert($expression instanceof IParameterReferenceExpression); |
||
| 122 | $this->processParameterReferenceExpression($expression); |
||
| 123 | break; |
||
| 124 | case ExpressionKind::LabeledExpressionReference(): |
||
| 125 | assert($expression instanceof ILabeledExpressionReferenceExpression); |
||
| 126 | $this->processLabeledExpressionReferenceExpression($expression); |
||
| 127 | break; |
||
| 128 | case ExpressionKind::Labeled(): |
||
| 129 | assert($expression instanceof ILabeledExpression); |
||
| 130 | $this->processLabeledExpression($expression); |
||
| 131 | break; |
||
| 132 | case ExpressionKind::Null(): |
||
| 133 | assert($expression instanceof INullExpression); |
||
| 134 | $this->processNullConstantExpression($expression); |
||
| 135 | break; |
||
| 136 | case ExpressionKind::Path(): |
||
| 137 | assert($expression instanceof IPathExpression); |
||
| 138 | $this->processPathExpression($expression); |
||
| 139 | break; |
||
| 140 | case ExpressionKind::PropertyReference(): |
||
| 141 | assert($expression instanceof IPropertyReferenceExpression); |
||
| 142 | $this->processPropertyReferenceExpression($expression); |
||
| 143 | break; |
||
| 144 | case ExpressionKind::Record(): |
||
| 145 | assert($expression instanceof IRecordExpression); |
||
| 146 | $this->processRecordExpression($expression); |
||
| 147 | break; |
||
| 148 | case ExpressionKind::StringConstant(): |
||
| 149 | assert($expression instanceof IStringConstantExpression); |
||
| 150 | $this->processStringConstantExpression($expression); |
||
| 151 | break; |
||
| 152 | case ExpressionKind::TimeConstant(): |
||
| 153 | assert($expression instanceof ITimeConstantExpression); |
||
| 154 | $this->processTimeConstantExpression($expression); |
||
| 155 | break; |
||
| 156 | case ExpressionKind::ValueTermReference(): |
||
| 157 | assert($expression instanceof IPropertyReferenceExpression); |
||
| 158 | $this->processPropertyReferenceExpression($expression); |
||
| 159 | break; |
||
| 160 | case ExpressionKind::None(): |
||
| 161 | $this->processExpression($expression); |
||
| 162 | break; |
||
| 163 | default: |
||
| 164 | throw new InvalidOperationException( |
||
| 165 | StringConst::UnknownEnumVal_TermKind($expression->getExpressionKind()->getKey()) |
||
| 166 | ); |
||
| 178 |
