c-harris /
ODataMetadata
| Conditions | 33 |
| Paths | 33 |
| Total Lines | 43 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 21 | public static function getPrimitiveTypeReference(IPrimitiveType $type, bool $isNullable): IPrimitiveTypeReference |
||
| 22 | { |
||
| 23 | switch ($type->getPrimitiveKind()) { |
||
| 24 | case PrimitiveTypeKind::Boolean(): |
||
| 25 | case PrimitiveTypeKind::Byte(): |
||
| 26 | case PrimitiveTypeKind::Double(): |
||
| 27 | case PrimitiveTypeKind::Guid(): |
||
| 28 | case PrimitiveTypeKind::Int16(): |
||
| 29 | case PrimitiveTypeKind::Int32(): |
||
| 30 | case PrimitiveTypeKind::Int64(): |
||
| 31 | case PrimitiveTypeKind::SByte(): |
||
| 32 | case PrimitiveTypeKind::Single(): |
||
| 33 | case PrimitiveTypeKind::Stream(): |
||
| 34 | return new EdmPrimitiveTypeReference($type, $isNullable); |
||
| 35 | case PrimitiveTypeKind::Binary(): |
||
| 36 | return new EdmBinaryTypeReference($type, $isNullable); |
||
| 37 | case PrimitiveTypeKind::String(): |
||
| 38 | return new EdmStringTypeReference($type, $isNullable); |
||
| 39 | case PrimitiveTypeKind::Decimal(): |
||
| 40 | return new EdmDecimalTypeReference($type, $isNullable); |
||
| 41 | case PrimitiveTypeKind::DateTime(): |
||
| 42 | case PrimitiveTypeKind::DateTimeOffset(): |
||
| 43 | case PrimitiveTypeKind::Time(): |
||
| 44 | return new EdmTemporalTypeReference($type, $isNullable); |
||
| 45 | case PrimitiveTypeKind::Geography(): |
||
| 46 | case PrimitiveTypeKind::GeographyPoint(): |
||
| 47 | case PrimitiveTypeKind::GeographyLineString(): |
||
| 48 | case PrimitiveTypeKind::GeographyPolygon(): |
||
| 49 | case PrimitiveTypeKind::GeographyCollection(): |
||
| 50 | case PrimitiveTypeKind::GeographyMultiPolygon(): |
||
| 51 | case PrimitiveTypeKind::GeographyMultiLineString(): |
||
| 52 | case PrimitiveTypeKind::GeographyMultiPoint(): |
||
| 53 | case PrimitiveTypeKind::Geometry(): |
||
| 54 | case PrimitiveTypeKind::GeometryPoint(): |
||
| 55 | case PrimitiveTypeKind::GeometryLineString(): |
||
| 56 | case PrimitiveTypeKind::GeometryPolygon(): |
||
| 57 | case PrimitiveTypeKind::GeometryCollection(): |
||
| 58 | case PrimitiveTypeKind::GeometryMultiPolygon(): |
||
| 59 | case PrimitiveTypeKind::GeometryMultiLineString(): |
||
| 60 | case PrimitiveTypeKind::GeometryMultiPoint(): |
||
| 61 | return new EdmSpatialTypeReference($type, $isNullable); |
||
| 62 | default: |
||
| 63 | throw new InvalidOperationException(StringConst::EdmPrimitive_UnexpectedKind()); |
||
| 64 | } |
||
| 67 |
