Nip\View\Traits\HasPathsTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

93.75%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	initBasePath()	0	3	1
A	getBasePath()	0	7	2
A	generateBasePath()	0	7	2
A	setBasePath()	0	6	1

<?php

namespace Nip\View\Traits;

/**
 * Trait HasPathsTrait
 * @package Nip\View\Traits
 */
trait HasPathsTrait
{
    protected $basePath = null;

    /**
     * @return string
     */
    public function getBasePath()
    {
        if ($this->basePath === null) {
            $this->initBasePath();
        }

        return $this->basePath;
    }

    /**
     * @param string $path
     * @return $this
     */
    public function setBasePath($path)
    {
        $path = rtrim($path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
        $this->basePath = $path;
        $this->getFinder()->setPaths($path);

It seems like getFinder() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;
    }

    protected function initBasePath()
    {
        $this->setBasePath($this->generateBasePath());
    }

    /**
     * @return string
     */
    protected function generateBasePath()
    {
        if (defined('VIEWS_PATH')) {
            return VIEWS_PATH;

The constant Nip\View\Traits\VIEWS_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        return false;

The expression return false returns the type false which is incompatible with the documented return type string.

    }
}