bytic / services-google-recaptcha

src/Config/Traits/CanInitFromEnviromentTrait.php

<?php

namespace ByTIC\GoogleRecaptcha\Config\Traits;

use ByTIC\GoogleRecaptcha\Config\Config;
use ByTIC\GoogleRecaptcha\Config\ConfigEnv;

/**
 * Trait CanInitFromEnviromentTrait
 * @package ByTIC\GoogleRecaptcha\Config\Traits
 */
trait CanInitFromEnviromentTrait
{

    /**
     * @return static|Config
     */
    public static function fromEnv()
    {
        $config = new static();
        $config->initFromEnv();
        return $config;
    }

    /**
     * @return bool
     */
    public static function canInitFromEnv()
    {
        if (empty(static::getEnvVar(ConfigEnv::SITE_KEY))) {
            return false;
        }
        if (empty(static::getEnvVar(ConfigEnv::SECRET_KEY))) {
            return false;
        }
        return true;
    }

    protected function initFromEnv()
    {
        $this->setEnabled(static::getEnvVar(ConfigEnv::ENABLED));

It seems like setEnabled() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setSiteKey(static::getEnvVar(ConfigEnv::SITE_KEY));

It seems like setSiteKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setSecretKey(static::getEnvVar(ConfigEnv::SECRET_KEY));

It seems like setSecretKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $value
     * @param null $default

Are you sure the doc-type for parameter $default is correct as it would always require null to be passed?

     * @return mixed|null
     */
    protected static function getEnvVar($value, $default = null)
    {
        if (isset($_ENV[$value])) {
            return $_ENV[$value];
        }
        return $default;
    }
}