bytic / router

src/ServiceProvider/Traits/RouterTrait.php

<?php

namespace Nip\Router\ServiceProvider\Traits;

use Nip\Http\Request;
use Nip\Router\RequestContext;
use Nip\Router\Router;
use Symfony\Component\Routing\RouterInterface;

/**
 * Trait RouterTrait
 * @package Nip\Router\ServiceProvider\Traits
 */
trait RouterTrait
{
    public function registerRouter()
    {
        $this->getContainer()->share('router', function () {

It seems like getContainer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->newRouter();
        });

        $this->getContainer()->add(RouterInterface::class, Router::class);

        $this->getContainer()->share(Router::class, function () {
            return $this->getContainer()->get('router');
        });
    }

    /**
     * @return Router
     */
    public function newRouter()
    {
        $app = $this->getContainer()->get('app');

        /** @var Router $router */
        $router = $this->getContainer()->make(
            RouterInterface::class,
            [
                'loader' => $this->getContainer()->get('routing.loader'),
                'resource' => 'routes.php',
                'options' => [
                    'cache_dir' => $app->getCachedRoutesPath(),
                ]
            ]
        );

        $request = Request::instance();
        if ($request instanceof Request) {

$request is always a sub-type of Nip\Http\Request.

            $router->setContext((new RequestContext())->fromRequest($request));
        }
        return $router;
    }
}