Issues in HasBaseRoutesTrait.php (master) - Issues in master - bytic/router - Measure and Improve Code Quality continuously with Scrutinizer

Issues (105)

src/RouteFactory/HasBaseRoutesTrait.php (4 issues)

Labels

Severity

Minor 4

<?php
declare(strict_types=1);

namespace Nip\Router\RouteFactory;

use Nip\Router\Route\LiteralRoute;
use Nip\Router\Route\Route;
use Nip\Router\Route\StandardRoute;
use Nip\Router\RouteCollection;

/**
 * Trait HasBaseRoutesTrait
 * @package Nip\Router\RouteFactory
 */
trait HasBaseRoutesTrait
{

    /**
     * @param RouteCollection $collection
     * @param $name
     * @param $class
     * @param string $mapPrefix
     * @param array $params
     * @return mixed
     */
    public static function generateIndexRoute(
        $collection,
        $name,
        $class = null,
        $mapPrefix = '',
        $params = []
    ) {
        $params["controller"] = "index";
        $params["action"] = "index";

        self::generateLiteralRoute(
            $collection, $name . '.slash', $class, $mapPrefix, '', $params
        );

        return self::generateLiteralRoute(
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $collection, $name, $class, $mapPrefix, '/', $params
        );
    }

    /**
     * @param RouteCollection $collection
     * @param $name
     * @param $class
     * @param string $mapPrefix
     * @param string $map
     * @param array $params
     * @return mixed
     */
    public static function generateLiteralRoute(
        $collection,
        $name,
        $class = null,
        $mapPrefix = '',
        $map = '/',
        $params = []
    ) {
        $map = $mapPrefix . $map;
        $class = empty($class) ? LiteralRoute::class : $class;

        return self::generateGenericRoute($collection, $name, $class, $map, $params);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @param RouteCollection $collection
     * @param $name
     * @param $class
     * @param string $map
     * @param array $params
     * @return mixed
     */
    public static function generateGenericRoute(
        $collection,
        $name,
        $class = null,
        $map = '',
        $params = []
    ) {
        $map = str_replace('//', '/', $map);
        $class = static::generateRouteClassName($class);

        $route = new $class($map, $params);
        return $collection->addRoute($route, $name);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @param RouteCollection $collection
     * @param $name
     * @param $class
     * @param string $mapPrefix
     * @param string $map
     * @param array $params
     */
    public static function generateStandardRoute(
        $collection,
        $name,
        $class = null,
        $mapPrefix = '',
        $map = null,
        $params = []
    ) {
        $class = empty($class) ? StandardRoute::class : $class;
        $map = $map ? $map : '/{controller}/{action?index}';

        self::generateGenericRoute($collection, $name, $class, $mapPrefix . $map, $params);

        $params['action'] = 'index';
        self::generateGenericRoute($collection, $name . '.index', $class, $mapPrefix . '/{controller}/',
            $params);
    }

    /**
     * @param null $class

     * @return string
     */
    protected static function generateRouteClassName($class = null)
    {
        if (empty($class)) {
            return Route::class;
        }

        if (class_exists($class)) {
            return $class;
        }

        $maps = [
            LiteralRoute::class => ['_Literal', '\Literal'],
            StandardRoute::class => ['_Standard', '\Standard']
        ];
        foreach ($maps as $routeClass => $needles) {
            foreach ($needles as $needle) {
                if (strpos($class, $needle) !== false) {
                    return $routeClass;
                }
            }
        }

        return Route::class;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Nip\Router\RouteFactory;
5
6		use Nip\Router\Route\LiteralRoute;
7		use Nip\Router\Route\Route;
8		use Nip\Router\Route\StandardRoute;
9		use Nip\Router\RouteCollection;
10
11		/**
12		* Trait HasBaseRoutesTrait
13		* @package Nip\Router\RouteFactory
14		*/
15		trait HasBaseRoutesTrait
16		{
17
18		/**
19		* @param RouteCollection $collection
20		* @param $name
21		* @param $class
22		* @param string $mapPrefix
23		* @param array $params
24		* @return mixed
25	2	*/
26		public static function generateIndexRoute(
27		$collection,
28		$name,
29		$class = null,
30		$mapPrefix = '',
31		$params = []
32	2	) {
33	2	$params["controller"] = "index";
34		$params["action"] = "index";
35	2
36	2	self::generateLiteralRoute(
37		$collection, $name . '.slash', $class, $mapPrefix, '', $params
38		);
39
40		return self::generateLiteralRoute(
		0 ignored issues – show Bug introduced 2020-05-15 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `self::generateLiteralRou...apPrefix, '/', $params)` targeting `Nip\Router\RouteFactory\...:generateLiteralRoute()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
41		$collection, $name, $class, $mapPrefix, '/', $params
42		);
43		}
44
45		/**
46		* @param RouteCollection $collection
47		* @param $name
48		* @param $class
49		* @param string $mapPrefix
50		* @param string $map
51		* @param array $params
52		* @return mixed
53	2	*/
54		public static function generateLiteralRoute(
55		$collection,
56		$name,
57		$class = null,
58		$mapPrefix = '',
59		$map = '/',
60		$params = []
61	2	) {
62	2	$map = $mapPrefix . $map;
63		$class = empty($class) ? LiteralRoute::class : $class;
64	2
65		return self::generateGenericRoute($collection, $name, $class, $map, $params);
		0 ignored issues – show Bug introduced 2020-05-15 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `self::generateGenericRou... $class, $map, $params)` targeting `Nip\Router\RouteFactory\...:generateGenericRoute()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
66		}
67
68		/**
69		* @param RouteCollection $collection
70		* @param $name
71		* @param $class
72		* @param string $map
73		* @param array $params
74		* @return mixed
75	2	*/
76		public static function generateGenericRoute(
77		$collection,
78		$name,
79		$class = null,
80		$map = '',
81		$params = []
82	2	) {
83	2	$map = str_replace('//', '/', $map);
84		$class = static::generateRouteClassName($class);
85	2
86		$route = new $class($map, $params);
87		return $collection->addRoute($route, $name);
		0 ignored issues – show Bug introduced 2020-05-15 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$collection->addRoute($route, $name)` targeting `Nip\Router\RouteCollection::addRoute()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
88		}
89
90		/**
91		* @param RouteCollection $collection
92		* @param $name
93		* @param $class
94		* @param string $mapPrefix
95		* @param string $map
96		* @param array $params
97		*/
98		public static function generateStandardRoute(
99		$collection,
100		$name,
101		$class = null,
102		$mapPrefix = '',
103		$map = null,
104		$params = []
105		) {
106		$class = empty($class) ? StandardRoute::class : $class;
107		$map = $map ? $map : '/{controller}/{action?index}';
108
109		self::generateGenericRoute($collection, $name, $class, $mapPrefix . $map, $params);
110
111		$params['action'] = 'index';
112		self::generateGenericRoute($collection, $name . '.index', $class, $mapPrefix . '/{controller}/',
113		$params);
114		}
115
116		/**
117		* @param null $class
		0 ignored issues – show Documentation Bug introduced 2020-05-15 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the doc-type for parameter `$class` is correct as it would always require `null` to be passed? Loading history...
118		* @return string
119	2	*/
120		protected static function generateRouteClassName($class = null)
121	2	{
122		if (empty($class)) {
123		return Route::class;
124		}
125	2
126	2	if (class_exists($class)) {
127		return $class;
128		}
129
130		$maps = [
131		LiteralRoute::class => ['_Literal', '\Literal'],
132		StandardRoute::class => ['_Standard', '\Standard']
133		];
134		foreach ($maps as $routeClass => $needles) {
135		foreach ($needles as $needle) {
136		if (strpos($class, $needle) !== false) {
137		return $routeClass;
138		}
139		}
140		}
141
142		return Route::class;
143		}
144		}
145

bytic / router

Issues (105)

src/RouteFactory/HasBaseRoutesTrait.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like