bytic / router

src/RouteCollections/Traits/CollectionsOperationsTrait.php

<?php
declare(strict_types=1);

namespace Nip\Router\RouteCollections\Traits;

use Nip\Router\Route\Route;

/**
 * Trait CollectionsOperationsTrait
 * @package Nip\Router\RouteCollections\Traits
 */
trait CollectionsOperationsTrait
{
    /**
     * @inheritdoc
     * @deprecated Use all()
     */
    public function getRoutes()
    {
        return $this->all();

It seems like all() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param array $routes
     */
    public function setRoutes($routes)
    {
        foreach ($routes as $route) {
            $this->addRoute($route);
        }
    }

    /**
     * @param Route $route
     */
    public function prependRoute($route)
    {
        $routes = $this->all();
        $this->addRoute($route);
        $this->setRoutes($routes);
    }

    /**
     * @param $route
     * @return bool
     */
    public function has($route)
    {
        $name = $route instanceof Route ? $route->getName() : $route;

        return $this->get($name) instanceof Route;
    }

    /**
     * @param $route
     * @return Route|\Symfony\Component\Routing\Route|null
     */
    public function get($route): ?\Symfony\Component\Routing\Route
    {
        $name = $route instanceof Route ? $route->getName() : $route;
        return parent::get($name);
    }


    /**
     * @param Route $route
     * @param null $name

Are you sure the doc-type for parameter $name is correct as it would always require null to be passed?

     * @return
     */
    public function addRoute($route, $name = null)
    {
        if ($name) {

$name is of type null, thus it always evaluated to false.

            $route->setName($name);
        } else {
            $name = $route->getName();
        }
        return $this->add($name, $route);

It seems like add() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}