bytic / router

src/Generator/Traits/HasRequestTrait.php

<?php

namespace Nip\Router\Generator\Traits;

use Nip\Request;
use Nip\Router\RequestContext;

/**
 * Trait HasRequestTrait
 * @package Nip\Router\Generator\Traits
 */
trait HasRequestTrait
{

    /**
     * Set the current request instance.
     *
     * @param  Request $request
     */
    public function setRequest(Request $request)
    {
        $context = (new RequestContext())->fromRequest($request);

        $this->cachedRoot = null;

The property cachedRoot does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->cachedSchema = null;

The property cachedSchema does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->setContext($context);

It seems like setContext() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}